[MIG] sale_cancel_reason: Migration to 19.0

Author: NachoAlesLopez

sale_cancel_reason/__manifest__.py

@@ -5,19 +5,19 @@
 
 {
     "name": "Sale Cancel Reason",
-    "version": "18.0.1.0.0",
+    "version": "19.0.1.0.0",
     "author": "Camptocamp,Odoo Community Association (OCA)",
     "category": "Sale",
     "license": "AGPL-3",
     "complexity": "normal",
     "website": "https://github.com/OCA/sale-workflow",
     "depends": ["sale"],
     "data": [
-        "wizard/cancel_reason_view.xml",
-        "wizard/mass_cancel_orders_view.xml",
-        "view/sale_view.xml",
-        "security/ir.model.access.csv",
         "data/sale_order_cancel_reason.xml",
+        "security/ir.model.access.csv",
+        "view/sale_view.xml",
+        "wizard/sale_order_cancel_wizard_views.xml",
+        "wizard/mass_cancel_orders_view.xml",
     ],
     "auto_install": False,
     "installable": True,

sale_cancel_reason/model/__init__.py

@@ -1,4 +1,4 @@
 # Copyright 2013 Guewen Baconnier, Camptocamp SA
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 
-from . import sale
+from . import sale_order

sale_cancel_reason/model/sale.py sale_cancel_reason/model/sale_order.pysale_cancel_reason/model/sale.py renamed to sale_cancel_reason/model/sale_order.py

@@ -16,17 +16,17 @@ class SaleOrder(models.Model):
         copy=False,
     )
 
-    def _show_cancel_wizard(self):
-        for order in self:
-            if not order._context.get("disable_cancel_warning"):
-                return True
-        return False
-
     def action_draft(self):
         res = super().action_draft()
         self.write({"cancel_reason_id": False})
         return res
 
+    def action_cancel_wizard(self):
+        self.ensure_one()
+        return self.env["sale.order.cancel.wizard"]._get_records_action(
+            target="new", context={"default_order_id": self.id}
+        )
+
 
 class SaleOrderCancelReason(models.Model):
     _name = "sale.order.cancel.reason"

sale_cancel_reason/security/ir.model.access.csv

@@ -1,3 +1,4 @@
 id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
 access_sale_order_cancel_reason_user,access_sale_order_cancel_reason user,model_sale_order_cancel_reason,sales_team.group_sale_salesman,1,0,0,0
 access_sale_order_cancel_reason_manager,access_sale_order_cancel_reason manager,model_sale_order_cancel_reason,sales_team.group_sale_manager,1,1,1,1
+access_sale_order_cancel_wizard,access.sale.order.cancel.wizard,model_sale_order_cancel_wizard,sales_team.group_sale_salesman,1,1,1,1

sale_cancel_reason/tests/test_sale_cancel_reason.py

@@ -1,26 +1,41 @@
 # Copyright 2013 Guewen Baconnier, Camptocamp SA
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 
-from odoo.tests.common import TransactionCase
+from odoo import Command
+from odoo.tests import Form, TransactionCase
 
 
 class TestSaleCancelReason(TransactionCase):
     @classmethod
     def setUpClass(cls):
         super().setUpClass()
+
         SaleOrder = cls.env["sale.order"]
         CancelReason = cls.env["sale.order.cancel.reason"]
+
         cls.reason = CancelReason.create({"name": "Canceled for tests"})
-        cls.partner = cls.env.ref("base.res_partner_2")
-        cls.product = cls.env.ref("product.product_product_7")
+        cls.partner = cls.env["res.partner"].create(
+            {
+                "name": "Test Customer",
+            }
+        )
+        cls.product = cls.env["product.product"].create(
+            {
+                "name": "Test Product",
+                "type": "consu",
+                "sale_ok": True,
+                "standard_price": 99.9,
+            }
+        )
         cls.sale_order_1 = SaleOrder.create(
             {
                 "partner_id": cls.partner.id,
                 "order_line": [
-                    (0, 0, {"product_id": cls.product.id, "product_uom_qty": 8})
+                    Command.create({"product_id": cls.product.id, "product_uom_qty": 8})
                 ],
             }
         )
+
         cls.sale_order_2 = cls.sale_order_1.copy()
         cls.sale_orders = cls.sale_order_1 + cls.sale_order_2
 
@@ -29,7 +44,7 @@ def test_sale_order_cancel_reason(self):
         - Cancel a sales order with the wizard asking for the reason.
         - Then the sale order should be canceled and the reason stored.
         """
-        SaleOrderCancel = self.env["sale.order.cancel"]
+        SaleOrderCancel = self.env["sale.order.cancel.wizard"]
         wizard = SaleOrderCancel.create(
             {"reason_id": self.reason.id, "order_id": self.sale_order_1.id}
         )
@@ -55,3 +70,24 @@ def test_sale_order_cancel_reason_mass_cancel(self):
                 {"cancel_reason_id": self.reason.id},
             ],
         )
+
+    def test_sale_order_cancel_draft(self):
+        """
+        When the order is canceled and then turned back to "draft", the cancellation
+         reason should be removed.
+        """
+        with Form.from_action(
+            self.env, self.sale_order_1.action_cancel_wizard()
+        ) as form:
+            form.reason_id = self.reason
+            wizard = form.save()
+
+        wizard.action_cancel()
+
+        self.assertEqual(self.sale_order_1.state, "cancel")
+        self.assertEqual(self.sale_order_1.cancel_reason_id, self.reason)
+
+        self.sale_order_1.action_draft()
+
+        self.assertEqual(self.sale_order_1.state, "draft")
+        self.assertFalse(self.sale_order_1.cancel_reason_id)

sale_cancel_reason/wizard/__init__.py

@@ -1,4 +1,5 @@
 # © 2013 Guewen Baconnier, Camptocamp SA
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 
-from . import cancel_reason, mass_cancel_orders
+from . import mass_cancel_orders
+from . import sale_order_cancel_wizard

sale_cancel_reason/wizard/cancel_reason_view.xml

@@ -7,12 +7,20 @@
 class SaleOrderCancel(models.TransientModel):
     """Ask a reason for the sale order cancellation."""
 
-    _inherit = "sale.order.cancel"
+    _name = "sale.order.cancel.wizard"
+    _description = "Sale Order Cancel Wizard"
 
+    order_id = fields.Many2one(
+        comodel_name="sale.order",
+        string="Order",
+        required=True,
+        ondelete="cascade",
+    )
     reason_id = fields.Many2one(
         "sale.order.cancel.reason", string="Reason", required=True
     )
 
     def action_cancel(self):
+        self.ensure_one()
         self.order_id.cancel_reason_id = self.reason_id
-        return super().action_cancel()
+        return self.order_id.action_cancel()

…le_cancel_reason/wizard/cancel_reason.py …eason/wizard/sale_order_cancel_wizard.pysale_cancel_reason/wizard/cancel_reason.py renamed to sale_cancel_reason/wizard/sale_order_cancel_wizard.py sale_cancel_reason/wizard/cancel_reason.py renamed to sale_cancel_reason/wizard/sale_order_cancel_wizard.py

@@ -0,0 +1,35 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<odoo>
+    <record id="sale_order_cancel_wizard_view_form" model="ir.ui.view">
+        <field name="name">sale.order.cancel.wizard.view.form</field>
+        <field name="model">sale.order.cancel.wizard</field>
+        <field name="arch" type="xml">
+            <form>
+                <sheet>
+                    <p>
+                        Are you sure you want to cancel this order? This may affect related documents or processes.
+                    </p>
+                    <p>
+                        Choose the reason for the cancellation of the
+                        sale order.
+                    </p>
+                    <group>
+                        <field
+                            name="reason_id"
+                            options="{'no_create': True, 'no_open': True}"
+                        />
+                    </group>
+                </sheet>
+                <footer>
+                    <button
+                        name="action_cancel"
+                        type="object"
+                        string="Cancel"
+                        class="btn-primary"
+                    />
+                    <button special="cancel" string="Discard" class="btn-secondary" />
+                </footer>
+            </form>
+        </field>
+    </record>
+</odoo>