[16.0][MIG] sale_pricelist_global_rule

Author: DucTruongKomit

sale_pricelist_global_rule/README.rst

@@ -2,7 +2,7 @@
 Sale pricelist global rule
 ==========================
 
-..
+.. 
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
    !! This file is generated by oca-gen-addon-readme !!
    !! changes will be overwritten.                   !!
@@ -52,30 +52,6 @@ quantities across lines allow the pricelist rule to apply, as they meet
 the minimum threshold (16 in the product template example and 20 in the
 product category example).
 
-**Global by Ancestor Product Category**
-
-This option allows defining a rule on an *ancestor category*, and it will
-apply to all products that belong to this category or any of its descendants.
-The minimum quantity check is performed on the **total ordered quantity**
-across all descendant categories.
-
-For example, suppose we have the following category tree:
-
-- Cat A
-  - Cat B
-  - Cat C
-    - Cat D
-
-And a pricelist rule is configured on *Cat C* with a minimum quantity = 5
-and a 20% discount.
-If a sales order contains:
-
-- Line 1: Product in Cat C, quantity = 4
-- Line 2: Product in Cat D, quantity = 2
-
-Then the total for Cat C’s branch = 6 (4 + 2), which meets the minimum
-threshold of 5. As a result, the 20% discount rule applies to both lines.
-
 **Table of contents**
 
 .. contents::
@@ -87,7 +63,6 @@ Configuration
 - Go to Sales -> Products -> Pricelist.
 - Create a new Pricelist and add at least one line with the Apply On
   option set to Global - Product template or Global - Product category
-  or Global - Ancestor Product Category
 - Choose the specific product template or category for the rule.
 - Set the computation mode and save
 
@@ -101,12 +76,6 @@ Usage
 - Click the **Recompute pricelist global** button to update prices
   according to the specified pricelist rules.
 
-When using **Ancestor Product Category**, the system will sum the ordered
-quantities of all products belonging to the selected ancestor category
-and all its descendants.
-If the accumulated quantity meets the rule’s minimum quantity, the
-discount will be applied to each matching order line.
-
 Known issues / Roadmap
 ======================
 
@@ -140,10 +109,6 @@ Contributors
   - Pedro M. Baeza
   - Carlos López
 
-- `Komit-consulting <https://komit-consulting.com/>`__
-
-  - Truong Duc
-
 Maintainers
 -----------
 

sale_pricelist_global_rule/__manifest__.py

@@ -2,8 +2,7 @@
     "name": "Sale pricelist global rule",
     "version": "16.0.1.0.0",
     "summary": "Apply a global rule to all sale order",
-    "author": "Tecnativa, Odoo Community Association (OCA),"
-    "Truong Duc (Komit-consulting)",
+    "author": "Tecnativa, Odoo Community Association (OCA)",
     "category": "Sales Management",
     "website": "https://github.com/OCA/sale-workflow",
     "depends": [

sale_pricelist_global_rule/models/product_pricelist.py

@@ -9,15 +9,10 @@ class ProductPricelistItem(models.Model):
         selection_add=[
             ("3_1_global_product_template", "Global - Product template"),
             ("3_2_global_product_category", "Global - Product category"),
-            (
-                "3_3_global_product_ancestor_category",
-                "Global - Ancestor Product Category",
-            ),
         ],
         ondelete={
             "3_1_global_product_template": "set default",
             "3_2_global_product_category": "set default",
-            "3_3_global_product_ancestor_category": "set default",
         },
     )
     global_product_tmpl_id = fields.Many2one(
@@ -31,9 +26,6 @@ class ProductPricelistItem(models.Model):
         "Product Category",
         ondelete="cascade",
     )
-    ancestor_product_category_id = fields.Many2one(
-        "product.category", ondelete="cascade"
-    )
 
     @api.constrains(
         "product_id",
@@ -65,16 +57,6 @@ def _check_product_consistency(self):
                         "for which this global rule should be applied"
                     )
                 )
-            elif (
-                item.applied_on == "3_3_global_product_ancestor_category"
-                and not item.ancestor_product_category_id
-            ):
-                raise ValidationError(
-                    _(
-                        "Please specify the product ancestor category for which this global"
-                        " rule should be applied"
-                    )
-                )
         return res
 
     @api.depends(
@@ -108,13 +90,6 @@ def _compute_name_and_price(self):
                 item.name = _("Global product: %s") % (
                     item.global_product_tmpl_id.display_name
                 )
-            elif (
-                item.ancestor_product_category_id
-                and item.applied_on == "3_3_global_product_ancestor_category"
-            ):
-                item.name = _("Ancestor product category: %s") % (
-                    item.ancestor_product_category_id.display_name
-                )
         return res
 
     @api.model_create_multi
@@ -130,7 +105,6 @@ def create(self, vals_list):
                             "product_tmpl_id": None,
                             "categ_id": None,
                             "global_product_tmpl_id": None,
-                            "ancestor_product_category_id": None,
                         }
                     )
                 elif applied_on == "3_1_global_product_template":
@@ -140,17 +114,6 @@ def create(self, vals_list):
                             "product_tmpl_id": None,
                             "categ_id": None,
                             "global_categ_id": None,
-                            "ancestor_product_category_id": None,
-                        }
-                    )
-                elif applied_on == "3_3_global_product_ancestor_category":
-                    values.update(
-                        {
-                            "product_id": None,
-                            "product_tmpl_id": None,
-                            "categ_id": None,
-                            "global_categ_id": None,
-                            "global_product_tmpl_id": None,
                         }
                     )
         return super().create(vals_list)
@@ -166,7 +129,6 @@ def write(self, values):
                         "product_tmpl_id": None,
                         "categ_id": None,
                         "global_product_tmpl_id": None,
-                        "ancestor_product_category_id": None,
                     }
                 )
             elif applied_on == "3_1_global_product_template":
@@ -176,17 +138,6 @@ def write(self, values):
                         "product_tmpl_id": None,
                         "categ_id": None,
                         "global_categ_id": None,
-                        "ancestor_product_category_id": None,
-                    }
-                )
-            elif applied_on == "3_3_global_product_ancestor_category":
-                values.update(
-                    {
-                        "product_id": None,
-                        "product_tmpl_id": None,
-                        "categ_id": None,
-                        "global_categ_id": None,
-                        "global_product_tmpl_id": None,
                     }
                 )
         return super().write(values)
@@ -204,26 +155,19 @@ def _is_applicable_for(self, product, qty_in_product_uom):
         :rtype: bool
         """
         self.ensure_one()
-        qty_data = (
-            self.env.context.get("pricelist_global_cummulative_quantity", {}) or {}
-        )
-        supported = {
+        qty_data = self.env.context.get("pricelist_global_cummulative_quantity", {})
+        if not qty_data or self.applied_on not in [
             "3_1_global_product_template",
             "3_2_global_product_category",
-            "3_3_global_product_ancestor_category",
-        }
-        # Fallback to base behavior if not a supported global case or no context
-        if not qty_data or self.applied_on not in supported:
+        ]:
             return super()._is_applicable_for(product, qty_in_product_uom)
-
         is_applicable = True
         if self.applied_on == "3_1_global_product_template":
             total_qty = qty_data["by_template"].get(product.product_tmpl_id, 0.0)
             if self.min_quantity and total_qty < self.min_quantity:
                 is_applicable = False
             elif self.global_product_tmpl_id != product.product_tmpl_id:
                 is_applicable = False
-        # Global Product Category
         elif self.applied_on == "3_2_global_product_category":
             total_qty = qty_data["by_categ"].get(product.categ_id, 0.0)
             if self.min_quantity and total_qty < self.min_quantity:
@@ -232,85 +176,4 @@ def _is_applicable_for(self, product, qty_in_product_uom):
                 self.global_categ_id.parent_path
             ):
                 is_applicable = False
-        # Global Product Category
-        elif self.applied_on == "3_3_global_product_ancestor_category":
-            ancestor_categ = self.ancestor_product_category_id
-            if not ancestor_categ:
-                return False
-
-            Category = self.env["product.category"]
-
-            # ancestor + all descendants (fast, uses parent_path internally)
-            child_categories = Category.search([("id", "child_of", ancestor_categ.id)])
-
-            # product's category must belong to this ancestor branch
-            prod_categ = product.categ_id
-            if not prod_categ or prod_categ not in child_categories:
-                return False
-
-            # Normalize by_categ keys to ids: {id: qty}
-            by_categ_raw = qty_data.get("by_categ") or {}
-            by_categ_id = {
-                (k.id if hasattr(k, "id") else int(k)): v
-                for k, v in by_categ_raw.items()
-            }
-
-            # Sum total quantity across the whole ancestor branch
-            total_qty = sum(by_categ_id.get(cid, 0.0) for cid in child_categories.ids)
-
-            # Check minimum quantity threshold over the branch total
-            if self.min_quantity and total_qty < self.min_quantity:
-                is_applicable = False
-
-        if not is_applicable:
-            return False
-        # --------------------------------------------------------------
-        # Ensure current price item has best discount
-        #
-        # By default Odoo will just pick the first applicable rule  based on sequence.
-        # That means if two percentage rules apply to the same product
-        # (e.g. Cat A = 10%, Cat C = 20%), the system might pick the 10% rule just
-        # because it comes first. Therefore, we need the code below to check if the
-        # current price item is already higher discount.
-        # --------------------------------------------------------------
-        if self._has_better_percentage_rule(product, qty_in_product_uom):
-            is_applicable = False
         return is_applicable
-
-    def _has_better_percentage_rule(self, product, qty_in_product_uom):
-        """
-        Check if there is another percentage rule that should take precedence.
-        This prevents a weaker discount (lower percent_price) from overriding
-        a stronger one when multiple percentage rules apply.
-        """
-        if (
-            self.compute_price != "percentage"
-            or not self.percent_price
-            or self.env.context.get("skip_best_percent_check")
-        ):
-            return False
-
-        # Fetch all other percentage rules from the same pricelist
-        # context skip_best_percent_check to avoid run forever
-        items = self.pricelist_id.item_ids.with_context(
-            skip_best_percent_check=True
-        ).filtered(
-            lambda it: it.id != self.id
-            and it.compute_price == "percentage"
-            and it.percent_price not in (False, None)
-        )
-        for it in items:
-            # Check if rival rule also applies to this product & quantity
-            if not it._is_applicable_for(product, qty_in_product_uom):
-                continue
-
-            # Among applicable percentage rules:
-            #   1. Prefer higher percent_price
-            #   2. If tied, prefer older rule (smaller create_date)
-            if it.percent_price > self.percent_price or (
-                it.percent_price == self.percent_price
-                and it.create_date < self.create_date
-            ):
-                return True
-
-        return False

sale_pricelist_global_rule/readme/CONTRIBUTORS.md

@@ -1,4 +1,3 @@
 - [Tecnativa](https://www.tecnativa.com)
   - Pedro M. Baeza
   - Carlos López
-  - Truong Duc (Komit-consulting)

sale_pricelist_global_rule/tests/__init__.py

@@ -1,2 +1 @@
-from . import test_pricelist_ancestor
 from . import test_pricelist_global