Skip to content

Commit e46c7bc

Browse files
committed
[IMP] sale_auto_remove_zero_quantity_lines: Improved action_confirm method.
1 parent 12265fd commit e46c7bc

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

sale_auto_remove_zero_quantity_lines/models/sale_order.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ def _should_auto_remove_zero_quantity_lines(self):
1212
return self.company_id.sale_auto_remove_zero_quantity_lines
1313

1414
def action_confirm(self):
15+
all_lines_to_unlink = self.env["sale.order.line"].browse()
1516
for order in self:
1617
if order._should_auto_remove_zero_quantity_lines():
1718
zero_or_empty_lines = order.order_line.filtered(
@@ -24,5 +25,9 @@ def action_confirm(self):
2425
"removed upon confirmation."
2526
)
2627
order.message_post(body=body)
27-
zero_or_empty_lines.unlink()
28+
all_lines_to_unlink |= zero_or_empty_lines
29+
30+
if all_lines_to_unlink:
31+
all_lines_to_unlink.unlink()
32+
2833
return super().action_confirm()

0 commit comments

Comments
 (0)