fixup! Add error in case of dependency module version mismatch

Author: grindtildeath

sale_triple_discount/__init__.py

@@ -1 +1,2 @@
 from . import models
+from .hooks import post_load

sale_triple_discount/__manifest__.py

@@ -16,4 +16,5 @@
     "depends": ["sale_management", "account_invoice_triple_discount"],
     "data": ["views/sale_order_report.xml", "views/sale_order_view.xml"],
     "installable": True,
+    "post_load": "post_load",
 }

sale_triple_discount/hooks.py

@@ -0,0 +1,24 @@
+# Copyright 2024 Camptocamp SA
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl)
+import logging
+
+import pkg_resources
+
+from odoo.modules.module import get_manifest
+
+_logger = logging.getLogger(__name__)
+
+
+def post_load():
+    account_invoice_triple_discount_manifest = get_manifest(
+        "account_invoice_triple_discount"
+    )
+    if not pkg_resources.parse_version(
+        account_invoice_triple_discount_manifest["version"]
+    ) >= pkg_resources.parse_version("16.0.2.0.0"):
+        msg = (
+            "Module sale_triple_discount requires module "
+            "account_invoice_triple_discount >= 16.0.2.0.0"
+        )
+        _logger.error(msg)
+        raise Exception(msg)

sale_triple_discount/models/sale_order_line.py

@@ -3,15 +3,8 @@
 # Copyright 2017 Tecnativa - David Vidal
 # Copyright 2018 Simone Rubino - Agile Business Group
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
-import logging
-import pkg_resources
-
 from odoo import _, api, fields, models
 from odoo.exceptions import ValidationError
-from odoo.modules.module import get_manifest
-
-
-_logger = logging.getLogger(__name__)
 
 
 class SaleOrderLine(models.Model):
@@ -167,10 +160,3 @@ def _prepare_invoice_line(self, **kwargs):
         else:
             res.update({"discount1": self.discount})
         return res
-
-    def _register_hook(self):
-        account_invoice_triple_discount_manifest = get_manifest("account_invoice_triple_discount")
-        if not pkg_resources.parse_version(
-            account_invoice_triple_discount_manifest["version"]
-        ) >= pkg_resources.parse_version("16.0.2.0.0"):
-            _logger.error("Module sale_triple_discount requires module account_invoice_triple_discount >= 16.0.2.0.0")