[18.0][BUG] sale_partner_primeship : tests are failing from 11pm to midnight

[metaminux]

Not sure yet about this, but I encountered some tests failures in sale_partner_primeship when updating an unrelated PR for sale_invoice_delivery_state

Module

sale_partner_primeship

Describe the bug

This is the logs I had when running tests for #4183 (test job : https://github.com/OCA/sale-workflow/actions/runs/22646567189/job/65635911957?pr=4183)

2026-03-03 23:01:26,944 438 INFO odoo odoo.modules.loading: Loading module sale_partner_primeship (174/267) 
2026-03-03 23:01:27,395 438 INFO odoo odoo.modules.registry: module sale_partner_primeship: creating or updating database tables 
2026-03-03 23:01:27,415 438 INFO odoo odoo.models: Prepare computation of res.partner.active_primeship 
2026-03-03 23:01:27,791 438 INFO odoo odoo.modules.loading: loading sale_partner_primeship/views/product_template_views.xml 
2026-03-03 23:01:27,823 438 INFO odoo odoo.modules.loading: loading sale_partner_primeship/views/sale_primeship_views.xml 
2026-03-03 23:01:27,839 438 INFO odoo odoo.modules.loading: loading sale_partner_primeship/views/res_partner_views.xml 
2026-03-03 23:01:27,866 438 INFO odoo odoo.modules.loading: loading sale_partner_primeship/security/ir.model.access.csv 
2026-03-03 23:01:27,877 438 INFO odoo odoo.modules.loading: loading sale_partner_primeship/security/sale_partner_primeship.xml 
2026-03-03 23:01:27,882 438 INFO odoo odoo.modules.loading: loading sale_partner_primeship/data/ir_cron.xml 
2026-03-03 23:01:28,013 438 INFO odoo odoo.addons.sale_partner_primeship.tests.test_res_partner_primeship: Starting TestResPartnerPrimeship.test_check_expired_primeships ... 
2026-03-03 23:01:28,030 438 INFO odoo odoo.addons.sale_partner_primeship.tests.test_res_partner_primeship: ====================================================================== 
2026-03-03 23:01:28,030 438 ERROR odoo odoo.addons.sale_partner_primeship.tests.test_res_partner_primeship: FAIL: TestResPartnerPrimeship.test_check_expired_primeships
Traceback (most recent call last):
  File "/__w/sale-workflow/sale-workflow/sale_partner_primeship/tests/test_res_partner_primeship.py", line 52, in test_check_expired_primeships
    self.assertFalse(self.partner.active_primeship)
AssertionError: True is not false
 
2026-03-03 23:01:28,042 438 INFO odoo odoo.addons.sale_partner_primeship.tests.test_res_partner_primeship: Starting TestResPartnerPrimeship.test_compute_active_primeship ... 
2026-03-03 23:01:28,063 438 INFO odoo odoo.addons.sale_partner_primeship.tests.test_res_partner_primeship: Starting TestResPartnerPrimeship.test_compute_primeship_count ... 
2026-03-03 23:01:28,524 438 INFO odoo odoo.addons.base.models.ir_attachment: filestore gc 0 checked, 0 removed 
2026-03-03 23:01:28,710 438 INFO odoo odoo.addons.sale_partner_primeship.tests.test_sale_order_primeship: Starting TestSaleOrderPrimeship.test_action_cancel_deactivates_primeship ... 
2026-03-03 23:01:28,912 438 INFO odoo odoo.models.unlink: User #1 deleted stock.move.line records with IDs: [99] 
2026-03-03 23:01:29,062 438 INFO odoo odoo.addons.sale_partner_primeship.tests.test_sale_order_primeship: Starting TestSaleOrderPrimeship.test_action_confirm_creates_primeship ... 
2026-03-03 23:01:29,215 438 INFO odoo odoo.addons.sale_partner_primeship.tests.test_sale_order_primeship: ====================================================================== 
2026-03-03 23:01:29,215 438 ERROR odoo odoo.addons.sale_partner_primeship.tests.test_sale_order_primeship: FAIL: TestSaleOrderPrimeship.test_action_confirm_creates_primeship
Traceback (most recent call last):
  File "/__w/sale-workflow/sale-workflow/sale_partner_primeship/tests/test_sale_order_primeship.py", line 19, in test_action_confirm_creates_primeship
    self.assertEqual(order_line.primeship_id.start_date, date.today())
AssertionError: datetime.date(2026, 3, 4) != datetime.date(2026, 3, 3)
 
2026-03-03 23:01:29,226 438 INFO odoo odoo.addons.sale_partner_primeship.tests.test_sale_order_primeship: Starting TestSaleOrderPrimeship.test_action_confirm_extends_existing_primeship ... 
2026-03-03 23:01:29,383 438 INFO odoo odoo.addons.sale_partner_primeship.tests.test_sale_order_primeship: Starting TestSaleOrderPrimeship.test_action_confirm_with_existing_primeship ... 
2026-03-03 23:01:29,570 438 INFO odoo odoo.models.unlink: User #1 deleted stock.move.line records with IDs: [102] 
2026-03-03 23:01:29,698 438 INFO odoo odoo.models.unlink: User #1 deleted stock.move.line records with IDs: [103] 
2026-03-03 23:01:29,814 438 INFO odoo odoo.addons.sale_partner_primeship.tests.test_sale_order_primeship: Starting TestSaleOrderPrimeship.test_prepare_invoice_line_with_primeship ... 
2026-03-03 23:01:30,414 438 INFO odoo odoo.addons.base.models.ir_attachment: filestore gc 0 checked, 0 removed 
2026-03-03 23:01:30,603 438 INFO odoo odoo.addons.sale_partner_primeship.tests.test_sale_primeship: Starting TestSalePrimeship.test_check_end_date ... 
2026-03-03 23:01:30,627 438 INFO odoo odoo.addons.sale_partner_primeship.tests.test_sale_primeship: Starting TestSalePrimeship.test_compute_current ... 
2026-03-03 23:01:30,636 438 INFO odoo odoo.addons.sale_partner_primeship.tests.test_sale_primeship: ====================================================================== 
2026-03-03 23:01:30,636 438 ERROR odoo odoo.addons.sale_partner_primeship.tests.test_sale_primeship: FAIL: TestSalePrimeship.test_compute_current
Traceback (most recent call last):
  File "/__w/sale-workflow/sale-workflow/sale_partner_primeship/tests/test_sale_primeship.py", line 31, in test_compute_current
    self.assertTrue(primeship_current.current)
AssertionError: False is not true
 
2026-03-03 23:01:30,647 438 INFO odoo odoo.addons.sale_partner_primeship.tests.test_sale_primeship: Starting TestSalePrimeship.test_compute_name ... 
2026-03-03 23:01:30,662 438 INFO odoo odoo.addons.sale_partner_primeship.tests.test_sale_primeship: Starting TestSalePrimeship.test_non_overlapping_primeships ... 
2026-03-03 23:01:30,677 438 INFO odoo odoo.addons.sale_partner_primeship.tests.test_sale_primeship: Starting TestSalePrimeship.test_overlapping_primeships ... 
2026-03-03 23:01:30,697 438 INFO odoo odoo.addons.sale_partner_primeship.tests.test_sale_primeship: Starting TestSalePrimeship.test_overlaps_method ... 
2026-03-03 23:01:30,711 438 INFO odoo odoo.addons.sale_partner_primeship.tests.test_sale_primeship: Starting TestSalePrimeship.test_sale_order_line_sale_primeship_o2o_relation_sql_constraint ... 
2026-03-03 23:01:31,254 438 INFO odoo odoo.addons.base.models.ir_attachment: filestore gc 0 checked, 0 removed 
2026-03-03 23:01:31,448 438 INFO odoo odoo.modules.loading: Module sale_partner_primeship loaded in 4.50s (incl. 3.35s test), 332 queries (+1506 test, +332 other) 
2026-03-03 23:01:31,448 438 ERROR odoo odoo.modules.loading: Module sale_partner_primeship: 3 failures, 0 errors of 15 tests 

To Reproduce

18.0:

Steps to reproduce the behavior:

1. Update a PR between 11pm and midnight UTC

Expected behavior
Tests are OK

Additional context
Other jobs failed due to this bug :

• PR [18.0][MIG] sale_order_mass_action: Migration to 18.0 #4130 : see https://github.com/OCA/sale-workflow/actions/runs/21417551796/job/61669587461 (mentionned here : [18.0][MIG] sale_order_mass_action: Migration to 18.0 #4130 (comment))
• PR [18.0][MIG][IMP] sale_restricted_qty #3959 : see https://github.com/OCA/sale-workflow/actions/runs/22555021365
• but also commit from Weblate : see https://github.com/OCA/sale-workflow/actions/runs/21417878964

[metaminux]

Hello @nayatec and @paradoxxxzero

As maintainers of the module, can you look at this issue ?

Tests are now failing from 10pm to midnight (see #3752 last tests)... Anything related to a french partner which is now GMT+2 ?

[nayatec]

Hi @metaminux good catch thks, and many thks to @sergiocorato for the fix !

[metaminux]

Resolved through #4251 and #4257