diff --git a/sale_advance_payment/models/sale.py b/sale_advance_payment/models/sale.py index 001309bd873..ad9b5a36d57 100644 --- a/sale_advance_payment/models/sale.py +++ b/sale_advance_payment/models/sale.py @@ -82,7 +82,9 @@ def _compute_advance_payment(self): # Consider payments in related invoices. invoice_paid_amount = 0.0 for inv in order.invoice_ids: - invoice_paid_amount += inv.amount_total - inv.amount_residual + invoice_paid_amount += ( + inv.amount_total_signed - inv.amount_residual_signed + ) amount_residual = order.amount_total - advance_amount - invoice_paid_amount payment_state = "not_paid" if mls: diff --git a/sale_advance_payment/tests/test_sale_advance_payment.py b/sale_advance_payment/tests/test_sale_advance_payment.py index d914f6069dd..a08a6cccba3 100644 --- a/sale_advance_payment/tests/test_sale_advance_payment.py +++ b/sale_advance_payment/tests/test_sale_advance_payment.py @@ -482,3 +482,33 @@ def test_04_sale_advance_payment_multi_inv_validate_wiz(self): payments = invoice.invoice_outstanding_credits_debits_widget result = [d["amount"] for d in payments["content"]] self.assertEqual(set(payment_list), set(result)) + + def test_05_residual_amount_credit_note(self): + self.sale_order_1.action_confirm() + self.sale_order_1._create_invoices() + invoice = self.sale_order_1.invoice_ids[0] + invoice.invoice_date = fields.Date.today() + invoice.action_post() + self.env["account.payment.register"].with_context( + active_model="account.move", active_ids=invoice.ids + ).create( + { + "amount": 3600.0, + "group_payment": True, + "payment_difference_handling": "open", + } + )._create_payments() + self.assertEqual(self.sale_order_1.amount_residual, 0) + credit_note = invoice._reverse_moves() + credit_note.invoice_date = fields.Date.today() + credit_note.action_post() + self.env["account.payment.register"].with_context( + active_model="account.move", active_ids=credit_note.ids + ).create( + { + "amount": 3600.0, + "group_payment": True, + "payment_difference_handling": "open", + } + )._create_payments() + self.assertEqual(self.sale_order_1.amount_residual, 3600)