[MIG] base_name_search_improved: Migration to 19.0

bizzappdev · bizzappdev · commit b4dea29ba03b · 2026-01-20T18:42:01.000+05:30
diff --git a/base_name_search_improved/README.rst b/base_name_search_improved/README.rst
@@ -21,13 +21,13 @@ Improved Name Search
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fserver--tools-lightgray.png?logo=github
-    :target: https://github.com/OCA/server-tools/tree/18.0/base_name_search_improved
+    :target: https://github.com/OCA/server-tools/tree/19.0/base_name_search_improved
     :alt: OCA/server-tools
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-base_name_search_improved
+    :target: https://translation.odoo-community.org/projects/server-tools-19-0/server-tools-19-0-base_name_search_improved
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/server-tools&target_branch=18.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/server-tools&target_branch=19.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -61,9 +61,9 @@ added on searches that would normally yield results.
 But if not enough results are found, then additional search methods are
 tried. The specific methods used are:
 
-- Try regular search on each of the additional fields
-- Try ordered word search on each of the search fields
-- Try unordered word search on each of the search fields
+-  Try regular search on each of the additional fields
+-  Try ordered word search on each of the search fields
+-  Try unordered word search on each of the search fields
 
 All results found are presented in that order, hopefully presenting them
 in order of relevance.
@@ -98,28 +98,28 @@ Just type into any related field, such as Customer on a Sale Order.
 Known issues / Roadmap
 ======================
 
-- Also use fuzzy search, such as the Levenshtein distance:
-  https://www.postgresql.org/docs/9.5/static/fuzzystrmatch.html
-- The list of additional fields to search could benefit from caching,
-  for efficiency.
-- This feature could also be implemented for regular ``search`` on the
-  ``name`` field.
-- While adding m2o or other related field that also have an improved
-  name search, that improved name search is not used (while if
-  name_search is customizend on a module and you add a field of that
-  model on another model it works ok). Esto por ejemplo es en productos
-  si agregamos campo "categoría pública" y a categoría pública le
-  ponemos "parent_id". Entonces vamos a ver que si buscamos por una
-  categoría padre no busca nada, en vez si hacemos esa lógica en
-  name_search de modulo si funciona
+-  Also use fuzzy search, such as the Levenshtein distance:
+   `https://www.postgresql.org/docs/9.5/static/fuzzystrmatch.html <https://www.postgresql.org/docs/9.5/static/fuzzystrmatch.html>`__
+-  The list of additional fields to search could benefit from caching,
+   for efficiency.
+-  This feature could also be implemented for regular ``search`` on the
+   ``name`` field.
+-  While adding m2o or other related field that also have an improved
+   name search, that improved name search is not used (while if
+   name_search is customizend on a module and you add a field of that
+   model on another model it works ok). Esto por ejemplo es en productos
+   si agregamos campo "categoría pública" y a categoría pública le
+   ponemos "parent_id". Entonces vamos a ver que si buscamos por una
+   categoría padre no busca nada, en vez si hacemos esa lógica en
+   name_search de modulo si funciona
 
 Bug Tracker
 ===========
 
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/server-tools/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/server-tools/issues/new?body=module:%20base_name_search_improved%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/server-tools/issues/new?body=module:%20base_name_search_improved%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -135,16 +135,17 @@ Authors
 Contributors
 ------------
 
-- Daniel Reis <https://github.com/dreispt>
-- Kitti U. <kittiu@ecosoft.co.th> (migrate to v14)
-- Radovan Skolnik <radovan@skolnik.info>
+-  Daniel Reis
+   <`https://github.com/dreispt <https://github.com/dreispt>`__>
+-  Kitti U. <kittiu@ecosoft.co.th> (migrate to v14)
+-  Radovan Skolnik <radovan@skolnik.info>
 
 Other credits
 -------------
 
 The development of this module has been financially supported by:
 
-- Odoo Community Association
+-  Odoo Community Association
 
 Maintainers
 -----------
@@ -159,6 +160,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/server-tools <https://github.com/OCA/server-tools/tree/18.0/base_name_search_improved>`_ project on GitHub.
+This module is part of the `OCA/server-tools <https://github.com/OCA/server-tools/tree/19.0/base_name_search_improved>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.
diff --git a/base_name_search_improved/__manifest__.py b/base_name_search_improved/__manifest__.py
@@ -3,7 +3,7 @@
 {
     "name": "Improved Name Search",
     "summary": "Friendlier search when typing in relation fields",
-    "version": "18.0.1.1.0",
+    "version": "19.0.1.0.0",
     "category": "Uncategorized",
     "website": "https://github.com/OCA/server-tools",
     "author": "Daniel Reis, Odoo Community Association (OCA), ADHOC SA",
diff --git a/base_name_search_improved/models/ir_model.py b/base_name_search_improved/models/ir_model.py
@@ -8,14 +8,14 @@
 
 from odoo import api, fields, models, tools
 from odoo.exceptions import ValidationError
-from odoo.osv import expression
+from odoo.fields import Domain
 
 _logger = logging.getLogger(__name__)
 # Extended name search is only used on some operators
 ALLOWED_OPS = {"ilike", "like"}
 
 
-@tools.ormcache(skiparg=0)
+@tools.ormcache()
 def _get_rec_names(self):
     "List of fields to search into"
     model = self.env["ir.model"].search([("model", "=", str(self._name))])
@@ -24,7 +24,7 @@ def _get_rec_names(self):
     return rec_name + other_names
 
 
-@tools.ormcache(skiparg=0)
+@tools.ormcache()
 def _get_use_smart_name_search(self):
     return (
         self.env["ir.model"]
@@ -33,7 +33,7 @@ def _get_use_smart_name_search(self):
     )
 
 
-@tools.ormcache(skiparg=0)
+@tools.ormcache()
 def _get_add_smart_search(self):
     "Add Smart Search on search views"
     model = self.env["ir.model"].search([("model", "=", str(self._name))])
@@ -43,7 +43,7 @@ def _get_add_smart_search(self):
     return False
 
 
-@tools.ormcache(skiparg=0)
+@tools.ormcache()
 def _get_name_search_domain(self):
     "Add Smart Search on search views"
     name_search_domain = (
@@ -95,27 +95,27 @@ def _search_smart_search(self, operator, value):
         return []
 
     @api.model
-    def name_search(self, name="", args=None, operator="ilike", limit=100):
+    def name_search(self, name="", domain=None, operator="ilike", limit=100):
         if not name or not (
             self.env.context.get("force_smart_name_search", False)
             or _get_use_smart_name_search(self.sudo())
         ):
-            return super().name_search(name, args, operator, limit)
+            return super().name_search(name, domain, operator, limit)
 
         # Support a list of fields to search on
         all_names = _get_rec_names(self.sudo())
-        base_domain = args or []
+        base_domain = domain or []
         limit = limit or 0
         results = []
 
         # Try regular search on each additional search field
         for rec_name in all_names:
-            domain = expression.AND([base_domain, [(rec_name, operator, name)]])
+            domain = Domain.AND([base_domain, [(rec_name, operator, name)]])
             results = _extend_name_results(self, domain, results, limit)
 
         # Try ordered word search on each of the search fields
         for rec_name in all_names:
-            domain = expression.AND(
+            domain = Domain.AND(
                 [base_domain, [(rec_name, operator, name.replace(" ", "%"))]]
             )
             results = _extend_name_results(self, domain, results, limit)
@@ -126,16 +126,16 @@ def name_search(self, name="", args=None, operator="ilike", limit=100):
         if " " in name:
             unordered_domain = []
             for word in name.split():
-                word_domain = expression.OR(
+                word_domain = Domain.OR(
                     [[(rec_name, operator, word)] for rec_name in all_names]
                 )
                 unordered_domain = (
-                    expression.AND([unordered_domain, word_domain])
+                    Domain.AND([unordered_domain, word_domain])
                     if unordered_domain
                     else word_domain
                 )
             results = _extend_name_results(
-                self, expression.AND([base_domain, unordered_domain]), results, limit
+                self, Domain.AND([base_domain, unordered_domain]), results, limit
             )
 
         results = results[:limit]
@@ -211,7 +211,7 @@ def check_name_search_domain(self):
                 RecursionError,
             ) as e:
                 raise ValidationError(
-                    self.env._("Couldn't eval Name Search Domain (%s)") % e
+                    self.env._("Couldn't eval Name Search Domain (%s)", e)
                 ) from e
             if not isinstance(name_search_domain, list):
                 raise ValidationError(
@@ -226,17 +226,26 @@ def write(self, vals):
     def _register_hook(self):
         def make_smart_name_search(original_name_search):
             def wrapper(
-                self, name="", args=None, operator="ilike", limit=100, **kwargs
+                self, name="", domain=None, operator="ilike", limit=100, **kwargs
             ):
                 original_results = original_name_search(
-                    self, name, args, operator, limit, **kwargs
+                    self,
+                    name=name,
+                    domain=domain,
+                    operator=operator,
+                    limit=limit,
+                    **kwargs,
                 )
                 if not name or (limit and len(original_results) >= limit):
                     return original_results
                 seen_ids = {res[0] for res in original_results}
                 remaining_limit = limit - len(original_results) if limit else None
                 smart_results = Base.name_search(
-                    self, name=name, args=args, operator=operator, limit=remaining_limit
+                    self,
+                    name=name,
+                    domain=domain,
+                    operator=operator,
+                    limit=remaining_limit,
                 )
                 additional_results = [
                     (res_id, res_name)
diff --git a/base_name_search_improved/static/description/index.html b/base_name_search_improved/static/description/index.html
@@ -374,7 +374,7 @@ <h1>Improved Name Search</h1>
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:506ec7a25a0bb1d86a79c06d4577aca5a3cda5d81ed921490e95a53a5e49df24
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/server-tools/tree/18.0/base_name_search_improved"><img alt="OCA/server-tools" src="https://img.shields.io/badge/github-OCA%2Fserver--tools-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-base_name_search_improved"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/server-tools&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/server-tools/tree/19.0/base_name_search_improved"><img alt="OCA/server-tools" src="https://img.shields.io/badge/github-OCA%2Fserver--tools-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/server-tools-19-0/server-tools-19-0-base_name_search_improved"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/server-tools&amp;target_branch=19.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>Extends the name search feature to use additional, more relaxed matching
 methods, and to allow searching into configurable additional record
 fields.</p>
@@ -455,7 +455,7 @@ <h2><a class="toc-backref" href="#toc-entry-4">Bug Tracker</a></h2>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/server-tools/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/server-tools/issues/new?body=module:%20base_name_search_improved%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/server-tools/issues/new?body=module:%20base_name_search_improved%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -470,7 +470,8 @@ <h3><a class="toc-backref" href="#toc-entry-6">Authors</a></h3>
 <div class="section" id="contributors">
 <h3><a class="toc-backref" href="#toc-entry-7">Contributors</a></h3>
 <ul class="simple">
-<li>Daniel Reis &lt;<a class="reference external" href="https://github.com/dreispt">https://github.com/dreispt</a>&gt;</li>
+<li>Daniel Reis
+&lt;<a class="reference external" href="https://github.com/dreispt">https://github.com/dreispt</a>&gt;</li>
 <li>Kitti U. &lt;<a class="reference external" href="mailto:kittiu&#64;ecosoft.co.th">kittiu&#64;ecosoft.co.th</a>&gt; (migrate to v14)</li>
 <li>Radovan Skolnik &lt;<a class="reference external" href="mailto:radovan&#64;skolnik.info">radovan&#64;skolnik.info</a>&gt;</li>
 </ul>
@@ -491,7 +492,7 @@ <h3><a class="toc-backref" href="#toc-entry-9">Maintainers</a></h3>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/server-tools/tree/18.0/base_name_search_improved">OCA/server-tools</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/server-tools/tree/19.0/base_name_search_improved">OCA/server-tools</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>
diff --git a/base_name_search_improved/tests/test_name_search.py b/base_name_search_improved/tests/test_name_search.py
@@ -71,7 +71,7 @@ def test_NameSearchDomain(self):
 
     def test_MustHonorDomain(self):
         """Must also honor a provided Domain"""
-        res = self.Partner.name_search("+351", args=[("vat", "=", "3333")])
+        res = self.Partner.name_search("+351", domain=[("vat", "=", "3333")])
         gambulputty = self.partner3.id
         self.assertEqual(len(res), 1)
         self.assertEqual(res[0][0], gambulputty)
@@ -105,7 +105,7 @@ def test_SmartSearchWarning(self):
                 "ttype": "char",
                 "model_id": self.model_partner.id,
                 "model": self.model_partner.model,
-                "translate": True,
+                "translate": "standard",
             }
         )
         self.model_partner.name_search_ids = [(4, translatable_field.id)]

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`{`
`4`	`4`	`"name": "Improved Name Search",`
`5`	`5`	`"summary": "Friendlier search when typing in relation fields",`
`6`		`- "version": "18.0.1.1.0",`
	`6`	`+ "version": "19.0.1.0.0",`
`7`	`7`	`"category": "Uncategorized",`
`8`	`8`	`"website": "https://github.com/OCA/server-tools",`
`9`	`9`	`"author": "Daniel Reis, Odoo Community Association (OCA), ADHOC SA",`