[IMP] shoppingfeed_integration: auto-pay channel out_refund

TT63051

Author: juancarlosonate-tecnativa

shoppingfeed_integration/models/account_move.py

@@ -81,7 +81,10 @@ def _shoppingfeed_upload_invoice(self):
 
     def _shoppingfeed_auto_pay(self):
         for move in self:
-            if move.move_type != "out_invoice" or move.payment_state == "paid":
+            if (
+                move.move_type not in ("out_invoice", "out_refund")
+                or move.payment_state == "paid"
+            ):
                 continue
             sale_orders = move.line_ids.sale_line_ids.order_id.filtered(
                 lambda so, move=move: so.company_id == move.company_id
@@ -90,13 +93,23 @@ def _shoppingfeed_auto_pay(self):
             channel = sale_order.shoppingfeed_channel_id
             if not sale_order or not channel or not channel.auto_pay:
                 continue
-            if (
-                not move.preferred_payment_method_line_id
-                and channel.payment_method_line_id
-            ):
-                move.preferred_payment_method_line_id = channel.payment_method_line_id
-            if not move.preferred_payment_method_line_id:
-                continue
+            if move.move_type == "out_refund":
+                # Force the outbound mirror line: the computed preferred for a
+                # sale document is the partner inbound line, invalid here.
+                method_line = channel._shoppingfeed_get_refund_payment_method_line()
+                if not method_line:
+                    continue
+                move.preferred_payment_method_line_id = method_line
+            else:
+                if (
+                    not move.preferred_payment_method_line_id
+                    and channel.payment_method_line_id
+                ):
+                    move.preferred_payment_method_line_id = (
+                        channel.payment_method_line_id
+                    )
+                if not move.preferred_payment_method_line_id:
+                    continue
             self.env["account.payment.register"].with_context(
                 active_model="account.move",
                 active_ids=move.ids,

shoppingfeed_integration/models/shoppingfeed_channel.py

@@ -109,3 +109,17 @@ class ShoppingfeedChannel(models.Model):
             " channel."
         ),
     )
+
+    def _shoppingfeed_get_refund_payment_method_line(self):
+        self.ensure_one()
+        inbound = self.payment_method_line_id
+        if not inbound or not inbound.payment_account_id:
+            return self.env["account.payment.method.line"]
+        return self.env["account.payment.method.line"].search(
+            [
+                ("journal_id", "=", inbound.journal_id.id),
+                ("payment_type", "=", "outbound"),
+                ("payment_account_id", "=", inbound.payment_account_id.id),
+            ],
+            limit=1,
+        )

shoppingfeed_integration/tests/test_shoppingfeed_integration.py

@@ -13,6 +13,9 @@ class TestShoppingfeedIntegration(AccountTestInvoicingCommon):
     def setUpClass(cls):
         super().setUpClass()
         cls.bank_journal = cls.company_data["default_journal_bank"]
+        cls.market_account = cls.company_data["default_account_receivable"].copy(
+            {"name": "SF Market Clearing"}
+        )
         cls.inbound_payment_method_line = cls.env["account.payment.method.line"].create(
             {
                 "name": "SF Inbound Payment Method",
@@ -21,6 +24,21 @@ def setUpClass(cls):
                 ].id,
                 "payment_type": "inbound",
                 "journal_id": cls.bank_journal.id,
+                "payment_account_id": cls.market_account.id,
+            }
+        )
+        cls.outbound_manual_method = cls.env["account.payment.method"].search(
+            [("code", "=", "manual"), ("payment_type", "=", "outbound")], limit=1
+        )
+        cls.outbound_payment_method_line = cls.env[
+            "account.payment.method.line"
+        ].create(
+            {
+                "name": "SF Outbound Payment Method",
+                "payment_method_id": cls.outbound_manual_method.id,
+                "payment_type": "outbound",
+                "journal_id": cls.bank_journal.id,
+                "payment_account_id": cls.market_account.id,
             }
         )
         cls.sf_store = cls.env["shoppingfeed.store"].create(
@@ -52,6 +70,26 @@ def _sf_order_line(cls, product=None):
             }
         )
 
+    def _sf_refund(self, sale_order, product=None):
+        product = product or self.product_a
+        return self.env["account.move"].create(
+            {
+                "move_type": "out_refund",
+                "partner_id": sale_order.partner_id.id,
+                "invoice_origin": sale_order.name,
+                "invoice_line_ids": [
+                    Command.create(
+                        {
+                            "product_id": product.id,
+                            "quantity": 1.0,
+                            "price_unit": product.list_price,
+                            "sale_line_ids": [Command.set(sale_order.order_line.ids)],
+                        }
+                    )
+                ],
+            }
+        )
+
     def test_partner_gets_payment_method_on_create(self):
         """New partner created during SF import receives
         property_inbound_payment_method_line_id from the channel."""
@@ -158,6 +196,38 @@ def test_invoice_not_auto_paid_when_disabled(self):
         self.assertNotEqual(invoice.payment_state, "paid")
         self.sf_channel.auto_pay = True
 
+    def test_refund_auto_paid_on_channel_account(self):
+        self.partner_a.property_inbound_payment_method_line_id = (
+            self.inbound_payment_method_line
+        )
+        sale_order = self.env["sale.order"].create(
+            {
+                "partner_id": self.partner_a.id,
+                "shoppingfeed_order_ref": "SF-TEST-REFUND-001",
+                "shoppingfeed_store_id": self.sf_store.id,
+                "shoppingfeed_channel_id": self.sf_channel.id,
+                "order_line": [self._sf_order_line()],
+            }
+        )
+        sale_order.action_confirm()
+        self.sf_channel.auto_pay = False
+        unpaid = self._sf_refund(sale_order)
+        unpaid.action_post()
+        self.assertNotEqual(unpaid.payment_state, "paid")
+        self.sf_channel.auto_pay = True
+        refund = self._sf_refund(sale_order)
+        refund.action_post()
+        self.assertEqual(refund.payment_state, "paid")
+        payment = refund.reconciled_payment_ids
+        self.assertEqual(len(payment), 1)
+        self.assertEqual(payment.payment_type, "outbound")
+        self.assertEqual(
+            payment.payment_method_line_id, self.outbound_payment_method_line
+        )
+        self.assertEqual(
+            payment.payment_method_line_id.payment_account_id, self.market_account
+        )
+
     def test_product_reference_cleaning(self):
         """_shoppingfeed_clean_product_reference strips 2-char country suffixes only."""
         so = self.env["sale.order"]