[MIG] stock_move_location: Migration to 19.0

Author: dreispt

stock_move_location/README.rst

@@ -21,13 +21,13 @@ Move Stock Location
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fstock--logistics--warehouse-lightgray.png?logo=github
-    :target: https://github.com/OCA/stock-logistics-warehouse/tree/18.0/stock_move_location
+    :target: https://github.com/OCA/stock-logistics-warehouse/tree/19.0/stock_move_location
     :alt: OCA/stock-logistics-warehouse
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/stock-logistics-warehouse-18-0/stock-logistics-warehouse-18-0-stock_move_location
+    :target: https://translation.odoo-community.org/projects/stock-logistics-warehouse-19-0/stock-logistics-warehouse-19-0-stock_move_location
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/stock-logistics-warehouse&target_branch=18.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/stock-logistics-warehouse&target_branch=19.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -43,25 +43,26 @@ another and move only selected quantities.
 Usage
 =====
 
-- A new menu item Operations > Move from location... opens a wizard
-  where 2 locations can be specified.
-- Select origin and destination locations and press "IMMEDIATE TRANSFER"
-  or "PLANNED TRANSFER"
-- Those lines can be edited. Move quantity can't be more than a max
-  available quantity
-- Move doesn't care about the reservations and will move stuff anyway
-- If during your operation with the wizard the real quantity will change
-  it will move only the available quantity at the button press
-- Products will be moved and a form view of picking that did that will
-  show up
-- If "PLANNED TRANSFER" is used - the picking won't be validated
-  automatically
+-  A new menu item Operations > Move from location... opens a wizard
+   where 2 locations can be specified.
+-  Select origin and destination locations and press "IMMEDIATE
+   TRANSFER" or "PLANNED TRANSFER"
+-  Those lines can be edited. Move quantity can't be more than a max
+   available quantity
+-  Move doesn't care about the reservations and will move stuff anyway
+-  If during your operation with the wizard the real quantity will
+   change it will move only the available quantity at the button press
+-  Products will be moved and a form view of picking that did that will
+   show up
+-  If "PLANNED TRANSFER" is used - the picking won't be validated
+   automatically
 
 If you want to transfer a full quant:
 
-- Go to Inventory > Products > Products and click "On hand" smart button
-  or Inventory > Reporting > Inventory, the quants view will be opened.
-- Select the quantities which you want move to another location
+-  Go to Inventory > Products > Products and click "On hand" smart
+   button or Inventory > Reporting > Inventory, the quants view will be
+   opened.
+-  Select the quantities which you want move to another location
 
 If you go to the Inventory Dashboard you can see the button "Move from
 location" in each of the picking types (only applicable to internal and
@@ -94,28 +95,29 @@ Known issues / Roadmap
 Change the current implementation (suggested by Denis Roussel from
 ACSONE):
 
-- A new parameter on stock picking types : 'Product Change Location'
-  (with a little help).
-- With this, go to the dashboard, create a picking with that type.
-- Add a button on the picking form which is visible with that type that
-  fill in the picking as now
-- Nice to have: add a magic button on locations that with context
-  creates a new picking of that type with the origin location already
-  filled in.
+-  A new parameter on stock picking types : 'Product Change Location'
+   (with a little help).
+-  With this, go to the dashboard, create a picking with that type.
+-  Add a button on the picking form which is visible with that type that
+   fill in the picking as now
+-  Nice to have: add a magic button on locations that with context
+   creates a new picking of that type with the origin location already
+   filled in.
 
 Note from Jacques-Etienne Baudoux (BCIM)
 
-- The fill with stock action on stock.picking should not create manually
-  the move lines but instead call ``action_assign()``. There are many
-  modules hooking ``action_assign`` that are not called due to this.
+-  The fill with stock action on stock.picking should not create
+   manually the move lines but instead call ``action_assign()``. There
+   are many modules hooking ``action_assign`` that are not called due to
+   this.
 
 Bug Tracker
 ===========
 
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/stock-logistics-warehouse/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/stock-logistics-warehouse/issues/new?body=module:%20stock_move_location%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/stock-logistics-warehouse/issues/new?body=module:%20stock_move_location%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -132,28 +134,31 @@ Authors
 Contributors
 ------------
 
-- Mathieu Vatel <mathieu@julius.fr>
-- Mykhailo Panarin <m.panarin@mobilunity.com>
-- Joan Sisquella <joan.sisquella@forgeflow.com>
-- Jordi Ballester Alomar <jordi.ballester@forgeflow.com>
-- Lois Rilo <lois.rilo@forgeflow.com>
-- Héctor Villarreal <hector.villarreal@forgeflow.com>
-- Tecnativa <tecnativa.com>
+-  Mathieu Vatel <mathieu@julius.fr>
+-  Mykhailo Panarin <m.panarin@mobilunity.com>
+-  Joan Sisquella <joan.sisquella@forgeflow.com>
+-  Jordi Ballester Alomar <jordi.ballester@forgeflow.com>
+-  Lois Rilo <lois.rilo@forgeflow.com>
+-  Héctor Villarreal <hector.villarreal@forgeflow.com>
+-  Tecnativa <tecnativa.com>
 
-  - Sergio Teruel
-  - João Marques
-  - Carlos Roca
+   -  Sergio Teruel
+   -  João Marques
+   -  Carlos Roca
 
-- Jacques-Etienne Baudoux <je@bcim.be>
-- Iryna Vyshnevska <i.vyshnevska@mobilunity.com>
-- Alexei Rivera <arivera@archeti.com>
-- Abraham Anes <abraham@studio73.es>
-- Quartile <https://www.quartile.co>
+-  Jacques-Etienne Baudoux <je@bcim.be>
+-  Iryna Vyshnevska <i.vyshnevska@mobilunity.com>
+-  Alexei Rivera <arivera@archeti.com>
+-  Abraham Anes <abraham@studio73.es>
+-  Quartile <https://www.quartile.co>
 
-  - Aung Ko Ko Lin
+   -  Aung Ko Ko Lin
 
-- Laurent Mignon <laurent.mignon@acsone.eu>
-- Maksym Yankin <maksym.yankin@camptocamp.com>
+-  Laurent Mignon <laurent.mignon@acsone.eu>
+-  Maksym Yankin <maksym.yankin@camptocamp.com>
+-  Open Source Integrators <https://www.opensourceintegrators.com>
+
+   -  Daniel Reis <dreis@opensourceintegrators.com>
 
 Maintainers
 -----------
@@ -168,6 +173,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/stock-logistics-warehouse <https://github.com/OCA/stock-logistics-warehouse/tree/18.0/stock_move_location>`_ project on GitHub.
+This module is part of the `OCA/stock-logistics-warehouse <https://github.com/OCA/stock-logistics-warehouse/tree/19.0/stock_move_location>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

stock_move_location/__manifest__.py

@@ -5,7 +5,7 @@
 
 {
     "name": "Move Stock Location",
-    "version": "18.0.1.0.1",
+    "version": "19.0.1.0.0",
     "author": "Julius Network Solutions, "
     "BCIM,"
     "Camptocamp,"

stock_move_location/data/stock_quant_view.xml

@@ -8,6 +8,6 @@
         <field name="view_mode">form</field>
         <field name="context" eval="{'origin_location_disable': True}" />
         <field name="target">new</field>
-        <field name="groups_id" eval="[(4, ref('stock.group_stock_user'))]" />
+        <field name="group_ids" eval="[(4, ref('stock.group_stock_user'))]" />
     </record>
 </odoo>

stock_move_location/models/stock_picking.py

@@ -2,7 +2,7 @@
 # Copyright Iryna Vyshnevska 2020 Camptocamp
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl)
 
-from odoo import _, models
+from odoo import models
 from odoo.exceptions import UserError
 
 
@@ -38,9 +38,9 @@ def button_fillwithstock(self):
 
     def _validate_picking(self):
         if self.location_id.child_ids:
-            raise UserError(_("Please choose a source end location"))
+            raise UserError(self.env._("Please choose a source end location"))
         if self.move_ids:
-            raise UserError(_("Moves lines already exists"))
+            raise UserError(self.env._("Moves lines already exists"))
 
     def _get_movable_quants(self):
         return (

stock_move_location/readme/CONTRIBUTORS.md

@@ -16,3 +16,5 @@
   - Aung Ko Ko Lin
 - Laurent Mignon \<<laurent.mignon@acsone.eu>\>
 - Maksym Yankin \<<maksym.yankin@camptocamp.com>\>
+- Open Source Integrators \<<https://www.opensourceintegrators.com>\>
+  - Daniel Reis <<dreis@opensourceintegrators.com>>

stock_move_location/static/description/index.html

@@ -374,7 +374,7 @@ <h1>Move Stock Location</h1>
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:792445e5024062bee785b19642189b2500b863643ed32db16d168d433c7dc7fd
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/stock-logistics-warehouse/tree/18.0/stock_move_location"><img alt="OCA/stock-logistics-warehouse" src="https://img.shields.io/badge/github-OCA%2Fstock--logistics--warehouse-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/stock-logistics-warehouse-18-0/stock-logistics-warehouse-18-0-stock_move_location"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/stock-logistics-warehouse&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/stock-logistics-warehouse/tree/19.0/stock_move_location"><img alt="OCA/stock-logistics-warehouse" src="https://img.shields.io/badge/github-OCA%2Fstock--logistics--warehouse-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/stock-logistics-warehouse-19-0/stock-logistics-warehouse-19-0-stock_move_location"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/stock-logistics-warehouse&amp;target_branch=19.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>This module allows to move entire location of products from one place to
 another and move only selected quantities.</p>
 <p><strong>Table of contents</strong></p>
@@ -396,22 +396,23 @@ <h2><a class="toc-backref" href="#toc-entry-1">Usage</a></h2>
 <ul class="simple">
 <li>A new menu item Operations &gt; Move from location… opens a wizard
 where 2 locations can be specified.</li>
-<li>Select origin and destination locations and press “IMMEDIATE TRANSFER”
-or “PLANNED TRANSFER”</li>
+<li>Select origin and destination locations and press “IMMEDIATE
+TRANSFER” or “PLANNED TRANSFER”</li>
 <li>Those lines can be edited. Move quantity can’t be more than a max
 available quantity</li>
 <li>Move doesn’t care about the reservations and will move stuff anyway</li>
-<li>If during your operation with the wizard the real quantity will change
-it will move only the available quantity at the button press</li>
+<li>If during your operation with the wizard the real quantity will
+change it will move only the available quantity at the button press</li>
 <li>Products will be moved and a form view of picking that did that will
 show up</li>
 <li>If “PLANNED TRANSFER” is used - the picking won’t be validated
 automatically</li>
 </ul>
 <p>If you want to transfer a full quant:</p>
 <ul class="simple">
-<li>Go to Inventory &gt; Products &gt; Products and click “On hand” smart button
-or Inventory &gt; Reporting &gt; Inventory, the quants view will be opened.</li>
+<li>Go to Inventory &gt; Products &gt; Products and click “On hand” smart
+button or Inventory &gt; Reporting &gt; Inventory, the quants view will be
+opened.</li>
 <li>Select the quantities which you want move to another location</li>
 </ul>
 <p>If you go to the Inventory Dashboard you can see the button “Move from
@@ -447,17 +448,18 @@ <h2><a class="toc-backref" href="#toc-entry-2">Known issues / Roadmap</a></h2>
 </ul>
 <p>Note from Jacques-Etienne Baudoux (BCIM)</p>
 <ul class="simple">
-<li>The fill with stock action on stock.picking should not create manually
-the move lines but instead call <tt class="docutils literal">action_assign()</tt>. There are many
-modules hooking <tt class="docutils literal">action_assign</tt> that are not called due to this.</li>
+<li>The fill with stock action on stock.picking should not create
+manually the move lines but instead call <tt class="docutils literal">action_assign()</tt>. There
+are many modules hooking <tt class="docutils literal">action_assign</tt> that are not called due to
+this.</li>
 </ul>
 </div>
 <div class="section" id="bug-tracker">
 <h2><a class="toc-backref" href="#toc-entry-3">Bug Tracker</a></h2>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/stock-logistics-warehouse/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/stock-logistics-warehouse/issues/new?body=module:%20stock_move_location%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/stock-logistics-warehouse/issues/new?body=module:%20stock_move_location%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -495,6 +497,10 @@ <h3><a class="toc-backref" href="#toc-entry-6">Contributors</a></h3>
 </li>
 <li>Laurent Mignon &lt;<a class="reference external" href="mailto:laurent.mignon&#64;acsone.eu">laurent.mignon&#64;acsone.eu</a>&gt;</li>
 <li>Maksym Yankin &lt;<a class="reference external" href="mailto:maksym.yankin&#64;camptocamp.com">maksym.yankin&#64;camptocamp.com</a>&gt;</li>
+<li>Open Source Integrators &lt;<a class="reference external" href="https://www.opensourceintegrators.com">https://www.opensourceintegrators.com</a>&gt;<ul>
+<li>Daniel Reis &lt;<a class="reference external" href="mailto:dreis&#64;opensourceintegrators.com">dreis&#64;opensourceintegrators.com</a>&gt;</li>
+</ul>
+</li>
 </ul>
 </div>
 <div class="section" id="maintainers">
@@ -506,7 +512,7 @@ <h3><a class="toc-backref" href="#toc-entry-7">Maintainers</a></h3>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/stock-logistics-warehouse/tree/18.0/stock_move_location">OCA/stock-logistics-warehouse</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/stock-logistics-warehouse/tree/19.0/stock_move_location">OCA/stock-logistics-warehouse</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>

stock_move_location/tests/test_common.py

@@ -10,12 +10,14 @@ class TestsCommon(BaseCommon):
     @classmethod
     def setUpClass(cls):
         super().setUpClass()
+        # Disable tracking for tests as recommended in Odoo 19.0 migration guide
+        cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True))
         cls.location_obj = cls.env["stock.location"]
         cls.product_obj = cls.env["product.product"]
         cls.wizard_obj = cls.env["wiz.stock.move.location"]
         cls.quant_obj = cls.env["stock.quant"]
         cls.company = cls.env.ref("base.main_company")
-        cls.partner = cls.env.ref("base.res_partner_category_0")
+        cls.partner = cls.env["res.partner"].create({"name": "Test Partner"})
 
         cls.internal_loc_1 = cls.location_obj.create(
             {
@@ -90,10 +92,10 @@ def setUpClass(cls):
                 "company_id": cls.company.id,
             }
         )
-        cls.package = cls.env["stock.quant.package"].create({})
-        cls.package1 = cls.env["stock.quant.package"].create({})
+        cls.package = cls.env["stock.package"].create({})
+        cls.package1 = cls.env["stock.package"].create({})
 
-        cls.package2 = cls.env["stock.quant.package"].create({})
+        cls.package2 = cls.env["stock.package"].create({})
 
     @classmethod
     def setup_product_amounts(cls):

stock_move_location/tests/test_move_location.py

@@ -283,8 +283,8 @@ def test_delivery_order_assignation_after_transfer(self):
         """
         delivery_order_type = self.env.ref("stock.picking_type_out")
         internal_transfer_type = self.env.ref("stock.picking_type_internal")
-        wh_stock_shelf_1 = self.env.ref("stock.stock_location_components")
-        wh_stock_shelf_2 = self.env.ref("stock.stock_location_14")
+        wh_stock_shelf_1 = self.env.ref("stock.stock_location_stock")
+        wh_stock_shelf_2 = wh_stock_shelf_1.copy({"name": "Shelf 2"})
         wh_stock_shelf_3 = wh_stock_shelf_1.copy({"name": "Shelf 3"})
 
         # Create some quants
@@ -297,7 +297,6 @@ def test_delivery_order_assignation_after_transfer(self):
         # delivery_picking.location_id = wh_stock_shelf_1
         delivery_move = self.env["stock.move"].create(
             {
-                "name": "Delivery move",
                 "product_id": self.product_lots.id,
                 "product_uom_qty": 20.0,
                 "product_uom": self.product_lots.uom_id.id,