[FIX] stock_move_zone_location_source: Zone should come from move lines

As Odoo does not reflect the leaf location from where the product
is eventually taken from on the stock move level, take the zone location source
from the move line.

Author: rousseldenis

stock_move_zone_location_source/models/stock_move.py

@@ -20,7 +20,7 @@ def _find_source_zone_location_move(self, visited=None):
         # that is considered as the the source one
         # WARNING: The first call should be done with a single recordset
         all_moves = self.filtered(
-            "location_id.zone_location_id.is_considered_as_source"
+            "move_line_ids.location_id.zone_location_id.is_considered_as_source"
         )
         unvisited_moves = (self - visited) if visited else self
         for move in unvisited_moves:
@@ -30,6 +30,7 @@ def _find_source_zone_location_move(self, visited=None):
     @api.depends("move_orig_ids")
     def _compute_source_zone_location_ids(self):
         for move in self:
+            source_move = move._find_source_zone_location_move()
             move.source_zone_location_ids = (
-                move._find_source_zone_location_move().location_id.zone_location_id
+                source_move.move_line_ids.location_id.zone_location_id
             )

stock_move_zone_location_source/tests/common.py

@@ -22,14 +22,21 @@ def setUpClass(cls):
 
         #                                  WH (view)
         #
-        #   FOOD(view/zone/source)     STOCK (zone/source)   PHARMA(view/zone/source)
+        #                                    STOCK
+        #
+        #
+        #   FOOD(view/zone/source)                          PHARMA(view/zone/source)
         #
         #            FOOD 1                                           PHARMA 1
 
         # Set delivery in three steps in order to check
         # the good origin
         cls.warehouse.delivery_steps = "pick_pack_ship"
 
+        # Set Stock location as source too (for products that do not come from sub zones)
+        cls.warehouse.lot_stock_id.is_zone = True
+        cls.warehouse.lot_stock_id.is_considered_as_source = True
+
         # Create several picking zones (e.g.: Pharmaceutical, Food)
         cls.pharma_location = cls.Location.create(
             {
@@ -73,9 +80,7 @@ def setUpClass(cls):
                 "location_id": cls.food_location.id,
             }
         )
-        # Set stock as source too
-        cls.warehouse.lot_stock_id.is_zone = True
-        cls.warehouse.lot_stock_id.is_considered_as_source = True
+
         cls.food_type = cls.PickingType.create(
             {
                 "name": "Picking Food",
@@ -128,7 +133,7 @@ def setUpClass(cls):
                 "name": "Pharma > Pack",
                 "location_dest_id": cls.warehouse.wh_pack_stock_loc_id.id,
                 "procure_method": "make_to_stock",
-                "location_src_id": cls.pharma_location.id,
+                "location_src_id": cls.warehouse.lot_stock_id.id,
                 "action": "pull",
                 "route_id": cls.pharma_route.id,
                 "picking_type_id": cls.pharma_type.id,
@@ -140,7 +145,7 @@ def setUpClass(cls):
                 "name": "Food > Pack",
                 "location_dest_id": cls.warehouse.wh_pack_stock_loc_id.id,
                 "procure_method": "make_to_stock",
-                "location_src_id": cls.food_location.id,
+                "location_src_id": cls.warehouse.lot_stock_id.id,
                 "action": "pull",
                 "route_id": cls.food_route.id,
                 "picking_type_id": cls.food_type.id,