Fix bug #1071 (cobc crashes wen replacing by nothing)

Author: lefessan

cobc/ChangeLog

@@ -1,4 +1,9 @@
 
+2026-08-26 Fabrice Le Fessant <fabrice.le_fessant@ocamlpro.com>
+
+	* ppparse.y (ppp_replace_list_add): fix bug #1071
+	  "cobc crashes when replacing by nothing"
+
 2026-08-23 Fabrice Le Fessant <fabrice.le_fessant@ocamlpro.com>
 
 	* ppparse.y (ppp_replace_list_add): trim spaces before

cobc/ppparse.y

@@ -189,7 +189,8 @@ ppp_replace_list_add (struct cb_replace_list *list,
 		/* Strictness flag is irrelevant for non-LEADING nor TRAILING
 		   replacements */
 		src->strict = 0;
-	} else {
+	}
+	if (lead_or_trail && new_text != NULL) {
 		/* Use replacement text to decide strictness of partial match */
 		const unsigned char *c;
 		int has_space = new_text->next != NULL;

tests/testsuite.src/syn_misc.at

@@ -3383,43 +3383,107 @@ LINE    PG/LN  A...B............................................................
 AT_CLEANUP
 
 
-AT_SETUP([missing periods])
-AT_KEYWORDS([misc cobol85 area-a missing-periods])
 
-# Check whether the first line is correcly handled:
-AT_DATA([prog.cob], [       IDENTIFICATION   DIVISION.
+
+AT_SETUP([pseudotext replacement trim spaces])
+AT_KEYWORDS([misc copy replace])
+
+# Note: we show the output in listing mode, which is wrong (see
+# comment in #831), since no replacement happens at all. We keep
+# advising devs to checkout the .i file generated by -g instead of
+# listings to check which replacements are really done by the compiler
+
+AT_DATA([ok.inc], [
+       01  VARIABLE1 PIC X(01) VALUE "O1".
+       01  VARI(03)ABLE2 PIC X(02) VALUE "O2".
+       01  VARIABLE3 PIC X(04) VALUE "O3".
+       01  VARI(05)ABLE4 PIC X(02) VALUE "O4".
+])
+AT_DATA([prog.cob], [
+       IDENTIFICATION   DIVISION.
        PROGRAM-ID.      prog.
 
        DATA DIVISION.
        WORKING-STORAGE SECTION.
-       01 DONE COMP-1 VALUE ZERO.
-
+           REPLACE == (04) == BY == (02) ==
+	           == (05) == BY == ==.
+           COPY "ok.inc" REPLACING == (01) == BY == (02) ==
+	                           == (03) == BY == ==.
        PROCEDURE DIVISION.
        MAIN SECTION.
-           PERFORM SEC-1.
-           IF NOT DONE = 1
-              DISPLAY "SEC-1 NOT EXECUTED"
-           END-IF
-           STOP RUN
-       SEC-1 SECTION.
-           MOVE 1 TO DONE
-           GOBACK.
+           DISPLAY VARIABLE1 VARIABLE2 VARIABLE3 VARIABLE4.
+	   GOBACK.
 ])
 
-AT_CHECK([$COMPILE_ONLY prog.cob], [1], [],
-[prog.cob: in section 'MAIN':
-prog.cob:15: error: 'SEC-1' is not defined
-prog.cob:15: error: syntax error, unexpected SECTION
+AT_CHECK([SOURCE_DATE_EPOCH=1011960000 $COMPILE -g -Wall -t prog.lst prog.cob])
+
+AT_CHECK([$COBCRUN_DIRECT ./prog], [0], [O1O2O3O4
 ])
-AT_CHECK([$COMPILE_ONLY -fformat=cobol85 -fmissing-period=error prog.cob], [1], [],
-[prog.cob: in section 'MAIN':
-prog.cob:15: error: optional period used
+
+AT_CHECK([cat prog.lst], [0],
+[GnuCOBOL 3.3-dev.0      prog.cob             Fri Jan 25 2002 12:00:00  Page 0001
+
+LINE    PG/LN  A...B............................................................
+
+000001
+000002         IDENTIFICATION   DIVISION.
+000003         PROGRAM-ID.      prog.
+000004
+000005         DATA DIVISION.
+000006         WORKING-STORAGE SECTION.
+000007             REPLACE == (04) == BY == (02) ==
+000008                     == (05) == BY == ==.
+000009             COPY "ok.inc" REPLACING == (01) == BY == (02) ==
+000001C
+000002C        01  VARIABLE1 PIC X(01) VALUE "O1".
+000003C        01  VARI(03)ABLE2 PIC X(02) VALUE "O2".
+000004C        01  VARIABLE3 PIC X(04) VALUE "O3".
+000005C        01  VARI(05)ABLE4 PIC X(02) VALUE "O4".
+000009                                     == (03) == BY == ==.
+000010         PROCEDURE DIVISION.
+000011         MAIN SECTION.
+000012             DISPLAY VARIABLE1 VARIABLE2 VARIABLE3 VARIABLE4.
+000013             GOBACK.
+
+
+0 warnings in compilation group
+0 errors in compilation group
 ])
-AT_CHECK([$COMPILE -fformat=cobol85 prog.cob], [0], [],
-[prog.cob: in section 'MAIN':
-prog.cob:15: warning: optional period used
+
+AT_CLEANUP
+
+
+AT_SETUP([bug 1071 with empty replaced text])
+AT_KEYWORDS([copy replacing trailing])
+
+AT_DATA([prog.cob], [>>SOURCE FREE
+IDENTIFICATION DIVISION.
+PROGRAM-ID. HELLO.
+
+DATA DIVISION.
+   WORKING-STORAGE SECTION.
+   01 result PIC 9(4).
+
+PROCEDURE DIVISION.
+   COPY fab.
+   DISPLAY "The result is " result.
+STOP RUN.
+])
+AT_DATA([fab.cob], [>>SOURCE IS FREE
+>>DEFINE 1aa AS 2
+ADD 1 to result.
+>>IF 1aa > 1
+COPY fob REPLACING TRAILING ==a== BY ====.
+>>END-IF
+])
+AT_DATA([fob.cob], [DISPLAY resulta.
+])
+
+AT_CHECK([$COMPILE --free prog.cob])
+
+AT_CHECK([$COBCRUN_DIRECT ./prog], [0], [0001
+The result is 0001
 ])
-AT_CHECK([$COBCRUN_DIRECT ./prog], [0], [], [])
 
 AT_CLEANUP