Throw exception if the function call without providing the parameter … (#2306)

* Throw exception if the function call without providing the parameter value

* Make the ASP.NET Classic test pass

Author: xuzhg

src/Microsoft.AspNet.OData.Shared/Common/SRResources.Designer.cs

@@ -222,6 +222,9 @@
   <data name="CannotRecognizeNodeType" xml:space="preserve">
     <value>'{0}' does not recognize the node with type '{1}'.</value>
   </data>
+  <data name="MissingConvertNode" xml:space="preserve">
+    <value>Missing the value of the parameter '{0}' in the function '{1}' calling.</value>
+  </data>
   <data name="TargetKindNotImplemented" xml:space="preserve">
     <value>'{0}' of kind '{1}' is not implemented.</value>
   </data>

src/Microsoft.AspNet.OData.Shared/Common/SRResources.resx

@@ -157,7 +157,8 @@ public override void Handle(OperationImportSegment segment)
         {
             _navigationSource = segment.EntitySet;
 
-            IEdmActionImport actionImport = segment.OperationImports.Single() as IEdmActionImport;
+            IEdmOperationImport operationImport = segment.OperationImports.Single();
+            IEdmActionImport actionImport = operationImport as IEdmActionImport;
 
             if (actionImport != null)
             {
@@ -166,14 +167,14 @@ public override void Handle(OperationImportSegment segment)
             }
             else
             {
+                IEdmFunctionImport function = (IEdmFunctionImport)operationImport;
+
                 _pathTemplate.Add(ODataSegmentKinds.UnboundFunction); // unbound function
 
                 // Translate the nodes in ODL path to string literals as parameter of UnboundFunctionPathSegment.
                 Dictionary<string, string> parameterValues = segment.Parameters.ToDictionary(
                     parameterValue => parameterValue.Name,
-                    parameterValue => TranslateNode(parameterValue.Value));
-
-                 IEdmFunctionImport function = (IEdmFunctionImport)segment.OperationImports.Single();
+                    parameterValue => TranslateNode(parameterValue.Value, function.Name, parameterValue.Name));
 
                  IEnumerable<string> parameters = parameterValues.Select(v => String.Format(CultureInfo.InvariantCulture, "{0}={1}", v.Key, v.Value));
                  string literal = String.Format(CultureInfo.InvariantCulture, "{0}({1})", function.Name, String.Join(",", parameters));
@@ -190,7 +191,8 @@ public override void Handle(OperationSegment segment)
         {
             _navigationSource = segment.EntitySet;
 
-            IEdmAction action = segment.Operations.Single() as IEdmAction;
+            IEdmOperation edmOperation = segment.Operations.Single();
+            IEdmAction action = edmOperation as IEdmAction;
 
             if (action != null)
             {
@@ -199,16 +201,15 @@ public override void Handle(OperationSegment segment)
             }
             else
             {
+                IEdmFunction function = (IEdmFunction)edmOperation;
                 _pathTemplate.Add(ODataSegmentKinds.Function); // function
 
                 // Translate the nodes in ODL path to string literals as parameter of BoundFunctionPathSegment.
                 Dictionary<string, string> parameterValues = segment.Parameters.ToDictionary(
                     parameterValue => parameterValue.Name,
-                    parameterValue => TranslateNode(parameterValue.Value));
+                    parameterValue => TranslateNode(parameterValue.Value, function.Name, parameterValue.Name));
 
                 // TODO: refactor the function literal for parameter alias
-                IEdmFunction function = (IEdmFunction)segment.Operations.Single();
-
                 IEnumerable<string> parameters = parameterValues.Select(v => String.Format(CultureInfo.InvariantCulture, "{0}={1}", v.Key, v.Value));
                 string literal = String.Format(CultureInfo.InvariantCulture, "{0}({1})", function.FullName(), String.Join(",", parameters));
 
@@ -414,9 +415,17 @@ private static string TranslateKeySegmentValue(object value)
             return ODataUriUtils.ConvertToUriLiteral(value, ODataVersion.V4);
         }
 
-        private static string TranslateNode(object node)
+        private static string TranslateNode(object node, string functionName, string parameterName)
         {
-            Contract.Assert(node != null);
+            // If the function parameter is null, for example myFunction(param=null),
+            // the input node here is not null, it is a contant node with a value as "null".
+            // However, if a function call (or key) using parameter alias but without providing the parameter alias value,
+            // the input node here is a null.
+            if (node == null)
+            {
+                // We can't throw ODataException here because ODataException will be caught and return 404 response with empty message.
+                throw new InvalidOperationException(Error.Format(SRResources.MissingConvertNode, parameterName, functionName));
+            }
 
             ConstantNode constantNode = node as ConstantNode;
             if (constantNode != null)
@@ -440,7 +449,7 @@ private static string TranslateNode(object node)
             ConvertNode convertNode = node as ConvertNode;
             if (convertNode != null)
             {
-                return TranslateNode(convertNode.Source);
+                return TranslateNode(convertNode.Source, functionName, parameterName);
             }
 
             ParameterAliasNode parameterAliasNode = node as ParameterAliasNode;

src/Microsoft.AspNet.OData.Shared/Routing/ODataPathSegmentHandler.cs

@@ -205,6 +205,47 @@ public async Task FunctionWorks_WithParameters_OnlyWithAttributeRouting_ForUnTyp
             Assert.True((bool)result["value"]);
         }
 
+        [Fact]
+        public void FunctionCallingFails_WithParametersValueMissing()
+        {
+            // Arrange
+            string complexFunction = "ComplexFunction(address=@p)";
+            string requestUri = BaseAddress + "odata/FCustomers(2)/NS." + complexFunction;
+
+#if NETCORE
+            // Act
+            AggregateException exception = Assert.Throws<AggregateException>(() => _client.GetAsync(requestUri).Result);
+
+            // Assert
+            Assert.Contains("Missing the value of the parameter 'address' in the function 'ComplexFunction' calling", exception.Message);
+#else
+            // Act
+            var response = _client.GetAsync(requestUri).Result;
+
+            // Assert
+            Assert.Equal(System.Net.HttpStatusCode.InternalServerError, response.StatusCode);
+
+            string result = response.Content.ReadAsStringAsync().Result;
+            Assert.Contains("Missing the value of the parameter 'address' in the function 'ComplexFunction' calling", result);
+#endif
+        }
+
+        [Fact]
+        public async Task FunctionCallingSuccess_WithParametersValueAsNull()
+        {
+            // Arrange
+            string complexFunction = "ComplexFunction(address=null)";
+            string requestUri = BaseAddress + "odata/FCustomers(99)/NS." + complexFunction;
+
+            // Act
+            var response = await _client.GetAsync(requestUri);
+
+            // Assert
+            ExceptionAssert.DoesNotThrow(() => response.EnsureSuccessStatusCode());
+            dynamic result = JObject.Parse(await response.Content.ReadAsStringAsync());
+            Assert.False((bool)result["value"]);
+        }
+
         [Fact]
         public async Task Response_Includes_FunctionLinkForFeed_WithAcceptHeader()
         {
@@ -265,7 +306,7 @@ private static IEdmModel GetUnTypedEdmModel()
             model.AddElement(container);
             container.AddEntitySet("FCustomers", customer);
 
-            EdmComplexTypeReference complexType = new EdmComplexTypeReference(address, isNullable: false);
+            EdmComplexTypeReference complexType = new EdmComplexTypeReference(address, isNullable: true);
             EdmCollectionTypeReference complexCollectionType = new EdmCollectionTypeReference(new EdmCollectionType(complexType));
 
             EdmEnumTypeReference enumType = new EdmEnumTypeReference(colorEnum, isNullable: false);
@@ -422,6 +463,12 @@ public bool EnumCollectionFunction(int key, [FromODataUri] EdmEnumObjectCollecti
         [ODataRoute("UnboundComplexFunction(key={key},address={address})")]
         public bool ComplexFunction(int key, [FromODataUri] EdmComplexObject address)
         {
+            if (key == 99)
+            {
+                Assert.Null(address);
+                return false;
+            }
+
             Assert.NotNull(address);
             dynamic result = address;
             Assert.Equal("NS.Address", address.GetEdmType().FullName());