Skip to content

[Bug] Documentation for dynamic loading of app-config.js needs clarification #5708

@seandoyle

Description

@seandoyle

Describe the Bug

In the documentation for deploying OHIF in a docker it claims that the location for mounting the configuration file is /usr/share/nginx/html/app-config.js . However - if the recipe used is the Nginx-Orthanc one then the location of the file should be /var/www/html/app-config.js because the nginx.conf file sets the root to be /var/www/html.

So - an addition to the documentation might include a note saying that the file needs to be mounted in the directory of the root as defined by nginx.conf.

There might need to be an additional change to the entrypoint.sh code for overwriting the app-config.js file from the APP_CONFIG environment variable.

Steps to Reproduce

  1. Use the Nginx-Orthanc recipe.
  2. Create a app-config.js file different than the one used by webpack in the yarn build phase.
  3. In docker or docker compose specify the location as /usr/share/nginx/html/app-config.js. Nothing changes in OHIF behavior.
  4. Now set the location as /var/www/html/app-config.js - the new configurations work just fine.

The current behavior

With the current location specified by the documentation the new configuration is ignored and the configuration specified during yarn build is used instead.

The expected behavior

The expected behavior is that the runtime configuration file should be used.

System Information

System:
OS: macOS 26.1
CPU: (10) arm64 Apple M1 Max
Memory: 265.30 MB / 32.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 20.14.0 - ~/.nvm/versions/node/v20.14.0/bin/node
Yarn: 1.22.22 - /opt/homebrew/bin/yarn
npm: 10.7.0 - ~/.nvm/versions/node/v20.14.0/bin/npm
Browsers:
Chrome: 143.0.7499.193
Edge: 143.0.3650.139
Safari: 26.1

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions