fix: Remove hardcoded 512MB replay buffer size limit and add memory estimate UI

hanatyan128 · claude · hanatyan128 · commit 442e1fadddc5 · 2026-03-29T15:53:40.000+09:00
The replay buffer max_size_mb was hardcoded to 512MB, which limited actual
buffer duration (e.g., ~7 min at 10Mbps instead of the configured 30 min).
Changed to 0 (disabled) to match OBS Studio's behavior of using only
max_time_sec for buffer control.

Also added a "Show estimated memory usage" checkbox in the replay buffer
settings that calculates and displays the estimated memory based on the
current video/audio bitrate and duration.

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/data/locale/ca-ES.ini b/data/locale/ca-ES.ini
@@ -169,6 +169,10 @@ VideoSourceType.Source="Mescla independent (Per defecte)"
 VideoSourceType.FilterInput="Entrada de filtre (Experimental)"
 ReplayBuffer="Replay Buffer"
 ReplayBufferDuration="Maximum Replay Time (seconds)"
+ReplayBufferEstimate="Estimated memory usage: ~%d MB"
+ReplayBufferEstimateUnknown="Estimated memory usage: Unknown"
+ReplayBufferEstimate.Show="Show estimated memory usage"
+ReplayBufferEstimate.ToolTip="Re-check or apply settings to refresh the estimate."
 Status.ReplayBuffer="Buffering"
 SaveReplayBufferHotkey="Save '%1' Replay Buffer"
 SaveReplayBufferAllHotkey="Save all Branch Output replay buffers"
diff --git a/data/locale/de-DE.ini b/data/locale/de-DE.ini
@@ -169,6 +169,10 @@ VideoSourceType.Source="Unabhängiger Mix (Standard)"
 VideoSourceType.FilterInput="Filtereingabe (Experimentell)"
 ReplayBuffer="Wiederholungspuffer"
 ReplayBufferDuration="Maximale Wiederholungszeit (Sekunden)"
+ReplayBufferEstimate="Geschätzter Speicherverbrauch: ~%d MB"
+ReplayBufferEstimateUnknown="Geschätzter Speicherverbrauch: Unbekannt"
+ReplayBufferEstimate.Show="Geschätzten Speicherverbrauch anzeigen"
+ReplayBufferEstimate.ToolTip="Erneut ankreuzen oder Einstellungen anwenden, um die Schätzung zu aktualisieren."
 Status.ReplayBuffer="Pufferung"
 SaveReplayBufferHotkey="'%1' Wiederholungspuffer speichern"
 SaveReplayBufferAllHotkey="Alle Branch Output Wiederholungspuffer speichern"
diff --git a/data/locale/en-US.ini b/data/locale/en-US.ini
@@ -170,6 +170,10 @@ VideoSourceType.Source="Independent Mix (Default)"
 VideoSourceType.FilterInput="Filter Input (Experimental)"
 ReplayBuffer="Replay Buffer"
 ReplayBufferDuration="Maximum Replay Time (seconds)"
+ReplayBufferEstimate="Estimated memory usage: ~%d MB"
+ReplayBufferEstimateUnknown="Estimated memory usage: Unknown"
+ReplayBufferEstimate.Show="Show estimated memory usage"
+ReplayBufferEstimate.ToolTip="Re-check or apply settings to refresh the estimate."
 Status.ReplayBuffer="Buffering"
 SaveReplayBufferHotkey="Save '%1' Replay Buffer"
 SaveReplayBufferAllHotkey="Save all Branch Output replay buffers"
diff --git a/data/locale/fr-FR.ini b/data/locale/fr-FR.ini
@@ -169,6 +169,10 @@ VideoSourceType.Source="Mix indépendant (Par défaut)"
 VideoSourceType.FilterInput="Entrée filtre (Expérimental)"
 ReplayBuffer="Tampon de relecture"
 ReplayBufferDuration="Durée maximale de relecture (secondes)"
+ReplayBufferEstimate="Utilisation mémoire estimée : ~%d Mo"
+ReplayBufferEstimateUnknown="Utilisation mémoire estimée : Inconnue"
+ReplayBufferEstimate.Show="Afficher l'utilisation mémoire estimée"
+ReplayBufferEstimate.ToolTip="Recochez ou appliquez les paramètres pour actualiser l'estimation."
 Status.ReplayBuffer="Mise en tampon"
 SaveReplayBufferHotkey="Sauvegarder le tampon de relecture '%1'"
 SaveReplayBufferAllHotkey="Sauvegarder tous les tampons de relecture Branch Output"
diff --git a/data/locale/ja-JP.ini b/data/locale/ja-JP.ini
@@ -170,6 +170,10 @@ VideoSourceType.Source="独立ミックス (デフォルト)"
 VideoSourceType.FilterInput="フィルター入力 (実験的)"
 ReplayBuffer="リプレイバッファ"
 ReplayBufferDuration="最大リプレイ時間（秒）"
+ReplayBufferEstimate="メモリ使用量の見積もり: 約%d MB"
+ReplayBufferEstimateUnknown="メモリ使用量の見積もり: 不明"
+ReplayBufferEstimate.Show="メモリ使用量の見積もりを表示"
+ReplayBufferEstimate.ToolTip="チェックを入れなおすか、設定を適用すると最新の見積もりに更新されます。"
 Status.ReplayBuffer="バッファ中"
 SaveReplayBufferHotkey="'%1' のリプレイバッファを保存"
 SaveReplayBufferAllHotkey="全てのBranch Outputリプレイバッファを保存"
diff --git a/data/locale/ko-KR.ini b/data/locale/ko-KR.ini
@@ -169,6 +169,10 @@ VideoSourceType.Source="독립 믹스 (기본값)"
 VideoSourceType.FilterInput="필터 입력 (실험적)"
 ReplayBuffer="리플레이 버퍼"
 ReplayBufferDuration="최대 리플레이 시간 (초)"
+ReplayBufferEstimate="예상 메모리 사용량: ~%d MB"
+ReplayBufferEstimateUnknown="예상 메모리 사용량: 알 수 없음"
+ReplayBufferEstimate.Show="예상 메모리 사용량 표시"
+ReplayBufferEstimate.ToolTip="다시 체크하거나 설정을 적용하면 추정치가 업데이트됩니다."
 Status.ReplayBuffer="버퍼링 중"
 SaveReplayBufferHotkey="'%1' 리플레이 버퍼 저장"
 SaveReplayBufferAllHotkey="모든 Branch Output 리플레이 버퍼 저장"
diff --git a/data/locale/ro-RO.ini b/data/locale/ro-RO.ini
@@ -167,6 +167,10 @@ VideoSourceType.Source="Mix independent (Implicit)"
 VideoSourceType.FilterInput="Intrare filtru (Experimental)"
 ReplayBuffer="Replay Buffer"
 ReplayBufferDuration="Maximum Replay Time (seconds)"
+ReplayBufferEstimate="Estimated memory usage: ~%d MB"
+ReplayBufferEstimateUnknown="Estimated memory usage: Unknown"
+ReplayBufferEstimate.Show="Show estimated memory usage"
+ReplayBufferEstimate.ToolTip="Re-check or apply settings to refresh the estimate."
 Status.ReplayBuffer="Buffering"
 SaveReplayBufferHotkey="Save '%1' Replay Buffer"
 SaveReplayBufferAllHotkey="Save all Branch Output replay buffers"
diff --git a/data/locale/ru-RU.ini b/data/locale/ru-RU.ini
@@ -169,6 +169,10 @@ VideoSourceType.Source="Независимый микс (По умолчанию
 VideoSourceType.FilterInput="Вход фильтра (Экспериментально)"
 ReplayBuffer="Буфер воспроизведения"
 ReplayBufferDuration="Максимальное время воспроизведения (секунды)"
+ReplayBufferEstimate="Предполагаемое использование памяти: ~%d МБ"
+ReplayBufferEstimateUnknown="Предполагаемое использование памяти: Неизвестно"
+ReplayBufferEstimate.Show="Показать предполагаемое использование памяти"
+ReplayBufferEstimate.ToolTip="Установите флажок повторно или примените настройки для обновления оценки."
 Status.ReplayBuffer="Буферизация"
 SaveReplayBufferHotkey="Сохранить буфер воспроизведения '%1'"
 SaveReplayBufferAllHotkey="Сохранить все буферы воспроизведения Branch Output"
diff --git a/data/locale/uk-UA.ini b/data/locale/uk-UA.ini
@@ -169,6 +169,10 @@ VideoSourceType.Source="Незалежний мікс (За замовчуван
 VideoSourceType.FilterInput="Вхід фільтра (Експериментально)"
 ReplayBuffer="Буфер повтору"
 ReplayBufferDuration="Максимальний час повтору (секунди)"
+ReplayBufferEstimate="Орієнтовне використання пам'яті: ~%d МБ"
+ReplayBufferEstimateUnknown="Орієнтовне використання пам'яті: Невідомо"
+ReplayBufferEstimate.Show="Показати орієнтовне використання пам'яті"
+ReplayBufferEstimate.ToolTip="Поставте прапорець повторно або застосуйте налаштування для оновлення оцінки."
 Status.ReplayBuffer="Буферизація"
 SaveReplayBufferHotkey="Зберегти буфер повтору '%1'"
 SaveReplayBufferAllHotkey="Зберегти всі буфери повтору Branch Output"
diff --git a/data/locale/zh-CN.ini b/data/locale/zh-CN.ini
@@ -169,6 +169,10 @@ VideoSourceType.Source="独立混合（默认）"
 VideoSourceType.FilterInput="滤镜输入 (实验性)"
 ReplayBuffer="回放缓冲"
 ReplayBufferDuration="最大回放时间（秒）"
+ReplayBufferEstimate="预计内存使用量: ~%d MB"
+ReplayBufferEstimateUnknown="预计内存使用量: 未知"
+ReplayBufferEstimate.Show="显示预计内存使用量"
+ReplayBufferEstimate.ToolTip="重新勾选或应用设置以刷新估算值。"
 Status.ReplayBuffer="缓冲中"
 SaveReplayBufferHotkey="保存 '%1' 回放缓冲"
 SaveReplayBufferAllHotkey="保存所有 Branch Output 回放缓冲"
diff --git a/src/plugin-replay-buffer.cpp b/src/plugin-replay-buffer.cpp
@@ -82,7 +82,7 @@ obs_data_t *BranchOutputFilter::createReplayBufferSettings(obs_data_t *settings)
     obs_data_set_string(replaySettings, "extension", qUtf8Printable(getFormatExt(rbFormat)));
     obs_data_set_bool(replaySettings, "allow_spaces", !noSpace);
     obs_data_set_int(replaySettings, "max_time_sec", obs_data_get_int(settings, "replay_buffer_duration"));
-    obs_data_set_int(replaySettings, "max_size_mb", 512);
+    obs_data_set_int(replaySettings, "max_size_mb", 0);
 
     // Fragmented MP4/MOV support
     bool isFragmented = strncmp(rbFormat, "fragmented", 10) == 0;
diff --git a/src/plugin-ui.cpp b/src/plugin-ui.cpp
@@ -540,6 +540,30 @@ void BranchOutputFilter::addAdvancedSettingsGroup(obs_properties_t *props)
     );
 }
 
+static void updateReplayBufferEstimate(obs_properties_t *props, obs_data_t *settings)
+{
+    auto estimateProp = obs_properties_get(props, "replay_buffer_estimate");
+    if (!estimateProp) {
+        return;
+    }
+
+    auto seconds = obs_data_get_int(settings, "replay_buffer_duration");
+    auto vbitrate = obs_data_get_int(settings, "bitrate");
+    auto abitrate = obs_data_get_int(settings, "audio_bitrate");
+
+    if (vbitrate > 0 || abitrate > 0) {
+        int64_t memMB = int64_t(seconds) * int64_t(vbitrate + abitrate) * 1000 / 8 / 1024 / 1024;
+        if (memMB < 1) {
+            memMB = 1;
+        }
+        char buf[256];
+        snprintf(buf, sizeof(buf), obs_module_text("ReplayBufferEstimate"), static_cast<int>(memMB));
+        obs_property_set_description(estimateProp, buf);
+    } else {
+        obs_property_set_description(estimateProp, obs_module_text("ReplayBufferEstimateUnknown"));
+    }
+}
+
 void BranchOutputFilter::addReplayBufferGroup(obs_properties_t *props)
 {
     auto replayBufferGroup = obs_properties_create();
@@ -553,6 +577,26 @@ void BranchOutputFilter::addReplayBufferGroup(obs_properties_t *props)
         replayBufferGroup, "replay_buffer_duration", obs_module_text("ReplayBufferDuration"), 1, 21600, 1
     );
 
+    // Estimated memory usage checkbox (checking triggers recalculation)
+    auto rbEstimate =
+        obs_properties_add_bool(replayBufferGroup, "replay_buffer_estimate", obs_module_text("ReplayBufferEstimate.Show"));
+    obs_property_set_long_description(rbEstimate, obs_module_text("ReplayBufferEstimate.ToolTip"));
+    obs_property_set_modified_callback2(
+        rbEstimate,
+        [](void *, obs_properties_t *_props, obs_property_t *, obs_data_t *settings) {
+            if (obs_data_get_bool(settings, "replay_buffer_estimate")) {
+                updateReplayBufferEstimate(_props, settings);
+            } else {
+                obs_property_set_description(
+                    obs_properties_get(_props, "replay_buffer_estimate"),
+                    obs_module_text("ReplayBufferEstimate.Show")
+                );
+            }
+            return true;
+        },
+        nullptr
+    );
+
     //--- Replay buffer path settings ---//
     auto rbUseProfilePath = obs_properties_add_bool(
         replayBufferGroup, "replay_buffer_use_profile_path", obs_module_text("UseProfileRecordingPath")
@@ -603,6 +647,7 @@ void BranchOutputFilter::addReplayBufferGroup(obs_properties_t *props)
             auto _replayBufferEnabled = obs_data_get_bool(settings, "replay_buffer");
             obs_property_set_visible(obs_properties_get(_props, "replay_buffer_description"), !_replayBufferEnabled);
             obs_property_set_visible(obs_properties_get(_props, "replay_buffer_duration"), _replayBufferEnabled);
+            obs_property_set_visible(obs_properties_get(_props, "replay_buffer_estimate"), _replayBufferEnabled);
             obs_property_set_visible(obs_properties_get(_props, "replay_buffer_use_profile_path"), _replayBufferEnabled);
             obs_property_set_visible(obs_properties_get(_props, "replay_buffer_path"), _replayBufferEnabled);
             obs_property_set_visible(
@@ -1163,10 +1208,11 @@ obs_properties_t *BranchOutputFilter::getProperties()
     auto props = obs_properties_create();
     obs_properties_set_flags(props, OBS_PROPERTIES_DEFER_UPDATE);
 
-    // Ensure crop preview checkboxes start unchecked
+    // Ensure transient checkboxes start unchecked
     OBSDataAutoRelease settings = obs_source_get_settings(filterSource);
     obs_data_set_bool(settings, "preview_crop_rect_rel", false);
     obs_data_set_bool(settings, "preview_crop_rect_abs", false);
+    obs_data_set_bool(settings, "replay_buffer_estimate", false);
 
     // Reset crop preview when properties dialog is closed
     obs_properties_set_param(props, this, [](void *param) {
