Skip to content

Well state and primary-variable handling: direction for the open well PRs #7248

Description

@hnil

There are currently 14 open well-related PRs from me, ten of them drafts, some dating to 2022. Reviewed one at a time they look like unrelated small fixes, which is why most have stalled. Together they are one question, and I would rather settle that question than keep pushing individual patches.

The question: should well primary-variable state be owned and persisted by the simulator, or always recomputable from rates?

These four all assume the former, and all still apply to master:

Today's code assumes the latter. That disagreement, not the code, is why these sit.

Second question: does #7185 (the experimental well model) supersede this line of work? If it is the direction, I will close all four. If it is a parallel experiment, they should be judged on their own merits.

Unrelated but overdue: #7020 has been open, non-draft and mergeable since April with no review. It either needs a reviewer or a decision to close.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions