Invalid toast index

[blogh]

Hi,

Currently, we skip the pg_toast% schema in the invalid index detection service.

One of our customers performs REINDEX SCHEMA maintenance, which rebuilds toast indexes.
As a result, the service missed several invalid indexes in their database.

    SELECT current_database(), nsp.nspname AS schemaname, cls.relname, idx.indisvalid
        FROM pg_class cls
            join pg_namespace nsp on nsp.oid = cls.relnamespace
            join pg_index idx on idx.indexrelid = cls.oid
        WHERE
            cls.relkind = 'i'
        AND nsp.nspname not like 'pg_toast%'
        AND nsp.nspname NOT IN ('information_schema', 'pg_catalog');
    };

Can we remove the toast filter?

check_pgactivity/check_pgactivity

Line 4781 in a8ccfee

SELECT current_database(), nsp.nspname AS schemaname, cls.relname, idx.indisvalid

[blogh]

Note: If there is an agreement on what to do, I can make the patch.

[gleu]

I don't see how he could end up with invalid indexes for TOAST tables. Anyway, I also don't see why we would skip the test on TOAST indexes. So, bring the patch with the toast filter removal, and I'll merge it.