#1394 Include Enrichment[NAME] translation keys in update

Author: j3nsch

modules/admin/models/EnrichmentKeys.php

@@ -225,6 +225,8 @@ public function getTranslationKeys($enrichmentKey)
     {
         $patterns = $this->getKeyPatterns();
 
+        $patterns['label'] = 'Enrichment%s'; // TODO remove special handling of 'label'
+
         $translationKeys = [];
 
         foreach ($patterns as $patternName => $pattern) {

tests/library/Application/Update/UpdateEnrichmentsTest.php

@@ -63,7 +63,9 @@ public function setUp(): void
         $enrichmentKey->store();
 
         $this->translationHelper = new Admin_Model_EnrichmentKeys();
-        $this->translationHelper->createTranslations('testOldKey');
+        $this->translationHelper->createTranslations('testOldKey', null, [
+            'label' => 'EnrichmenttestOldKey'
+        ]);
 
         $this->updater = new Application_Update_UpdateEnrichments();
         $this->updater->setOutput(new NullOutput());
@@ -119,7 +121,7 @@ public function testUpdateNewKeyExists()
     public function testUpdateTranslations()
     {
         $translations = $this->translationHelper->getTranslations('testOldKey');
-        $this->assertCount(6, $translations);
+        $this->assertCount(7, $translations);
 
         $this->updater->update([
             'testOldKey' => 'testNewKey',
@@ -128,7 +130,7 @@ public function testUpdateTranslations()
         $translations = $this->translationHelper->getTranslations('testOldKey');
         $this->assertCount(0, $translations);
         $translations = $this->translationHelper->getTranslations('testNewKey');
-        $this->assertCount(6, $translations);
+        $this->assertCount(7, $translations);
 
         $this->translationHelper->removeTranslations('testNewKey');
     }
@@ -168,10 +170,10 @@ public function testUpdateTranslationNoSideEffects()
         $translationManager->setFilter('testOldKey');
 
         $matchingTranslations = $translationManager->getMergedTranslations();
-        $this->assertCount(7, $matchingTranslations);
+        $this->assertCount(8, $matchingTranslations);
 
         $translations = $this->translationHelper->getTranslations('testOldKey');
-        $this->assertCount(6, $translations);
+        $this->assertCount(7, $translations);
 
         $this->updater->update([
             'testOldKey' => 'testNewKey',
@@ -180,11 +182,11 @@ public function testUpdateTranslationNoSideEffects()
         $translations = $this->translationHelper->getTranslations('testOldKey');
         $this->assertCount(0, $translations);
         $translations = $this->translationHelper->getTranslations('testNewKey');
-        $this->assertCount(6, $translations);
+        $this->assertCount(7, $translations);
 
         $translationManager->setFilter('testNewKey');
         $matchingTranslations = $translationManager->getMergedTranslations();
-        $this->assertCount(6, $matchingTranslations);
+        $this->assertCount(7, $matchingTranslations);
 
         $this->assertArrayNotHasKey('additionalTestKey_testNewKey', $matchingTranslations);