Skip to content

Commit 1743379

Browse files
committed
Reverted the lazy loading and transactional with read-only with propagation
1 parent 7cd7737 commit 1743379

34 files changed

Lines changed: 16 additions & 91 deletions

orcid-core/src/main/java/org/orcid/core/manager/read_only/impl/ClientManagerReadOnlyImpl.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,7 @@
1212
import org.orcid.jaxb.model.client_v2.ClientSummary;
1313
import org.orcid.persistence.dao.ClientDetailsDao;
1414
import org.orcid.persistence.jpa.entities.ClientDetailsEntity;
15-
import org.springframework.transaction.annotation.Propagation;
16-
import org.springframework.transaction.annotation.Transactional;
1715

18-
@Transactional(readOnly = true, propagation = Propagation.REQUIRED)
1916
public class ClientManagerReadOnlyImpl implements ClientManagerReadOnly {
2017

2118
@Resource

orcid-core/src/main/java/org/orcid/core/manager/v3/read_only/impl/AddressManagerReadOnlyImpl.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,7 @@
1111
import org.orcid.persistence.dao.AddressDao;
1212
import org.orcid.persistence.jpa.entities.AddressEntity;
1313
import org.springframework.cache.annotation.Cacheable;
14-
import org.springframework.transaction.annotation.Propagation;
15-
import org.springframework.transaction.annotation.Transactional;
1614

17-
@Transactional(readOnly = true, propagation = Propagation.REQUIRED)
1815
public class AddressManagerReadOnlyImpl extends ManagerReadOnlyBaseImpl implements AddressManagerReadOnly {
1916

2017
@Resource

orcid-core/src/main/java/org/orcid/core/manager/v3/read_only/impl/AffiliationsManagerReadOnlyImpl.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,9 @@
4343
import org.orcid.jaxb.model.v3.release.record.summary.QualificationSummary;
4444
import org.orcid.jaxb.model.v3.release.record.summary.ServiceSummary;
4545
import org.orcid.persistence.dao.OrgAffiliationRelationDao;
46-
import org.springframework.transaction.annotation.Propagation;
47-
import org.springframework.transaction.annotation.Transactional;
4846
import org.orcid.persistence.jpa.entities.OrgAffiliationRelationEntity;
4947
import org.orcid.pojo.ajaxForm.PojoUtil;
5048

51-
@Transactional(readOnly = true, propagation = Propagation.REQUIRED)
5249
public class AffiliationsManagerReadOnlyImpl extends ManagerReadOnlyBaseImpl implements AffiliationsManagerReadOnly {
5350

5451
@Resource(name = "jpaJaxbDistinctionAdapterV3")

orcid-core/src/main/java/org/orcid/core/manager/v3/read_only/impl/ClientDetailsManagerReadOnlyImpl.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,7 @@
1919
import org.orcid.pojo.ajaxForm.PojoUtil;
2020
import org.slf4j.Logger;
2121
import org.slf4j.LoggerFactory;
22-
import org.springframework.transaction.annotation.Propagation;
23-
import org.springframework.transaction.annotation.Transactional;
2422

25-
@Transactional(readOnly = true, propagation = Propagation.REQUIRED)
2623
public class ClientDetailsManagerReadOnlyImpl implements ClientDetailsManagerReadOnly {
2724

2825
private static final Logger LOGGER = LoggerFactory.getLogger(ClientDetailsManagerReadOnlyImpl.class);

orcid-core/src/main/java/org/orcid/core/manager/v3/read_only/impl/ClientManagerReadOnlyImpl.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,7 @@
1212
import org.orcid.jaxb.model.v3.release.client.ClientSummary;
1313
import org.orcid.persistence.dao.ClientDetailsDao;
1414
import org.orcid.persistence.jpa.entities.ClientDetailsEntity;
15-
import org.springframework.transaction.annotation.Propagation;
16-
import org.springframework.transaction.annotation.Transactional;
1715

18-
@Transactional(readOnly = true, propagation = Propagation.REQUIRED)
1916
public class ClientManagerReadOnlyImpl implements ClientManagerReadOnly {
2017

2118
@Resource(name = "jpaJaxbClientAdapterV3")

orcid-core/src/main/java/org/orcid/core/manager/v3/read_only/impl/EmailManagerReadOnlyImpl.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,12 @@
2828
import org.slf4j.Logger;
2929
import org.slf4j.LoggerFactory;
3030
import org.springframework.cache.annotation.Cacheable;
31-
import org.springframework.transaction.annotation.Propagation;
32-
import org.springframework.transaction.annotation.Transactional;
3331

3432
/**
3533
*
3634
* @author Will Simpson
3735
*
3836
*/
39-
@Transactional(readOnly = true, propagation = Propagation.REQUIRED)
4037
public class EmailManagerReadOnlyImpl extends ManagerReadOnlyBaseImpl implements EmailManagerReadOnly {
4138
private static final Logger LOGGER = LoggerFactory.getLogger(EmailManagerReadOnlyImpl.class);
4239

orcid-core/src/main/java/org/orcid/core/manager/v3/read_only/impl/ExternalIdentifierManagerReadOnlyImpl.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,7 @@
1010
import org.orcid.jaxb.model.v3.release.record.PersonExternalIdentifiers;
1111
import org.orcid.persistence.dao.ExternalIdentifierDao;
1212
import org.orcid.persistence.jpa.entities.ExternalIdentifierEntity;
13-
import org.springframework.transaction.annotation.Propagation;
14-
import org.springframework.transaction.annotation.Transactional;
1513

16-
@Transactional(readOnly = true, propagation = Propagation.REQUIRED)
1714
public class ExternalIdentifierManagerReadOnlyImpl extends ManagerReadOnlyBaseImpl implements ExternalIdentifierManagerReadOnly {
1815

1916
@Resource(name = "jpaJaxbExternalIdentifierAdapterV3")

orcid-core/src/main/java/org/orcid/core/manager/v3/read_only/impl/GroupIdRecordManagerReadOnlyImpl.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,7 @@
1414
import org.orcid.jaxb.model.v3.release.groupid.GroupIdRecords;
1515
import org.orcid.persistence.dao.GroupIdRecordDao;
1616
import org.orcid.persistence.jpa.entities.GroupIdRecordEntity;
17-
import org.springframework.transaction.annotation.Propagation;
18-
import org.springframework.transaction.annotation.Transactional;
1917

20-
@Transactional(readOnly = true, propagation = Propagation.REQUIRED)
2118
public class GroupIdRecordManagerReadOnlyImpl implements GroupIdRecordManagerReadOnly {
2219

2320
@Resource(name = "jpaJaxbGroupIdRecordAdapterV3")

orcid-core/src/main/java/org/orcid/core/manager/v3/read_only/impl/OtherNameManagerReadOnlyImpl.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,7 @@
1010
import org.orcid.jaxb.model.v3.release.record.OtherNames;
1111
import org.orcid.persistence.dao.OtherNameDao;
1212
import org.orcid.persistence.jpa.entities.OtherNameEntity;
13-
import org.springframework.transaction.annotation.Propagation;
14-
import org.springframework.transaction.annotation.Transactional;
1513

16-
@Transactional(readOnly = true, propagation = Propagation.REQUIRED)
1714
public class OtherNameManagerReadOnlyImpl extends ManagerReadOnlyBaseImpl implements OtherNameManagerReadOnly {
1815

1916
@Resource(name = "jpaJaxbOtherNameAdapterV3")

orcid-core/src/main/java/org/orcid/core/manager/v3/read_only/impl/PeerReviewManagerReadOnlyImpl.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,7 @@
3131
import org.orcid.pojo.PeerReviewMinimizedSummary;
3232
import org.slf4j.Logger;
3333
import org.slf4j.LoggerFactory;
34-
import org.springframework.transaction.annotation.Propagation;
35-
import org.springframework.transaction.annotation.Transactional;
3634

37-
@Transactional(readOnly = true, propagation = Propagation.REQUIRED)
3835
public class PeerReviewManagerReadOnlyImpl extends ManagerReadOnlyBaseImpl implements PeerReviewManagerReadOnly {
3936

4037
private static final Logger LOGGER = LoggerFactory.getLogger(PeerReviewManagerReadOnlyImpl.class);

0 commit comments

Comments
 (0)