chore/275-remove-switch-user-from-registry (#7404)

Co-authored-by: Angel Montenegro <[email protected]>

Author: DanielPalafox

orcid-web/src/main/java/org/orcid/frontend/web/controllers/AdminController.java

@@ -738,30 +738,6 @@ public Map<String, String> findIdByEmailHelper(String csvEmails) {
         return form;
     }
 
-    /**
-     * Admin switch user
-     * 
-     * @throws IllegalAccessException
-     * @throws UnsupportedEncodingException
-     */
-    @RequestMapping(value = "/admin-switch-user", method = RequestMethod.GET)
-    public @ResponseBody Map<String, String> adminSwitchUser(HttpServletRequest serverRequest, HttpServletResponse response,
-            @ModelAttribute("orcidOrEmail") String orcidOrEmail) throws IllegalAccessException, UnsupportedEncodingException {
-        isAdmin(serverRequest, response);
-        Map<String, String> result = new HashMap<String, String>();
-        String orcidId = getOrcidFromParam(orcidOrEmail);
-        if (orcidId == null) {
-            result.put("errorMessg", "Invalid id " + orcidOrEmail);
-        } else {
-            if (StringUtils.isEmpty(orcidId) || !profileEntityManager.orcidExists(orcidId)) {
-                result.put("errorMessg", "Invalid id " + orcidOrEmail);
-            } else {
-                result.put("id", orcidId);
-            }
-        }
-        return result;
-    }
-
     /**
      * Admin verify email
      * 

orcid-web/src/main/resources/freemarker/admin/admin_actions.ftl

@@ -5,10 +5,5 @@
         <#include "/includes/ng2_templates/id-banner-ng2-template.ftl"/>
         <id-banner-ng2> </id-banner-ng2>
     </div>
-    <!-- Right menu bar -->
-    <div class="col-md-9 col-sm-12 col-xs-12 admin-options">
-        <#include "../includes/ng2_templates/admin-actions-ng2-template.ftl">    
-        <admin-actions-ng2></admin-actions-ng2>    
-    </div>
 </div>
 </@public>

orcid-web/src/main/resources/freemarker/includes/ng2_templates/user-menu-template.ftl

@@ -55,11 +55,6 @@
                                     <img src="{{assetsPath + '/img/svg/baseline-build-24px.svg'}}"> 
                                     {{'${springMacroRequestContext.getMessage("workspace.self_service")?replace("<br />", " ")?replace("'", "\\'")}'  }}
                                 </a>
-                                <#--  ADMIN ACTIONS  -->
-                                <a  class="top-menu-item" *ngIf="userInfo['ADMIN_MENU']" href="{{getBaseUri()}}/admin-actions">
-                                    <img src="{{assetsPath + '/img/svg/baseline-verified_user-24px.svg'}}"> 
-                                    {{'${springMacroRequestContext.getMessage("admin.workspace_link")?replace("<br />", " ")?replace("'", "\\'")}'}}
-                                </a>
                                 <#--  SIGN OUT  -->
                                 <a  class="top-menu-item" href="{{getBaseUri()}}/signout">
                                     <img src="{{assetsPath + '/img/svg/baseline-exit_to_app-24px.svg'}}"> 

orcid-web/src/test/java/org/orcid/frontend/web/controllers/AdminControllerLegacyTest.java

@@ -1139,48 +1139,6 @@ public ProfileEntity answer(InvocationOnMock invocation) throws Throwable {
         assertEquals(1, results.getTrusted().getErrors().size());
     }
 
-    @Test
-    public void adminSwitchUser() throws Exception {
-        ProfileEntityCacheManager profileEntityCacheManager = Mockito.mock(ProfileEntityCacheManager.class);
-        ProfileEntityManager profileEntityManager = Mockito.mock(ProfileEntityManager.class);
-        EmailManager emailManager = Mockito.mock(EmailManager.class);        
-        OrcidSecurityManager orcidSecurityManager = Mockito.mock(OrcidSecurityManager.class);
-
-        AdminController adminController = new AdminController();
-               
-        ReflectionTestUtils.setField(adminController, "orcidSecurityManager", orcidSecurityManager);
-        ReflectionTestUtils.setField(adminController, "profileEntityManager", profileEntityManager);
-        ReflectionTestUtils.setField(adminController, "emailManager", emailManager);
-        ReflectionTestUtils.setField(adminController, "profileEntityCacheManager", profileEntityCacheManager);                
-        
-        Mockito.when(orcidSecurityManager.isAdmin()).thenReturn(true);
-        
-        Mockito.when(emailManager.emailExists(Mockito.anyString())).thenReturn(true);
-        Mockito.when(emailManager.emailExists(Mockito.eq("[email protected]"))).thenReturn(false);
-        Mockito.when(emailManager.emailExists(Mockito.eq("[email protected]"))).thenReturn(false);                            
-        
-        Mockito.when(profileEntityManager.orcidExists(Mockito.anyString())).thenReturn(true);
-        Mockito.when(profileEntityManager.orcidExists(Mockito.eq("[email protected]"))).thenReturn(false);
-        Mockito.when(profileEntityManager.orcidExists(Mockito.eq("[email protected]"))).thenReturn(false);                
-      
-        Map<String, String> results = adminController.adminSwitchUser(mockRequest, mockResponse, "[email protected]");
-
-        assertEquals("Invalid id [email protected]", results.get("errorMessg"));        
-   
-        results = adminController.adminSwitchUser(mockRequest, mockResponse, "[email protected]");
-        
-        assertEquals("Invalid id [email protected]", results.get("errorMessg"));
-        
-        results = adminController.adminSwitchUser(mockRequest, mockResponse, "0000-0000-0000-0001");
-        
-        assertEquals("0000-0000-0000-0001", results.get("id"));
-        
-        results = adminController.adminSwitchUser(mockRequest, mockResponse, "https://orcid.org/0000-0000-0000-0002");
-        
-        assertEquals("0000-0000-0000-0002", results.get("id"));
-
-    }     
- 
     @Test
     public void resetPasswordValidateId() throws Exception {
         ProfileEntityCacheManager profileEntityCacheManager = Mockito.mock(ProfileEntityCacheManager.class);