Skip to content

Commit 0c1b174

Browse files
committed
PD-5445
1 parent d5a1523 commit 0c1b174

6 files changed

Lines changed: 11 additions & 12 deletions

File tree

projects/orcid-registry-ui/src/lib/components/auth-challenge/auth-challenge.component.html

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,10 @@ <h1 class="orc-font-heading-small text-center font-normal" i18n>
2828
>&nbsp;}<ng-container
2929
i18n="
3030
auth challenge action clause|Clause in the verification sentence before
31-
a dynamic action fragment. actionDescription is a translated verb phrase
32-
like 'disable 2FA', 'unlink the alternate sign in account', or 'complete
33-
your password reset'. Keep the sentence natural in your
34-
language.@@authChallenge.toActionDescription"
35-
>to {{ actionDescription }}</ng-container
31+
a dynamic action fragment. actionDescription is a translated clause like
32+
'to disable 2FA', 'to unlink the alternate sign in account', or 'for'.
33+
Keep the sentence natural in your language.@@authChallenge.actionDescriptionClause"
34+
>{{ actionDescription }}</ng-container
3635
>@if (boldText) {&nbsp;<b>{{ boldText }}</b
3736
>}@if (trailingText) {&nbsp;{{ trailingText }}}
3837
</p>

projects/orcid-ui-docs/src/app/pages/orcid-registry-ui/auth-challenge-page.component.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ <h4>2A. Usage via MatDialog</h4>
9393
&#123;
9494
data: &#123;
9595
parentForm: this.form,
96-
actionDescription: 'unlink the alternate sign in account',
96+
actionDescription: 'to unlink the alternate sign in account',
9797
boldText: 'Google',
9898
trailingText: 'to continue.',
9999
showTwoFactorField: this.twoFactorState, // true or false
@@ -139,7 +139,7 @@ <h4>2B. Usage via CdkPortalOutlet</h4>
139139

140140
// Bind inputs directly to the instance
141141
componentRef.instance.parentForm = this.form;
142-
componentRef.instance.actionDescription = 'complete your password reset';
142+
componentRef.instance.actionDescription = 'to complete your password reset';
143143
componentRef.instance.showPasswordField = false;
144144

145145
componentRef.instance.submitAttempt.subscribe(() => &#123;
@@ -214,7 +214,7 @@ <h4>4. Backend Implementation</h4>
214214
<li>
215215
<code style="font-weight: bold">actionDescription</code>:
216216
<code>string</code>. The contextual text for what the user is doing
217-
(e.g. <code>'unlink the alternate sign in account'</code>).
217+
(e.g. <code>'to unlink the alternate sign in account'</code>).
218218
</li>
219219
<li>
220220
<code style="font-weight: bold">boldText</code>: <code>string</code>.

projects/orcid-ui-docs/src/app/pages/orcid-registry-ui/auth-challenge-page.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ import { takeUntil } from 'rxjs/operators'
4040
export class AuthChallengePageComponent implements OnInit {
4141
showPasswordField = true
4242
showTwoFactorField = true
43-
actionDescription = 'perform this action on'
43+
actionDescription = 'to perform this action on'
4444
boldText = 'Example Account'
4545
trailingText = 'to continue.'
4646
form: UntypedFormGroup

src/app/account-settings/components/settings-security-alternate-sign-in/settings-security-alternate-sign-in.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export class SettingsSecurityAlternateSignInComponent
4242
$destroy = new Subject<void>()
4343
isMobile: any
4444
refreshAccounts$ = new BehaviorSubject<void>(undefined)
45-
authChallengeLabel = $localize`:@@accountSettings.security.unlinkTheAlternateSignInAccount:unlink the alternate sign in account`
45+
authChallengeLabel = $localize`:@@accountSettings.security.unlinkTheAlternateSignInAccount:to unlink the alternate sign in account`
4646
labelDeleteButton = $localize`:@@shared.delete:Delete`
4747

4848
constructor(

src/app/account-settings/components/settings-security-password/settings-security-password.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ export class SettingsSecurityPasswordComponent implements OnInit, OnDestroy {
4848
currentValidateAtLeastALetterOrSymbolStatus: boolean
4949
currentValidateAtLeastANumber: boolean
5050
confirmPasswordPlaceholder = $localize`:@@accountSettings.security.password.confirmPasswordPlaceholder:Confirm your new password`
51-
authChallengeLabel = $localize`:@@accountSettings.security.password.authChallengeLabel:complete your password reset`
51+
authChallengeLabel = $localize`:@@accountSettings.security.password.authChallengeLabel:to complete your password reset`
5252
errorMatcher = new ErrorStateMatcherForTwoFactorFields()
5353

5454
constructor(

src/app/account-settings/components/settings-security-two-factor-auth/settings-security-two-factor-auth.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export class SettingsSecurityTwoFactorAuthComponent implements OnInit {
2828
form: UntypedFormGroup
2929
success = false
3030
cancel = false
31-
authChallengeLabel = $localize`:@@accountSettings.security.disable2FA:disable 2FA`
31+
authChallengeLabel = $localize`:@@accountSettings.security.disable2FA:to disable 2FA`
3232

3333
constructor(
3434
private _router: Router,

0 commit comments

Comments
 (0)