lmendoza/jun-2025-multiple-changes

Author: cryptalith

package.json

@@ -3,7 +3,7 @@
   "version": "0.0.0",
   "scripts": {
     "start-local": "npm run build-runtime-env && ng serve --disable-host-check --host 0.0.0.0",
-    "start": "npm run build-runtime-env && ng serve --configuration=local-qa --host 0.0.0.0 --verbose",
+    "start": "npm run build-runtime-env && ng serve --configuration=local-qa --host 0.0.0.0",
     "start-sandbox": "ng serve --configuration=local-sandbox --host 0.0.0.0",
     "start:en": "ng serve --configuration=local-qa-en --disable-host-check",
     "start:ar": "ng serve --configuration=local-qa-ar --disable-host-check",

src/app/core/observability-events/observability-events.service.ts

@@ -99,7 +99,10 @@ export class CustomEventService {
 
     // Send the final custom event to New Relic
     if (typeof (this.window as any).newrelic?.addPageAction === 'function') {
-      ;(this.window as any).newrelic?.addPageAction(journeyType, finalAttributes)
+      ;(this.window as any).newrelic?.addPageAction(
+        journeyType,
+        finalAttributes
+      )
     }
 
     // Clean up the journey data

src/app/layout/header/header.component.scss

@@ -197,5 +197,5 @@ app-search {
 }
 
 app-user-menu {
-  display: flex ;
-}
+  display: flex;
+}

src/app/layout/search/search.component.scss

@@ -131,6 +131,4 @@ button {
 
 app-user-menu {
   overflow: hidden;
-  // display: flex;
 }
-

src/app/layout/user-menu/user-menu.component.html

@@ -33,7 +33,6 @@
     mat-stroked-button
     class="user-menu-button"
     (click)="goto('inbox', 'fromHeaderButton')"
-    [attr.aria-label]="labelInbox"
     id="cy-inbox-button"
     *ngIf="userInfo"
     [matTooltip]="

src/app/layout/user-menu/user-menu.component.scss

@@ -14,7 +14,7 @@ section {
     flex-wrap: nowrap;
     max-width: 248px;
     overflow: hidden;
-    text-overflow: ellipsis;app-user-men
+    text-overflow: ellipsis;
 
     img {
       height: 36px;
@@ -83,4 +83,4 @@ span.name-text-container {
   min-width: 40px;
   padding: 0;
   margin: 0 16px;
-}
+}

src/app/layout/user-menu/user-menu.component.ts

@@ -26,7 +26,6 @@ export class UserMenuComponent implements OnInit {
   platform: PlatformInfo
   labelSigninRegister = $localize`:@@layout.ariaLabelSigninRegister:Sign in to ORCID or register for your ORCID iD`
   labelUserMenu = $localize`:@@layout.ariaLabelUserMenu:User menu`
-  labelInbox = $localize`:@@layout.ariaLabelInbox:Inbox`
   notificationTooltipActive = $localize`:@@layout.notificationTooltip:You have unread notifications`
   notificationTooltip = $localize`:@@layout.notificationTooltipInactive:Notifications inbox`
   isAccountDelegate: boolean

src/locale/properties/layout/layout.en.properties

@@ -114,3 +114,5 @@ footer.cookieSettings=Cookie Settings
 footer.ariaLabelLicense=license
 layout.ariaLabelConnectingResearchers=Connecting research and researchers
 layout.ariaLabelSearchRegistry=Search the ORCID registry...
+layout.notificationTooltip=You have unread notifications
+layout.notificationTooltipInactive=Notifications inbox

src/proxy.conf.qa.mjs

@@ -8,9 +8,9 @@
  */
 function bypassHtmlOrJson(req, res) {
   if (req.headers.accept?.includes('html')) {
-    return '/index.html';
+    return '/index.html'
   }
-  req.headers['X-Dev-Header'] = 'local-host-proxy-call';
+  req.headers['X-Dev-Header'] = 'local-host-proxy-call'
 }
 
 /**
@@ -20,8 +20,8 @@ function bypassHtmlOrJson(req, res) {
  * ──────────────────────────────────────────────────────────────────────────────
  */
 function proxyReqOverrideHeaders(proxyReq /* http.ClientRequest */, req, res) {
-  proxyReq.setHeader('Origin',  'https://qa.orcid.org');
-  proxyReq.setHeader('Referer', 'https://qa.orcid.org');
+  proxyReq.setHeader('Origin', 'https://qa.orcid.org')
+  proxyReq.setHeader('Referer', 'https://qa.orcid.org')
 }
 
 /**
@@ -33,22 +33,22 @@ function proxyReqOverrideHeaders(proxyReq /* http.ClientRequest */, req, res) {
  */
 function responseOverridesAuth() {
   return (proxyRes, req, res) => {
-    const cookies = proxyRes.headers['set-cookie'];
+    const cookies = proxyRes.headers['set-cookie']
     if (Array.isArray(cookies)) {
       proxyRes.headers['set-cookie'] = cookies.map((cookie) =>
         cookie.replace(/Domain=\.?(qa\.)?orcid\.org/i, 'Domain=localhost')
-      );
+      )
     }
     if (proxyRes.statusCode >= 300 && proxyRes.statusCode < 400) {
-      let location = proxyRes.headers['location'];
+      let location = proxyRes.headers['location']
       if (typeof location === 'string') {
         proxyRes.headers['location'] = location.replace(
           'http://auth.qa.orcid.org/login',
           'http://localhost:4200/auth/login'
-        );
+        )
       }
     }
-  };
+  }
 }
 
 /**
@@ -60,22 +60,22 @@ function responseOverridesAuth() {
  */
 function responseOverridesGeneric() {
   return (proxyRes, req, res) => {
-    const cookies = proxyRes.headers['set-cookie'];
+    const cookies = proxyRes.headers['set-cookie']
     if (Array.isArray(cookies)) {
       proxyRes.headers['set-cookie'] = cookies.map((cookie) =>
         cookie.replace(/Domain=\.?(qa\.)?orcid\.org/i, 'Domain=localhost')
-      );
+      )
     }
     if (proxyRes.statusCode >= 300 && proxyRes.statusCode < 400) {
-      let location = proxyRes.headers['location'];
+      let location = proxyRes.headers['location']
       if (typeof location === 'string') {
         proxyRes.headers['location'] = location.replace(
           'https://qa.orcid.org/signin',
           'http://localhost:4200/signin'
-        );
+        )
       }
     }
-  };
+  }
 }
 
 /**
@@ -112,4 +112,4 @@ export default {
     bypass: bypassHtmlOrJson,
     onProxyRes: responseOverridesGeneric(),
   },
-};
+}