Skip to content

Commit 59e653f

Browse files
authored
PD-5292 add tooltip and aria label to remove alt sign in button (#2797)
Co-authored-by: andrej romanov <50377758+auumgn@users.noreply.github.com>
1 parent 7a75dd5 commit 59e653f

2 files changed

Lines changed: 12 additions & 2 deletions

File tree

src/app/account-settings/components/settings-security-alternate-sign-in/settings-security-alternate-sign-in.component.html

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,11 @@
3838
<div *ngFor="let account of accounts">
3939
<div class="mobile-elements-container">
4040
<div>
41-
<button (click)="delete(account)" mat-icon-button>
41+
<button
42+
(click)="delete(account)"
43+
[attr.aria-label]="labelDeleteButton + ' ' + account?.idpName"
44+
mat-icon-button
45+
>
4246
<mat-icon>delete</mat-icon>
4347
</button>
4448
</div>
@@ -96,7 +100,12 @@
96100
<ng-container matColumnDef="actions" stickyEnd>
97101
<th mat-header-cell *matHeaderCellDef></th>
98102
<td mat-cell *matCellDef="let element">
99-
<button (click)="delete(element)" mat-icon-button>
103+
<button
104+
[matTooltip]="labelDeleteButton"
105+
[attr.aria-label]="labelDeleteButton + ' ' + element?.idpName"
106+
(click)="delete(element)"
107+
mat-icon-button
108+
>
100109
<mat-icon>delete</mat-icon>
101110
</button>
102111
</td>

src/app/account-settings/components/settings-security-alternate-sign-in/settings-security-alternate-sign-in.component.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ export class SettingsSecurityAlternateSignInComponent
4343
isMobile: any
4444
refreshAccounts$ = new BehaviorSubject<void>(undefined)
4545
authChallengeLabel = $localize`:@@accountSettings.security.unlinkTheAlternateSignInAccount:unlink the alternate sign in account`
46+
labelDeleteButton = $localize`:@@shared.delete:Delete`
4647

4748
constructor(
4849
private _accountSettingAlternate: AccountSecurityAlternateSignInService,

0 commit comments

Comments
 (0)