Merge branch 'main' into lmendoza/PD-5506-v2

cryptalith · web-flow · commit 5e0ea7bb0593 · 2026-05-29T08:42:01.000-06:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## v2.134.5 - 2026-05-26
+
+[Full Changelog](https://github.com/ORCID/orcid-angular/compare/v2.134.4...v2.134.5)
+
 ## v2.134.4 - 2026-05-25
 
 [Full Changelog](https://github.com/ORCID/orcid-angular/compare/v2.134.3...v2.134.4)
diff --git a/src/app/record/components/record-header/featured-employment-caption.util.ts b/src/app/record/components/record-header/featured-employment-caption.util.ts
@@ -10,7 +10,9 @@ export function getFeaturedEmploymentCaption(
     return ''
   }
 
-  const employmentGroup = affiliations.find((group) => group.type === 'EMPLOYMENT')
+  const employmentGroup = affiliations.find(
+    (group) => group.type === 'EMPLOYMENT'
+  )
 
   if (!employmentGroup || !employmentGroup.affiliationGroup) {
     return ''
@@ -79,4 +81,4 @@ function formatAffiliationCaption(affiliation: Affiliation): string {
   }
 
   return parts.join(' ')
-}
+}
diff --git a/src/app/record/components/record-header/record-header.component.spec.ts b/src/app/record/components/record-header/record-header.component.spec.ts
@@ -30,9 +30,11 @@ describe('RecordHeaderComponent', () => {
       'getRecord',
     ])
     togglzService = {
-      getStateOf: jasmine.createSpy('getStateOf').and.callFake((flag: string) =>
-        of(flag === TogglzFlag.FEATURED_AFFILIATIONS)
-      ),
+      getStateOf: jasmine
+        .createSpy('getStateOf')
+        .and.callFake((flag: string) =>
+          of(flag === TogglzFlag.FEATURED_AFFILIATIONS)
+        ),
     }
 
     await TestBed.configureTestingModule({
diff --git a/src/app/record/pages/my-orcid/my-orcid-header-loading.spec.ts b/src/app/record/pages/my-orcid/my-orcid-header-loading.spec.ts
@@ -14,9 +14,10 @@ describe('MyOrcidComponent header loading state', () => {
 
   beforeEach(() => {
     recordHeaderState = new RecordHeaderStateService()
-    rumEvents = jasmine.createSpyObj<RumJourneyEventService>('RumJourneyEventService', [
-      'recordSimpleEvent',
-    ])
+    rumEvents = jasmine.createSpyObj<RumJourneyEventService>(
+      'RumJourneyEventService',
+      ['recordSimpleEvent']
+    )
     component = new MyOrcidComponent(
       {} as any,
       {} as any,
@@ -104,14 +105,14 @@ describe('MyOrcidComponent header loading state', () => {
   it('should record the featured employment caption event once when enabled', () => {
     const record = getUserRecord()
     record.affiliations[0].affiliationGroup[0].affiliations[0].featured = true
-    record.affiliations[0].affiliationGroup[0].affiliations[0].affiliationType = {
-      value: AffiliationType.employment,
-    }
+    record.affiliations[0].affiliationGroup[0].affiliations[0].affiliationType =
+      {
+        value: AffiliationType.employment,
+      }
 
     component.publicOrcid = record.userInfo.REAL_USER_ORCID
     ;(component as any).featuredAffiliationsEnabled = true
     spyOn(performance, 'now').and.returnValue(275)
-
     ;(component as any).checkFeaturedEmploymentCaptionState(record)
     ;(component as any).checkFeaturedEmploymentCaptionState(record)
 
@@ -134,7 +135,6 @@ describe('MyOrcidComponent header loading state', () => {
 
     component.publicOrcid = record.userInfo.REAL_USER_ORCID
     ;(component as any).featuredAffiliationsEnabled = false
-
     ;(component as any).checkFeaturedEmploymentCaptionState(record)
 
     expect(rumEvents.recordSimpleEvent).not.toHaveBeenCalledWith(
diff --git a/src/locale/messages.lr.xlf b/src/locale/messages.lr.xlf
@@ -760,7 +760,7 @@
         </context-group>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/components/record-header/record-header.component.ts</context>
-          <context context-type="linenumber">136</context>
+          <context context-type="linenumber">132</context>
         </context-group>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/components/work-details/work-details.component.ts</context>
@@ -5659,7 +5659,7 @@
         </context-group>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/components/record-header/record-header.component.ts</context>
-          <context context-type="linenumber">139</context>
+          <context context-type="linenumber">135</context>
         </context-group>
         <target>LR</target>
       </trans-unit>
@@ -5671,7 +5671,7 @@
         </context-group>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/components/record-header/record-header.component.ts</context>
-          <context context-type="linenumber">140</context>
+          <context context-type="linenumber">136</context>
         </context-group>
         <target>LR</target>
       </trans-unit>
@@ -5683,7 +5683,7 @@
         </context-group>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/components/record-header/record-header.component.ts</context>
-          <context context-type="linenumber">138</context>
+          <context context-type="linenumber">134</context>
         </context-group>
         <target>LR</target>
       </trans-unit>
@@ -13375,7 +13375,7 @@
         </context-group>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/components/record-header/record-header.component.ts</context>
-          <context context-type="linenumber">276</context>
+          <context context-type="linenumber">281</context>
         </context-group>
         <target>LR</target>
       </trans-unit>
@@ -13387,15 +13387,15 @@
         </context-group>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/components/record-header/record-header.component.ts</context>
-          <context context-type="linenumber">280</context>
+          <context context-type="linenumber">285</context>
         </context-group>
         <target>LR</target>
       </trans-unit>
       <trans-unit id="topBar.names" datatype="html" resname="topBar.names">
         <source>Names</source>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/components/record-header/record-header.component.ts</context>
-          <context context-type="linenumber">132</context>
+          <context context-type="linenumber">128</context>
         </context-group>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/components/top-bar/modals/modal-name/modal-name.component.html</context>
@@ -13415,47 +13415,47 @@
         <source>Printable record</source>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/components/record-header/record-header.component.ts</context>
-          <context context-type="linenumber">134</context>
+          <context context-type="linenumber">130</context>
         </context-group>
         <target>LR</target>
       </trans-unit>
       <trans-unit id="topBar.copyId" datatype="html" resname="topBar.copyId">
         <source>Copy iD</source>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/components/record-header/record-header.component.ts</context>
-          <context context-type="linenumber">135</context>
+          <context context-type="linenumber">131</context>
         </context-group>
         <target>LR</target>
       </trans-unit>
       <trans-unit id="summary.hideRecordSummary" datatype="html" resname="summary.hideRecordSummary">
         <source>Hide record summary</source>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/components/record-header/record-header.component.ts</context>
-          <context context-type="linenumber">141</context>
+          <context context-type="linenumber">137</context>
         </context-group>
         <target>LR</target>
       </trans-unit>
       <trans-unit id="summary.showRecordSummary" datatype="html" resname="summary.showRecordSummary">
         <source>Show record summary</source>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/components/record-header/record-header.component.ts</context>
-          <context context-type="linenumber">142</context>
+          <context context-type="linenumber">138</context>
         </context-group>
         <target>LR</target>
       </trans-unit>
       <trans-unit id="topBar.ariaLabelCopyOrcidId" datatype="html" resname="topBar.ariaLabelCopyOrcidId">
         <source>Copy your ORCID iD to the clipboard</source>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/components/record-header/record-header.component.ts</context>
-          <context context-type="linenumber">144</context>
+          <context context-type="linenumber">140</context>
         </context-group>
         <target>LR</target>
       </trans-unit>
       <trans-unit id="topBar.ariaLabelViewPrintable" datatype="html" resname="topBar.ariaLabelViewPrintable">
         <source>View a printable version of your ORCID record (Opens in new tab)</source>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/components/record-header/record-header.component.ts</context>
-          <context context-type="linenumber">145</context>
+          <context context-type="linenumber">141</context>
         </context-group>
         <target>LR</target>
       </trans-unit>
@@ -16299,7 +16299,7 @@
         </context-group>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/pages/my-orcid/my-orcid.component.ts</context>
-          <context context-type="linenumber">89</context>
+          <context context-type="linenumber">96</context>
         </context-group>
         <target>LR</target>
       </trans-unit>
@@ -16323,15 +16323,15 @@
         <source>Collapse all activity sections</source>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/pages/my-orcid/my-orcid.component.ts</context>
-          <context context-type="linenumber">63</context>
+          <context context-type="linenumber">70</context>
         </context-group>
         <target>LR</target>
       </trans-unit>
       <trans-unit id="shared.expandAllActivitiesArialLabel" datatype="html" resname="shared.expandAllActivitiesArialLabel">
         <source>Expand all activity sections</source>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/pages/my-orcid/my-orcid.component.ts</context>
-          <context context-type="linenumber">64</context>
+          <context context-type="linenumber">71</context>
         </context-group>
         <target>LR</target>
       </trans-unit>
diff --git a/src/locale/messages.rl.xlf b/src/locale/messages.rl.xlf
@@ -760,7 +760,7 @@
         </context-group>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/components/record-header/record-header.component.ts</context>
-          <context context-type="linenumber">136</context>
+          <context context-type="linenumber">132</context>
         </context-group>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/components/work-details/work-details.component.ts</context>
@@ -5659,7 +5659,7 @@
         </context-group>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/components/record-header/record-header.component.ts</context>
-          <context context-type="linenumber">139</context>
+          <context context-type="linenumber">135</context>
         </context-group>
         <target>RL</target>
       </trans-unit>
@@ -5671,7 +5671,7 @@
         </context-group>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/components/record-header/record-header.component.ts</context>
-          <context context-type="linenumber">140</context>
+          <context context-type="linenumber">136</context>
         </context-group>
         <target>RL</target>
       </trans-unit>
@@ -5683,7 +5683,7 @@
         </context-group>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/components/record-header/record-header.component.ts</context>
-          <context context-type="linenumber">138</context>
+          <context context-type="linenumber">134</context>
         </context-group>
         <target>RL</target>
       </trans-unit>
@@ -13375,7 +13375,7 @@
         </context-group>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/components/record-header/record-header.component.ts</context>
-          <context context-type="linenumber">276</context>
+          <context context-type="linenumber">281</context>
         </context-group>
         <target>RL</target>
       </trans-unit>
@@ -13387,15 +13387,15 @@
         </context-group>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/components/record-header/record-header.component.ts</context>
-          <context context-type="linenumber">280</context>
+          <context context-type="linenumber">285</context>
         </context-group>
         <target>RL</target>
       </trans-unit>
       <trans-unit id="topBar.names" datatype="html" resname="topBar.names">
         <source>Names</source>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/components/record-header/record-header.component.ts</context>
-          <context context-type="linenumber">132</context>
+          <context context-type="linenumber">128</context>
         </context-group>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/components/top-bar/modals/modal-name/modal-name.component.html</context>
@@ -13415,47 +13415,47 @@
         <source>Printable record</source>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/components/record-header/record-header.component.ts</context>
-          <context context-type="linenumber">134</context>
+          <context context-type="linenumber">130</context>
         </context-group>
         <target>RL</target>
       </trans-unit>
       <trans-unit id="topBar.copyId" datatype="html" resname="topBar.copyId">
         <source>Copy iD</source>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/components/record-header/record-header.component.ts</context>
-          <context context-type="linenumber">135</context>
+          <context context-type="linenumber">131</context>
         </context-group>
         <target>RL</target>
       </trans-unit>
       <trans-unit id="summary.hideRecordSummary" datatype="html" resname="summary.hideRecordSummary">
         <source>Hide record summary</source>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/components/record-header/record-header.component.ts</context>
-          <context context-type="linenumber">141</context>
+          <context context-type="linenumber">137</context>
         </context-group>
         <target>RL</target>
       </trans-unit>
       <trans-unit id="summary.showRecordSummary" datatype="html" resname="summary.showRecordSummary">
         <source>Show record summary</source>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/components/record-header/record-header.component.ts</context>
-          <context context-type="linenumber">142</context>
+          <context context-type="linenumber">138</context>
         </context-group>
         <target>RL</target>
       </trans-unit>
       <trans-unit id="topBar.ariaLabelCopyOrcidId" datatype="html" resname="topBar.ariaLabelCopyOrcidId">
         <source>Copy your ORCID iD to the clipboard</source>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/components/record-header/record-header.component.ts</context>
-          <context context-type="linenumber">144</context>
+          <context context-type="linenumber">140</context>
         </context-group>
         <target>RL</target>
       </trans-unit>
       <trans-unit id="topBar.ariaLabelViewPrintable" datatype="html" resname="topBar.ariaLabelViewPrintable">
         <source>View a printable version of your ORCID record (Opens in new tab)</source>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/components/record-header/record-header.component.ts</context>
-          <context context-type="linenumber">145</context>
+          <context context-type="linenumber">141</context>
         </context-group>
         <target>RL</target>
       </trans-unit>
@@ -16299,7 +16299,7 @@
         </context-group>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/pages/my-orcid/my-orcid.component.ts</context>
-          <context context-type="linenumber">89</context>
+          <context context-type="linenumber">96</context>
         </context-group>
         <target>RL</target>
       </trans-unit>
@@ -16323,15 +16323,15 @@
         <source>Collapse all activity sections</source>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/pages/my-orcid/my-orcid.component.ts</context>
-          <context context-type="linenumber">63</context>
+          <context context-type="linenumber">70</context>
         </context-group>
         <target>RL</target>
       </trans-unit>
       <trans-unit id="shared.expandAllActivitiesArialLabel" datatype="html" resname="shared.expandAllActivitiesArialLabel">
         <source>Expand all activity sections</source>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/record/pages/my-orcid/my-orcid.component.ts</context>
-          <context context-type="linenumber">64</context>
+          <context context-type="linenumber">71</context>
         </context-group>
         <target>RL</target>
       </trans-unit>
diff --git a/src/locale/messages.xlf b/src/locale/messages.xlf
diff --git a/src/locale/messages.xx.xlf b/src/locale/messages.xx.xlf

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,9 @@ export function getFeaturedEmploymentCaption(`
`10`	`10`	`return ''`
`11`	`11`	`}`
`12`	`12`
`13`		`- const employmentGroup = affiliations.find((group) => group.type === 'EMPLOYMENT')`
	`13`	`+ const employmentGroup = affiliations.find(`
	`14`	`+ (group) => group.type === 'EMPLOYMENT'`
	`15`	`+ )`
`14`	`16`
`15`	`17`	`if (!employmentGroup \|\| !employmentGroup.affiliationGroup) {`
`16`	`18`	`return ''`
`@@ -79,4 +81,4 @@ function formatAffiliationCaption(affiliation: Affiliation): string {`
`79`	`81`	`}`
`80`	`82`
`81`	`83`	`return parts.join(' ')`
`82`		`-}`
	`84`	`+}`