Skip to content

Commit 73df25b

Browse files
committed
Fixed the layout for orcid integration mvp notification in the inbox
1 parent 919c0ce commit 73df25b

6 files changed

Lines changed: 49 additions & 4 deletions

File tree

src/app/inbox/components/notification-permission/notification-permission.component.html

Lines changed: 26 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
1-
<div class="intro">{{ notification?.notificationIntro }}</div>
1+
<div *ngIf="isOrcidIntegration" class="intro">
2+
<ng-container i18n="@@inbox.youCanBenefitFromAutomatic" >You can benefit from automatic updates to your record. Based on your verified email domains we have found an ORCID integration for</ng-container> <strong>{{ orcidIntegrationMemberName }}</strong>. <ng-container i18n="@@inbox.connectingWithThisIntegrationWillAllow" >Connecting with this integration will allow</ng-container> {{ orcidIntegrationMemberName }} <ng-container i18n="@@inbox.toAutomaticallyAddValidatedInformation" >to automatically add validated information to your ORCID record.</ng-container>
3+
</div>
4+
<div *ngIf="!isOrcidIntegration" class="intro">{{ notification?.notificationIntro }}</div>
25

3-
<div>
6+
<div *ngIf="!isOrcidIntegration">
47
<strong>{{ notification?.source.sourceName.content }}</strong>
58
<ng-container i18n="@@inbox.likeYourPermission"
69
>would like your permission to interact with your ORCID Record as a trusted
@@ -24,7 +27,7 @@
2427
</li>
2528
</ul>
2629
</div>
27-
<div class="buttons-container">
30+
<div *ngIf="!isOrcidIntegration" class="buttons-container">
2831
<button
2932
*ngIf="!notification?.archivedDate"
3033
(click)="archive(); $event.stopPropagation()"
@@ -35,7 +38,7 @@
3538
>
3639
Archive without granting permissions
3740
</button>
38-
<a
41+
<a
3942
target="_blank"
4043
rel="noopener noreferrer"
4144
[href]="notification?.authorizationUrl.uri"
@@ -50,3 +53,22 @@
5053
</button>
5154
</a>
5255
</div>
56+
57+
<div *ngIf="isOrcidIntegration" class="buttons-container">
58+
<a
59+
target="_blank"
60+
rel="noopener noreferrer"
61+
[href]="orcidIntegrationLink"
62+
>
63+
<button
64+
mat-raised-button
65+
color="primary"
66+
class="grant-permission"
67+
i18n="@@inbox.connectWith"
68+
[innerHTML]="'Connect with ' + orcidIntegrationMemberName"
69+
i18n="@@inbox.connectWith|Connect with {orcidIntegrationMemberName}"
70+
>
71+
Connect with
72+
</button>
73+
</a>
74+
</div>

src/app/inbox/components/notification-permission/notification-permission.component.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,20 @@ import { InboxService } from '../../../core/inbox/inbox.service'
1616
export class NotificationPermissionComponent implements OnInit {
1717
@Input() notification: InboxNotificationPermission
1818
itemsByType: { type: string; items: Item[] }[]
19+
isOrcidIntegration: boolean = false
20+
orcidIntegrationLink: string
21+
orcidIntegrationMemberName: string
1922

2023
constructor(
2124
@Inject(WINDOW) private window: Window,
2225
private _inbox: InboxService
2326
) {}
2427

2528
ngOnInit(): void {
29+
if(this.notification?.notificationIntro?.includes('::')) {
30+
[this.orcidIntegrationMemberName,this.orcidIntegrationLink] = this.notification.notificationIntro.split('::')
31+
this.isOrcidIntegration = true
32+
}
2633
this.itemsByType = chain(this.notification?.items.items)
2734
.groupBy('itemType')
2835
.map((value, key) => ({ type: key, items: value }))

src/locale/properties/inbox/inbox.en.properties

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,3 +45,7 @@ inbox.youDontHaveUnarchived=You don't have any unarchived notifications right no
4545
inbox.youDontHave=You don’t have any notifications yet.
4646
inbox.archiveWithout=Archive without granting permissions
4747
inbox.professionalActivities=Professional activities
48+
inbox.connectWith=Connect with
49+
inbox.youCanBenefitFromAutomatic=You can benefit from automatic updates to your record. Based on your verified email domains we have found an ORCID integration for
50+
inbox.connectingWithThisIntegrationWillAllow=Connecting with this integration will allow
51+
inbox.toAutomaticallyAddValidatedInformation=to automatically add validated information to your ORCID record. This will save you time and effort when maintaining your record, and help make sure it stays up-to-date.

src/locale/properties/inbox/inbox.lr.properties

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,3 +49,7 @@ inbox.service=LR
4949
inbox.connectingYour=LR
5050
inbox.archiveWithout=LR
5151
inbox.professionalActivities=LR
52+
inbox.connectWith=LR
53+
inbox.youCanBenefitFromAutomatic=LR
54+
inbox.connectingWithThisIntegrationWillAllow=LR
55+
inbox.toAutomaticallyAddValidatedInformation=LR

src/locale/properties/inbox/inbox.rl.properties

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,3 +49,7 @@ inbox.service=RL
4949
inbox.connectingYour=RL
5050
inbox.archiveWithout=RL
5151
inbox.professionalActivities=RL
52+
inbox.connectWith=RL
53+
inbox.youCanBenefitFromAutomatic=RL
54+
inbox.connectingWithThisIntegrationWillAllow=RL
55+
inbox.toAutomaticallyAddValidatedInformation=RL

src/locale/properties/inbox/inbox.xx.properties

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,3 +49,7 @@ inbox.service=X
4949
inbox.connectingYour=X
5050
inbox.archiveWithout=X
5151
inbox.professionalActivities=X
52+
inbox.connectWith=X
53+
inbox.youCanBenefitFromAutomatic=X
54+
inbox.connectingWithThisIntegrationWillAllow=X
55+
inbox.toAutomaticallyAddValidatedInformation=X

0 commit comments

Comments
 (0)