9694-capture-affiliations-during-sign-in

Author: cryptalith

src/app/app.module.ts

@@ -39,7 +39,7 @@ import { FormsModule } from '@angular/forms'
     PseudoModule, // Remove on angular 10 https://bit.ly/3ezbF4v
     // Environmental dependent modules
     EnvironmentBannerModule,
-    FormsModule
+    FormsModule,
   ],
   providers: [
     TitleService,

src/app/authorize/pages/authorize/authorize.component.ts

@@ -73,7 +73,6 @@ export class AuthorizeComponent {
    */
   ngOnInit(): void {
     this.loading = true
-    
 
     forkJoin({
       platform: this.loadPlatformInfo(),

src/app/cdk/interstitials/affiliations-interstitial/interstitial-component/affiliations-interstitial.component.html

@@ -343,7 +343,9 @@
           class="orcid-logo"
         />
         <div class="published-domain">
-          <strong class="$orcid-custom-typography">{{ addedAffiliation?.affiliationName?.value }}</strong>
+          <strong class="$orcid-custom-typography">{{
+            addedAffiliation?.affiliationName?.value
+          }}</strong>
           <div>
             <small> {{ addedAffiliation?.departmentName?.value }} </small>
             <small

src/app/core/login-interstitials-manager/implementations/login-domain-interstitials-manager.service.ts

@@ -1,4 +1,4 @@
-import { Injectable, Type } from '@angular/core'
+import { Inject, Injectable, Type } from '@angular/core'
 import { Observable, of } from 'rxjs'
 
 import { InterstitialsService } from 'src/app/cdk/interstitials/interstitials.service'
@@ -40,7 +40,7 @@ export class LoginDomainInterstitialManagerService extends LoginBaseInterstitial
     interstitialsService: InterstitialsService,
     togglzService: TogglzService,
     qaFlagService: QaFlagsService,
-    @Inject(WINDOW) private _window: Window,
+    @Inject(WINDOW) private _window: Window
   ) {
     // Pass dependencies to the parent
     super(_matDialog, togglzService, interstitialsService, qaFlagService)
@@ -63,7 +63,12 @@ export class LoginDomainInterstitialManagerService extends LoginBaseInterstitial
     const hasNoPublicDomains = !this.userHasPublicDomains(userRecord.emails)
     const hasPrivateDomains = this.userHasPrivateDomains(userRecord.emails)
 
-    if (!hasNoPublicDomains || !hasPrivateDomains || isImpersonation || insidePopUpWindows) {
+    if (
+      !hasNoPublicDomains ||
+      !hasPrivateDomains ||
+      isImpersonation ||
+      insidePopUpWindows
+    ) {
       return of(false)
     }
     return of(true)
@@ -96,7 +101,3 @@ export class LoginDomainInterstitialManagerService extends LoginBaseInterstitial
     return ShareEmailsDomainsComponent
   }
 }
-function Inject(WINDOW: any): (target: typeof LoginDomainInterstitialManagerService, propertyKey: undefined, parameterIndex: 4) => void {
-  throw new Error('Function not implemented.')
-}
-

src/app/core/login-interstitials-manager/test/login-affiliation-interstitials-manager.service.spec.ts

@@ -13,6 +13,7 @@ import { QaFlagsService } from '../../qa-flag/qa-flag.service'
 import { QaFlag } from '../../qa-flag/qa-flags.enum'
 import { LoginAffiliationInterstitialManagerService } from '../implementations/login-affiliation-interstitials-manager.service'
 import { AffiliationsInterstitialDialogComponent } from 'src/app/cdk/interstitials/affiliations-interstitial/interstitial-dialog-extend/affiliations-interstitial-dialog.component'
+import { WINDOW_PROVIDERS } from 'src/app/cdk/window'
 
 describe('LoginAffiliationInterstitialManagerService', () => {
   let service: LoginAffiliationInterstitialManagerService
@@ -44,6 +45,7 @@ describe('LoginAffiliationInterstitialManagerService', () => {
         { provide: TogglzService, useValue: mockTogglzService },
         { provide: InterstitialsService, useValue: mockInterstitialsService },
         { provide: QaFlagsService, useValue: mockQaFlagsService },
+        WINDOW_PROVIDERS,
       ],
     })
 

src/app/core/login-interstitials-manager/test/login-domain-interstitials-manager.service.spec.ts

@@ -14,6 +14,8 @@ import { QaFlag } from '../../qa-flag/qa-flags.enum'
 import { TogglzService } from '../../togglz/togglz.service'
 import { LoginDomainInterstitialManagerService } from '../implementations/login-domain-interstitials-manager.service'
 import { ShareEmailsDomainsDialogComponent } from 'src/app/cdk/interstitials/share-emails-domains/interstitial-dialog-extend/share-emails-domains-dialog.component'
+import { inject } from '@angular/core'
+import { WINDOW_PROVIDERS } from 'src/app/cdk/window'
 
 describe('LoginDomainInterstitialManagerService', () => {
   let service: LoginDomainInterstitialManagerService
@@ -44,6 +46,7 @@ describe('LoginDomainInterstitialManagerService', () => {
         { provide: InterstitialsService, useValue: mockInterstitialsService },
         { provide: TogglzService, useValue: mockTogglzService },
         { provide: QaFlagsService, useValue: mockQaFlagsService },
+        WINDOW_PROVIDERS,
       ],
     })
 

src/app/core/qa-flag/qa-flag.service.ts

@@ -18,7 +18,9 @@ export class QaFlagsService {
     // we only do a simple localStorage check.
     const value = localStorage.getItem(flag)
     if (runtimeEnvironment.debugger && value) {
-      console.info(`[QAFlag] ⚠️ Caution you have "${flag}" is set to "${value}"`)
+      console.info(
+        `[QAFlag] ⚠️ Caution you have "${flag}" is set to "${value}"`
+      )
     }
     return value === 'true'
   }

src/app/core/record/record.service.ts

@@ -223,7 +223,8 @@ export class RecordService {
 
         if (allValuesLoaded) {
           if (this.getRecordPerformanceStartTime) {
-            const executionTime = performance.now() - this.getRecordPerformanceStartTime
+            const executionTime =
+              performance.now() - this.getRecordPerformanceStartTime
             this.getRecordPerformanceStartTime = undefined
             console.info(
               '[Record Service] :',