Merge pull request #2823 from ORCID/lmendoza/PD-0000hot-fix-switch-user-issues

PD-5489 hot-fix-switch-user-issues

Author: cryptalith

src/app/core/http/retry-transient.interceptor.ts

@@ -10,6 +10,7 @@ import { Observable, timer } from 'rxjs'
 import { retry } from 'rxjs/operators'
 
 const RETRYABLE_HTTP_STATUSES = new Set([0, 408, 502, 503, 504])
+const RETRYABLE_HTTP_METHODS = new Set(['GET', 'HEAD', 'OPTIONS'])
 const MAX_RETRIES = 2
 
 @Injectable()
@@ -18,6 +19,12 @@ export class RetryTransientInterceptor implements HttpInterceptor {
     req: HttpRequest<unknown>,
     next: HttpHandler
   ): Observable<HttpEvent<unknown>> {
+    // Retrying non-idempotent requests (e.g. switch-user POST) can trigger
+    // duplicate server-side actions and break account/session flows.
+    if (!RETRYABLE_HTTP_METHODS.has(req.method.toUpperCase())) {
+      return next.handle(req)
+    }
+
     return next.handle(req).pipe(
       retry({
         count: MAX_RETRIES,