PD-4978

Author: cryptalith

src/app/core/inbox/permission-notifications.service.spec.ts

@@ -322,18 +322,18 @@ describe('PermissionNotificationsService', () => {
     })
   })
 
-  it('should sort by sentDate descending', (done) => {
+  it('should sort by createdDate descending', (done) => {
     const perm1 = createPermissionNotification({
       putCode: 1,
-      sentDate: 1000,
+      createdDate: 1000,
       source: {
         sourceClientId: { path: 'client-a' } as any,
         sourceName: { content: 'A' },
       },
     })
     const perm2 = createPermissionNotification({
       putCode: 2,
-      sentDate: 3000,
+      createdDate: 3000,
       source: {
         sourceClientId: { path: 'client-b' } as any,
         sourceName: { content: 'B' },
@@ -346,8 +346,8 @@ describe('PermissionNotificationsService', () => {
     )
 
     service.loadUnreadPermissionNotifications(3).subscribe((result) => {
-      expect(result[0].sentDate).toBe(3000)
-      expect(result[1].sentDate).toBe(1000)
+      expect(result[0].createdDate).toBe(3000)
+      expect(result[1].createdDate).toBe(1000)
       done()
     })
   })

src/app/core/inbox/permission-notifications.service.ts

@@ -97,7 +97,11 @@ export class PermissionNotificationsService {
         (n): n is InboxNotificationPermission =>
           n?.notificationType === 'PERMISSION' && !n.readDate && !n.archivedDate
       )
-      .sort((a, b) => Number(b.createdDate || 0) - Number(a.createdDate || 0))
+      .sort(
+        (a, b) =>
+          new Date(b.createdDate || 0).getTime() -
+          new Date(a.createdDate || 0).getTime()
+      )
     const byClient = new Map<string, InboxNotificationPermission>()
     for (const n of unreadPermission) {
       const clientId = n?.source?.sourceClientId?.path
@@ -106,7 +110,9 @@ export class PermissionNotificationsService {
       if (!byClient.has(clientId)) byClient.set(clientId, n)
     }
     return Array.from(byClient.values()).sort(
-      (a, b) => Number(b.createdDate || 0) - Number(a.createdDate || 0)
+      (a, b) =>
+        new Date(b.createdDate || 0).getTime() -
+        new Date(a.createdDate || 0).getTime()
     )
   }
 }