Skip to content

Commit a8a8b2b

Browse files
authored
Merge branch 'main' into amontenegro/PD-5754
2 parents 9082f25 + 6d288ae commit a8a8b2b

10 files changed

Lines changed: 98 additions & 70 deletions

File tree

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
## v2.135.10 - 2026-06-17
2+
3+
[Full Changelog](https://github.com/ORCID/orcid-angular/compare/v2.135.9...v2.135.10)
4+
5+
- [#2863](https://github.com/ORCID/orcid-angular/pull/2863): PD-5389, PD-5402
6+
17
## v2.135.9 - 2026-06-16
28

39
[Full Changelog](https://github.com/ORCID/orcid-angular/compare/v2.135.8...v2.135.9)

projects/orcid-ui/src/lib/components/record-header/record-header.component.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -325,6 +325,11 @@
325325
min-width: 0;
326326
flex: 1; // Grow to fill space
327327

328+
// Keep Copy/Print actions close to the ORCID iD on desktop non-compact mode.
329+
.desktop:not(.compact) & {
330+
flex: 0 0 auto;
331+
}
332+
328333
.id-content {
329334
display: flex;
330335
align-items: center;

src/app/account-settings/components/settings-actions-duplicated/settings-actions-duplicated.component.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ <h4 title i18n>What happens when you remove a duplicate ORCID account?</h4>
5353
</ul>
5454
</app-alert-message>
5555
@if (authenticated) {
56-
<form [formGroup]="form" (ngSubmit)="onSubmit()">
56+
<form [formGroup]="form" (ngSubmit)="onSubmit()" autocomplete="off">
5757
<h3 i18n class="mb-2 mt-0">You are removing this duplicate account</h3>
5858
@if (data.deprecatingAccountName) {
5959
<p class="leading-5.25">{{ data.deprecatingAccountName }}</p>
@@ -82,7 +82,7 @@ <h3 i18n class="mb-2 mt-0">You are removing this duplicate account</h3>
8282
</button>
8383
</form>
8484
} @else {
85-
<form [formGroup]="form" (ngSubmit)="submitVerify()">
85+
<form [formGroup]="form" (ngSubmit)="submitVerify()" autocomplete="off">
8686
<h3 i18n class="mt-0 mb-2">Which account do you want to remove?</h3>
8787
<p i18n class="mb-8!">
8888
You will need to verify your sign in details for the duplicate account
@@ -108,7 +108,7 @@ <h3 i18n class="mt-0 mb-2">Which account do you want to remove?</h3>
108108
formControlName="deprecatingOrcidOrEmail"
109109
type="text"
110110
matInput
111-
autocomplete="email"
111+
autocomplete="off"
112112
[errorStateMatcher]="errorMatcher"
113113
id="cy-duplicate-rercod-email"
114114
/>
@@ -132,7 +132,7 @@ <h3 i18n class="mt-0 mb-2">Which account do you want to remove?</h3>
132132
formControlName="password"
133133
type="password"
134134
matInput
135-
autocomplete="password"
135+
autocomplete="new-password"
136136
[errorStateMatcher]="errorMatcher"
137137
id="cy-duplicate-rercod-email"
138138
/>

src/app/account-settings/components/settings-actions-duplicated/settings-actions-duplicated.component.ts

Lines changed: 20 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,11 @@
1-
import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core'
1+
import {
2+
Component,
3+
EventEmitter,
4+
Input,
5+
OnDestroy,
6+
OnInit,
7+
Output,
8+
} from '@angular/core'
29
import {
310
FormGroupDirective,
411
NgForm,
@@ -37,7 +44,7 @@ export class NeverShowErrorMatcher implements ErrorStateMatcher {
3744
preserveWhitespaces: true,
3845
standalone: false,
3946
})
40-
export class SettingsActionsDuplicatedComponent implements OnInit {
47+
export class SettingsActionsDuplicatedComponent implements OnInit, OnDestroy {
4148
errorMatcher = new NeverShowErrorMatcher()
4249
userSession: UserSession
4350
constructor(
@@ -121,7 +128,7 @@ export class SettingsActionsDuplicatedComponent implements OnInit {
121128
document.activeElement.blur()
122129
}
123130
this.loadingVerify = false
124-
this.form.reset()
131+
this.resetFormState()
125132
if (success) {
126133
this.authenticated = true
127134
} else {
@@ -169,7 +176,7 @@ export class SettingsActionsDuplicatedComponent implements OnInit {
169176

170177
if (data.success) {
171178
this.errors = []
172-
this.form.reset()
179+
this.resetFormState()
173180
this.success = true
174181
}
175182
if (data.errors?.length || !data.twoFactorToken) {
@@ -179,9 +186,17 @@ export class SettingsActionsDuplicatedComponent implements OnInit {
179186
},
180187
error: () => {
181188
this.cancelAuthentication = true
182-
this.form.reset()
189+
this.resetFormState()
183190
this.loading.next(false)
184191
},
185192
})
186193
}
194+
195+
ngOnDestroy(): void {
196+
this.resetFormState()
197+
}
198+
199+
private resetFormState(): void {
200+
this.form?.reset()
201+
}
187202
}

src/app/account-settings/components/settings-security-password/settings-security-password.component.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<app-settings-panels-data *ngIf="form">
2-
<form [formGroup]="form">
2+
<form [formGroup]="form" autocomplete="off">
33
@if (success) {
44
<app-alert-message type="success" class="mb-8">
55
<div content class="mt-0.5" i18n>
@@ -33,6 +33,7 @@
3333
matInput
3434
formControlName="oldPassword"
3535
type="password"
36+
autocomplete="new-password"
3637
[errorStateMatcher]="errorMatcher"
3738
[ngClass]="{
3839
error:

src/app/account-settings/components/settings-security-password/settings-security-password.component.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,7 @@ export class SettingsSecurityPasswordComponent implements OnInit, OnDestroy {
193193
return status
194194
}
195195
ngOnDestroy(): void {
196+
this.form?.reset()
196197
this.$destroy.next()
197198
this.$destroy.complete()
198199
}

src/locale/messages.lr.xlf

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565
</context-group>
6666
<context-group purpose="location">
6767
<context context-type="sourcefile">src/app/account-settings/components/settings-security-password/settings-security-password.component.html</context>
68-
<context context-type="linenumber">51,53</context>
68+
<context context-type="linenumber">52,54</context>
6969
</context-group>
7070
<target>LR</target>
7171
</trans-unit>
@@ -836,7 +836,7 @@
836836
<source>for</source>
837837
<context-group purpose="location">
838838
<context context-type="sourcefile">src/app/account-settings/components/settings-actions-duplicated/settings-actions-duplicated.component.ts</context>
839-
<context context-type="linenumber">52</context>
839+
<context context-type="linenumber">59</context>
840840
</context-group>
841841
<context-group purpose="location">
842842
<context context-type="sourcefile">src/app/reset-password/reset-password/reset-password.component.ts</context>
@@ -848,7 +848,7 @@
848848
<source>to continue removing a duplicate account</source>
849849
<context-group purpose="location">
850850
<context context-type="sourcefile">src/app/account-settings/components/settings-actions-duplicated/settings-actions-duplicated.component.ts</context>
851-
<context context-type="linenumber">53</context>
851+
<context context-type="linenumber">60</context>
852852
</context-group>
853853
<target>LR</target>
854854
</trans-unit>
@@ -1370,31 +1370,31 @@
13701370
<source>New password</source>
13711371
<context-group purpose="location">
13721372
<context context-type="sourcefile">src/app/account-settings/components/settings-security-password/settings-security-password.component.html</context>
1373-
<context context-type="linenumber">73</context>
1373+
<context context-type="linenumber">74</context>
13741374
</context-group>
13751375
<target>LR</target>
13761376
</trans-unit>
13771377
<trans-unit id="shared.passwordCantBeEmpty" datatype="html" resname="shared.passwordCantBeEmpty">
13781378
<source>Password cannot be empty</source>
13791379
<context-group purpose="location">
13801380
<context context-type="sourcefile">src/app/account-settings/components/settings-security-password/settings-security-password.component.html</context>
1381-
<context context-type="linenumber">112,114</context>
1381+
<context context-type="linenumber">113,115</context>
13821382
</context-group>
13831383
<target>LR</target>
13841384
</trans-unit>
13851385
<trans-unit id="register.wrongPasswordPatternV2" datatype="html" resname="register.wrongPasswordPatternV2">
13861386
<source>Password must meet all requirements</source>
13871387
<context-group purpose="location">
13881388
<context context-type="sourcefile">src/app/account-settings/components/settings-security-password/settings-security-password.component.html</context>
1389-
<context context-type="linenumber">124,126</context>
1389+
<context context-type="linenumber">125,127</context>
13901390
</context-group>
13911391
<target>LR</target>
13921392
</trans-unit>
13931393
<trans-unit id="register.passwordCantBeEmail" datatype="html" resname="register.passwordCantBeEmail">
13941394
<source>Password must not be the same as your email address</source>
13951395
<context-group purpose="location">
13961396
<context context-type="sourcefile">src/app/account-settings/components/settings-security-password/settings-security-password.component.html</context>
1397-
<context context-type="linenumber">131,133</context>
1397+
<context context-type="linenumber">132,134</context>
13981398
</context-group>
13991399
<context-group purpose="location">
14001400
<context context-type="sourcefile">src/app/register/components/form-password/form-password.component.html</context>
@@ -1410,15 +1410,15 @@
14101410
<source>Password must be between 8 and 256 characters</source>
14111411
<context-group purpose="location">
14121412
<context context-type="sourcefile">src/app/account-settings/components/settings-security-password/settings-security-password.component.html</context>
1413-
<context context-type="linenumber">139,141</context>
1413+
<context context-type="linenumber">140,142</context>
14141414
</context-group>
14151415
<target>LR</target>
14161416
</trans-unit>
14171417
<trans-unit id="register.passwordConfirmationRequired" datatype="html" resname="register.passwordConfirmationRequired">
14181418
<source>Retype your password</source>
14191419
<context-group purpose="location">
14201420
<context context-type="sourcefile">src/app/account-settings/components/settings-security-password/settings-security-password.component.html</context>
1421-
<context context-type="linenumber">192,194</context>
1421+
<context context-type="linenumber">193,195</context>
14221422
</context-group>
14231423
<context-group purpose="location">
14241424
<context context-type="sourcefile">src/app/register/components/form-password/form-password.component.html</context>
@@ -1430,15 +1430,15 @@
14301430
<source>Passwords do not match</source>
14311431
<context-group purpose="location">
14321432
<context context-type="sourcefile">src/app/account-settings/components/settings-security-password/settings-security-password.component.html</context>
1433-
<context context-type="linenumber">203,205</context>
1433+
<context context-type="linenumber">204,206</context>
14341434
</context-group>
14351435
<target>LR</target>
14361436
</trans-unit>
14371437
<trans-unit id="register.yourPasswordHas" datatype="html" resname="register.yourPasswordHas">
14381438
<source>Your password has:</source>
14391439
<context-group purpose="location">
14401440
<context context-type="sourcefile">src/app/account-settings/components/settings-security-password/settings-security-password.component.html</context>
1441-
<context context-type="linenumber">209</context>
1441+
<context context-type="linenumber">210</context>
14421442
</context-group>
14431443
<context-group purpose="location">
14441444
<context context-type="sourcefile">src/app/register/components/form-password/form-password.component.html</context>
@@ -1450,7 +1450,7 @@
14501450
<source>8 or more characters</source>
14511451
<context-group purpose="location">
14521452
<context context-type="sourcefile">src/app/account-settings/components/settings-security-password/settings-security-password.component.html</context>
1453-
<context context-type="linenumber">215</context>
1453+
<context context-type="linenumber">216</context>
14541454
</context-group>
14551455
<context-group purpose="location">
14561456
<context context-type="sourcefile">src/app/register/components/form-password/form-password.component.html</context>
@@ -1462,7 +1462,7 @@
14621462
<source>At least 1 letter or symbol</source>
14631463
<context-group purpose="location">
14641464
<context context-type="sourcefile">src/app/account-settings/components/settings-security-password/settings-security-password.component.html</context>
1465-
<context context-type="linenumber">221,223</context>
1465+
<context context-type="linenumber">222,224</context>
14661466
</context-group>
14671467
<context-group purpose="location">
14681468
<context context-type="sourcefile">src/app/register/components/form-password/form-password.component.html</context>
@@ -1474,7 +1474,7 @@
14741474
<source>At least 1 number</source>
14751475
<context-group purpose="location">
14761476
<context context-type="sourcefile">src/app/account-settings/components/settings-security-password/settings-security-password.component.html</context>
1477-
<context context-type="linenumber">229</context>
1477+
<context context-type="linenumber">230</context>
14781478
</context-group>
14791479
<context-group purpose="location">
14801480
<context context-type="sourcefile">src/app/register/components/form-password/form-password.component.html</context>
@@ -1486,7 +1486,7 @@
14861486
<source>Save changes</source>
14871487
<context-group purpose="location">
14881488
<context context-type="sourcefile">src/app/account-settings/components/settings-security-password/settings-security-password.component.html</context>
1489-
<context context-type="linenumber">240,242</context>
1489+
<context context-type="linenumber">241,243</context>
14901490
</context-group>
14911491
<context-group purpose="location">
14921492
<context context-type="sourcefile">src/app/cdk/side-bar/modals/modal-country/modal-country.component.html</context>

0 commit comments

Comments
 (0)