PD-4790 fix control names

Author: aromanovv

projects/orcid-ui/src/lib/components/auth-challenge/auth-challenge.component.ts

@@ -52,8 +52,9 @@ class ErrorStateMatcherForTwoFactorFields implements ErrorStateMatcher {
   ],
 })
 export class AuthChallengeComponent implements OnInit, OnDestroy {
-  @Input() codeControlName = 'twoFactorCodeControl'
-  @Input() recoveryControlName = 'twoFactorRecoveryCodeControl'
+  @Input() codeControlName = 'twoFactorCode'
+  @Input() recoveryControlName = 'twoFactorRecoveryCode'
+  // has "control" in the name to avoid conflicts with account settings password reset form which has the password field/control
   @Input() passwordControlName = 'passwordControl'
   @Input() showAlert = false
   @Input() showHelpText = true

src/app/account-settings/components/settings-security-password/settings-security-password.component.html

@@ -229,8 +229,6 @@
     @if (twoFactorState) {
     <app-auth-challenge
       class="w-[537px] block mb-8"
-      codeControlName="twoFactorCode"
-      recoveryControlName="twoFactorRecoveryCode"
       [showPasswordField]="false"
       [showAlert]="true"
       [showTwoFactorField]="true"