PD-6016 repair the six specs that discovery had been hiding

Turning spec discovery back on surfaced six component specs that had
never run. They fail identically on 20.1.6, so none of this is fallout
from the upgrade; they simply rotted unobserved.

Most were missing TestBed imports for what their templates actually use:
MatFormField/MatInput for mat-form-field and the errorStateMatcher
binding, MatCard/MatCheckbox for the interstitial, ReactiveFormsModule
for [formGroup], and CUSTOM_ELEMENTS_SCHEMA where a template renders a
sibling app-* component. Real modules rather than NO_ERRORS_SCHEMA, so
the specs keep catching template errors.

Two specs stubbed FormBuilder with object literals that only looked like
form controls. They passed only because ReactiveFormsModule was absent
and the bindings were never evaluated; with the directives present they
have to be real, so use the actual FormBuilder. ShareEmailsDomains also
needed a record carrying emailDomains, since the component builds its
form inside a filtered subscription and an empty record left formGroup
bound to undefined.

Author: cryptalith

src/app/account-settings/components/settings-actions-duplicated/settings-actions-duplicated.component.spec.ts

@@ -15,6 +15,9 @@ import { UserService } from '../../../core'
 import { AccountActionsDuplicatedService } from '../../../core/account-actions-duplicated/account-actions-duplicated.service'
 
 import { CUSTOM_ELEMENTS_SCHEMA } from '@angular/core'
+import { MatFormFieldModule } from '@angular/material/form-field'
+import { MatInputModule } from '@angular/material/input'
+import { NoopAnimationsModule } from '@angular/platform-browser/animations'
 
 describe('SettingsActionsDuplicatedComponent', () => {
   let component: SettingsActionsDuplicatedComponent
@@ -27,6 +30,9 @@ describe('SettingsActionsDuplicatedComponent', () => {
         MatDialogModule,
         RouterTestingModule,
         ReactiveFormsModule,
+        MatFormFieldModule,
+        MatInputModule,
+        NoopAnimationsModule,
       ],
       declarations: [SettingsActionsDuplicatedComponent],
       providers: [

src/app/account-settings/components/settings-security-password/settings-security-password.component.spec.ts

@@ -13,14 +13,27 @@ import { Overlay } from '@angular/cdk/overlay'
 import { RouterTestingModule } from '@angular/router/testing'
 
 import { CUSTOM_ELEMENTS_SCHEMA } from '@angular/core'
+import { ReactiveFormsModule } from '@angular/forms'
+import { MatFormFieldModule } from '@angular/material/form-field'
+import { MatInputModule } from '@angular/material/input'
+import { MatIconModule } from '@angular/material/icon'
+import { NoopAnimationsModule } from '@angular/platform-browser/animations'
 
 describe('SettingsSecurityPasswordComponent', () => {
   let component: SettingsSecurityPasswordComponent
   let fixture: ComponentFixture<SettingsSecurityPasswordComponent>
 
   beforeEach(async () => {
     await TestBed.configureTestingModule({
-      imports: [HttpClientTestingModule, RouterTestingModule],
+      imports: [
+        HttpClientTestingModule,
+        ReactiveFormsModule,
+        RouterTestingModule,
+        MatFormFieldModule,
+        MatInputModule,
+        MatIconModule,
+        NoopAnimationsModule,
+      ],
       declarations: [SettingsSecurityPasswordComponent],
       providers: [
         WINDOW_PROVIDERS,

src/app/cdk/deep-select-input/deep-select-input/deep-select-input.component.spec.ts

@@ -2,10 +2,15 @@ import { ComponentFixture, TestBed } from '@angular/core/testing'
 
 import { DeepSelectInputComponent } from './deep-select-input.component'
 import { PlatformInfoService } from '../../platform-info'
-import { FormBuilder } from '@angular/forms'
+import { FormBuilder, ReactiveFormsModule } from '@angular/forms'
 import { get } from 'lodash'
 import { of } from 'rxjs'
 import { MatMenuModule } from '@angular/material/menu'
+import { MatFormFieldModule } from '@angular/material/form-field'
+import { MatInputModule } from '@angular/material/input'
+import { MatIconModule } from '@angular/material/icon'
+import { MatDividerModule } from '@angular/material/divider'
+import { NoopAnimationsModule } from '@angular/platform-browser/animations'
 
 describe('DeepSelectInputComponent', () => {
   let component: DeepSelectInputComponent
@@ -21,18 +26,16 @@ describe('DeepSelectInputComponent', () => {
             get: () => of({}),
           },
         },
-        {
-          provide: FormBuilder,
-          useValue: {
-            group: () => ({
-              get: () => ({
-                valueChanges: of(''),
-              }),
-            }),
-          },
-        },
       ],
-      imports: [MatMenuModule],
+      imports: [
+        MatMenuModule,
+        ReactiveFormsModule,
+        MatFormFieldModule,
+        MatInputModule,
+        MatIconModule,
+        MatDividerModule,
+        NoopAnimationsModule,
+      ],
     })
     fixture = TestBed.createComponent(DeepSelectInputComponent)
     component = fixture.componentInstance

src/app/cdk/interstitials/share-emails-domains/interstitial-component/share-emails-domains.component.spec.ts

@@ -1,10 +1,19 @@
 import { ComponentFixture, TestBed } from '@angular/core/testing'
 
 import { ShareEmailsDomainsComponent } from './share-emails-domains.component'
-import { FormBuilder, FormControl, FormGroup } from '@angular/forms'
+import {
+  FormBuilder,
+  FormControl,
+  FormGroup,
+  ReactiveFormsModule,
+} from '@angular/forms'
 import { RecordEmailsService } from 'src/app/core/record-emails/record-emails.service'
 
 import { CUSTOM_ELEMENTS_SCHEMA } from '@angular/core'
+import { MatCardModule } from '@angular/material/card'
+import { MatCheckboxModule } from '@angular/material/checkbox'
+import { MatDividerModule } from '@angular/material/divider'
+import { MatIconModule } from '@angular/material/icon'
 import { UserService } from 'src/app/core'
 import { PlatformInfoService } from 'src/app/cdk/platform-info/platform-info.service'
 import { WINDOW_PROVIDERS } from 'src/app/cdk/window'
@@ -18,18 +27,18 @@ describe('ShareEmailsDomainsComponent', () => {
   beforeEach(() => {
     TestBed.configureTestingModule({
       declarations: [ShareEmailsDomainsComponent],
+      imports: [
+        MatCardModule,
+        ReactiveFormsModule,
+        MatCheckboxModule,
+        MatDividerModule,
+        MatIconModule,
+      ],
       providers: [
         {
           provide: PlatformInfoService,
           useValue: {},
         },
-        {
-          provide: FormBuilder,
-          useValue: {
-            array: () => [new FormControl({})],
-            group: () => new FormGroup({}),
-          },
-        },
         {
           provide: RecordEmailsService,
           useValue: {},
@@ -47,7 +56,21 @@ describe('ShareEmailsDomainsComponent', () => {
         {
           provide: RecordService,
           useValue: {
-            getRecord: () => of({}),
+            // The component only builds its form once a record carrying
+            // emailDomains arrives, so an empty record leaves `form` undefined
+            // and `[formGroup]` with nothing to bind to.
+            getRecord: () =>
+              of({
+                emails: {
+                  emailDomains: [
+                    {
+                      value: 'example.org',
+                      visibility: 'PRIVATE',
+                      createdDate: { timestamp: 1 },
+                    },
+                  ],
+                },
+              }),
           },
         },
         WINDOW_PROVIDERS,

src/app/page-not-found-404/page-not-found/page-not-found.component.spec.ts

@@ -1,6 +1,7 @@
 import { ComponentFixture, TestBed } from '@angular/core/testing'
 
 import { PageNotFoundComponent } from './page-not-found.component'
+import { CUSTOM_ELEMENTS_SCHEMA } from '@angular/core'
 
 describe('PageNotFoundComponent', () => {
   let component: PageNotFoundComponent
@@ -9,6 +10,7 @@ describe('PageNotFoundComponent', () => {
   beforeEach(() => {
     TestBed.configureTestingModule({
       declarations: [PageNotFoundComponent],
+      schemas: [CUSTOM_ELEMENTS_SCHEMA],
     })
     fixture = TestBed.createComponent(PageNotFoundComponent)
     component = fixture.componentInstance

src/app/record/components/work-details/work-details.component.spec.ts

@@ -8,6 +8,7 @@ import { SnackbarService } from 'src/app/cdk/snackbar/snackbar.service'
 import { MatDialog } from '@angular/material/dialog'
 import { MatSnackBar } from '@angular/material/snack-bar'
 import { MonthDayYearDateToStringPipe } from 'src/app/shared/pipes/month-day-year-date-to-string/month-day-year-date-to-string.pipe'
+import { CUSTOM_ELEMENTS_SCHEMA } from '@angular/core'
 
 describe('WorkDetailsComponent', () => {
   let component: WorkDetailsComponent
@@ -18,6 +19,7 @@ describe('WorkDetailsComponent', () => {
       imports: [HttpClientTestingModule, RouterTestingModule],
       declarations: [WorkDetailsComponent, MonthDayYearDateToStringPipe],
       providers: [WINDOW_PROVIDERS, SnackbarService, MatSnackBar, MatDialog],
+      schemas: [CUSTOM_ELEMENTS_SCHEMA],
     })
     fixture = TestBed.createComponent(WorkDetailsComponent)
     component = fixture.componentInstance