Skip to content

Commit 2811f89

Browse files
author
George Nash
committed
added debugging for fetching member sf data
1 parent dad3c88 commit 2811f89

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

member-service-2/src/main/java/org/orcid/mp/member/client/SalesforceClient.java

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ public class SalesforceClient {
5050
private RestClient restClient;
5151

5252
public MemberDetails getMemberDetails(String salesforceId) throws IOException {
53+
LOG.debug("Fetching member details from salesforce...");
5354
return request(() -> getSFMemberDetails(salesforceId));
5455
}
5556

@@ -66,6 +67,7 @@ public MemberOrgIds getMemberOrgIds(String salesforceId) throws IOException {
6667
}
6768

6869
public ConsortiumLeadDetails getConsortiumLeadDetails(String salesforceId) throws IOException {
70+
LOG.debug("Fetching consortium lead member details from salesforce...");
6971
return request(() -> getSFConsortiumLeadDetails(salesforceId));
7072
}
7173

@@ -85,7 +87,9 @@ private Boolean updateSFPublicMemberDetails(MemberUpdateData memberUpdateData) {
8587
}
8688

8789
private MemberDetails getSFMemberDetails(String salesforceId) {
88-
return get("/member/" + salesforceId + "/details", new ParameterizedTypeReference<MemberDetails>() {
90+
String path = "/member/" + salesforceId + "/details";
91+
LOG.debug("Fetching member details for path {}", path);
92+
return get(path, new ParameterizedTypeReference<MemberDetails>() {
8993
});
9094
}
9195

@@ -105,7 +109,9 @@ private ConsortiumLeadDetails getSFConsortiumLeadDetails(String salesforceId) {
105109
}
106110

107111
private <T> T get(String path, ParameterizedTypeReference<T> typeReference) {
108-
ResponseEntity<T> response = restClient.get().uri(salesforceClientEndpoint + path).headers(httpHeaders -> httpHeaders.setBearerAuth(accessToken.get())).retrieve().toEntity(typeReference);
112+
String url = salesforceClientEndpoint + path;
113+
LOG.debug("Sending salesforce GET request to {}", path);
114+
ResponseEntity<T> response = restClient.get().uri(path).headers(httpHeaders -> httpHeaders.setBearerAuth(accessToken.get())).retrieve().toEntity(typeReference);
109115
return processResponse(response, path);
110116
}
111117

@@ -121,6 +127,9 @@ private <T> T processResponse(ResponseEntity<T> response, String path) {
121127
LOG.info("Response code is {}", statusCode.toString());
122128
LOG.info("Response body is {}", response.getBody() != null ? response.getBody().toString() : "<empty>");
123129
return null;
130+
} else if (LOG.isDebugEnabled()) {
131+
LOG.debug("Received 200 response for {}", path);
132+
LOG.debug("Response body is ", response.getBody().toString());
124133
}
125134
return response.getBody();
126135
}

member-service-2/src/main/java/org/orcid/mp/member/service/MemberService.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -224,6 +224,7 @@ public Optional<Member> getAuthorizedMemberForUser(String state) {
224224
}
225225

226226
public MemberDetails getMemberDetails(String salesforceId) throws UnauthorizedMemberAccessException {
227+
LOG.debug("Fetching salesforce data for {}...", salesforceId);
227228
validateUserAccess(salesforceId);
228229
Member member = memberRepository.findBySalesforceId(salesforceId).orElseThrow();
229230
try {

0 commit comments

Comments
 (0)