gh-pages does not find owasp-td-jekyll theme

[jgadsden]

Describe the bug:
We are building gh-pages for eventual publication at CNAME, but get error when building :

Logging at level: debug
Configuration file: /github/workspace/./docs/_config.yml
Theme: owasp-td-jekyll
github-pages 232 Error: The owasp-td-jekyll theme could not be found. 

Note that the build works correctly at all other times, just when auto-creating gh-pages branch

UPDATE: this is due to owasp-td-jekyll not being one of the Github Pages supported themes

Expected behaviour:
gh-pages builds successfully on changes to docs directory

Environment:

• Version: 2.4.1
• Platform: Docs
• OS: N/A
• Browser: N/A

To Reproduce:
see pages-build-deployment actions :
https://github.com/OWASP/threat-dragon/actions/workflows/pages/pages-build-deployment

Any additional context, screenshots, etc:
once this is working then we can use the subdomain held in CNAME
this can provide a mirror for the existing docs at https://www.threatdragon.com/docs/

[jgadsden]

Hello @lreading , this only happens for the gh-pages jekyll build, every other build of docs finds the owasp-td-jekyll theme just fine

[jgadsden]

This may be some incompatibility between github-pages 232 and previous version?
https://github.com/orgs/community/discussions/142149

but more likely it is an issue that is gh-pages specific, comment in docs/Gemfile:

# If you want to use GitHub Pages, remove the "gem "jekyll"" above and
# uncomment the line below. To upgrade, run `bundle update github-pages`.
# gem "github-pages", group: :jekyll_plugins
# If you have any plugins, put them here!
group :jekyll_plugins do
  gem "jekyll-feed", "~> 0.17"
end