Possible loss of diagram changes

[kfabjans]

Describe the bug:
When using the Menu Bar options Save or Save As in OWASP Threat Dragon, the threat modeling diagram is not saved. This can lead to significant data loss, especially for teams collaborating on models.
However, using the built-in Save button (next to the Close button in the app) correctly saves the current work.

Expected behaviour:
Selecting Save or Save As from the menu bar should persist the current threat model diagram to the chosen file or location, just like the built-in Save button does.

Environment:

• Version: 2.5.0
• Platform: Desktop App
• OS: macOS 26.0.1 (Tahoe) and Windows 11
• Browser: N/A (Desktop app issue)

To Reproduce:

1. Open OWASP Threat Dragon Desktop App.
2. Create or edit a threat modeling diagram.
3. From the Menu Bar, click File → Save or File → Save As.
4. Close and reopen the diagram.
5. Observe that changes were not saved.

Any additional context, screenshots, etc:

[jgadsden]

Thanks for the bug report @kfabjans , this may be related to #1331

[jgadsden]

Hello @kfabjans , can you confirm that you are using the latest version: v2.5.0
This works as expected because it was the subject of PR #1331

Can you provide a step-by-step of how you make it not do as expected?

[kfabjans]

I do confirm I am using v2.5.0. Steps that I have used to reproduce are:

1. Open OWASP Threat Dragon Desktop App.
2. Edit an existing threat modeling diagram.
3. Make simple modification, for example add one more threat entry
4. From the Menu Bar, click File → Save or File → Save As.
5. Close and reopen the diagram.
6. Observe that changes were not saved.

[Litti11]

I can reproduce this (Windows 11, V2.5.0).
Definitly a very annoying bug.

[jgadsden]

@Litti11 you are definitely saving the file before closing the model? Not cancelling or exiting early?

[Litti11]

Dear @jgadsden:

yes, I am trying to save via File → Save or File → Save As, as described by @kfabjans.
No cancel or exit or alike.
A dialog box appears "Threat model succesfully saved" and disappears automatically.
After some time I close the model or exit the application and open it again, but the last changes before saving are gone.

Note: If using the Save button, saving works.

If I create a simple model from scratch, File → Save and File → Save As do work.

I guess that model complexity or some model property cause the issue.

Can you please try to reproduce using this model:

ThreatModel_dummy_final5.json

When I create a new threat for Store_005 in the model "DummyDevice Dummy Person", File → Save or File → Save As won't save the new threat, while button Save does.

[jgadsden]

Hello @Litti11 , I tried your model and I also have the new threat missing from the model
the model itself is correctly saved as the threatTop value is incremented:

<     "threatTop": 153
---
>     "threatTop": 154

but the threat itself is missing
so this confirms what you see, but does not provide an explanation