catch error during createOrder

Author: mariolorenz

src/Controller/ProxyController.php

@@ -93,7 +93,7 @@ public function createOrder(): void
             false
         );
 
-        if ($response->id) {
+        if ($response && $response->id) {
             PayPalSession::storePayPalOrderId($response->id);
         }
 
@@ -165,6 +165,9 @@ public function createGooglePayOrder(): void
             false
         );
 
+        if (!$response) {
+            return;
+        }
         if ($response->id) {
             PayPalSession::storePayPalOrderId($response->id);
         }
@@ -198,7 +201,7 @@ public function createGooglePayOrder(): void
             /** @var array $userInvoiceAddress */
             $userInvoiceAddress = $user->getInvoiceAddress();
             // add PayPal-Address as Delivery-Address
-            if (($response !== null) && !empty($response->purchase_units[0]->shipping)) {
+            if (!empty($response->purchase_units[0]->shipping)) {
                 $response->purchase_units[0]->shipping->address = $shippingAddress;
                 $response->purchase_units[0]->shipping->name->full_name = $data['shippingAddress']['name'] ?? '';
                 $deliveryAddress = PayPalAddressResponseToOxidAddress::mapUserDeliveryAddress($response);
@@ -547,6 +550,11 @@ public function createApplepayOrder()
             null,
             false
         );
+
+        if (!$response) {
+            return;
+        }
+
         if ($response->id) {
             PayPalSession::storePayPalOrderId($response->id);
         }

src/Service/Payment.php

@@ -113,7 +113,7 @@ public function doCreatePayPalOrder(
         string $returnUrl = null,
         string $cancelUrl = null,
         bool $setProvidedAddress = true
-    ): Order {
+    ): ?Order {
         //TODO return value
         $this->setPaymentExecutionError(self::PAYMENT_ERROR_NONE);
 
@@ -133,7 +133,7 @@ public function doCreatePayPalOrder(
             $setProvidedAddress
         );
 
-        $response = [];
+        $response = null;
 
         try {
             $response = $orderService->createOrder(
@@ -172,8 +172,13 @@ public function doCreatePatchedOrder(
             false
         );
 
-        $paypalOrderId = $response->id ?: '';
-        $status = $response->status ?: '';
+        $paypalOrderId = '';
+        $status = '';
+
+        if ($response) {
+            $paypalOrderId = $response->id ?: '';
+            $status = $response->status ?: '';
+        }
 
         // patch the order only if paypalOrderId exists
         if ($paypalOrderId) {
@@ -583,7 +588,10 @@ public function doExecuteStandardPayment(
             false
         );
 
-        $orderId = $response->id ?: '';
+        $orderId = '';
+        if ($response) {
+            $orderId = $response->id ?: '';
+        }
 
         if (!$orderId) {
             $this->setPaymentExecutionError(self::PAYMENT_ERROR_GENERIC);
@@ -632,7 +640,11 @@ public function doCreateUAPMOrder(EshopModelBasket $basket): string
             false
         );
 
-        return $response->id ?: '';
+        $result = '';
+        if ($response) {
+            $result = $response->id ?: '';
+        }
+        return $result;
     }
 
     public function doExecutePuiPayment(
@@ -642,6 +654,7 @@ public function doExecutePuiPayment(
     ): bool {
         $this->setPaymentExecutionError(self::PAYMENT_ERROR_NONE);
 
+        $payPalOrderId = '';
         try {
             $result = $this->doCreatePayPalOrder(
                 $basket,
@@ -652,7 +665,9 @@ public function doExecutePuiPayment(
                 $payPalClientMetadataId,
                 Constants::PAYPAL_PARTNER_ATTRIBUTION_ID_PPCP
             );
-            $payPalOrderId = $result->id;
+            if ($result) {
+                $payPalOrderId = $result->id;
+            }
         } catch (Exception $exception) {
             $this->setPaymentExecutionError(self::PAYMENT_ERROR_PUI_GENERIC);
             $this->logger->log('error', 'Error on pui order creation call.', [$exception]);