multilanguage handling for oxshop-vars

[BattleMoench]

we have insufficient handling for multilanguage fields in oxshops. Looks like a bug.

line 207ff in class oxid_modules_config/Core/ConfigImport.php; method importShopsConfig

for ($i = 1; $i <= 3; $i++) { $oShop->setLanguage($i); foreach ($aOxShopSettings as $sVarName => $mVarValue) { $iPosLastChar = strlen($sVarName) - 1; $iPosUnderscore = $iPosLastChar - 1; if ($sVarName[$iPosUnderscore] == '_' && $sVarName[$iPosLastChar] == $i) { $sFiledName = substr($sVarName, 0, strlen($sVarName) - 2); $aOxShopSettings[$sFiledName] = $mVarValue; } } $oShop->assign($aOxShopSettings); $oShop->save(); }

[alfredbez]

This is more readable:

oxid_modules_config/Core/ConfigImport.php

Lines 207 to 219 in d01f87a

	for ($i = 1; $i <= 3; $i++) {
	$oShop->setLanguage($i);
	foreach ($aOxShopSettings as $sVarName => $mVarValue) {
	$iPosLastChar = strlen($sVarName) - 1;
	$iPosUnderscore = $iPosLastChar - 1;
	if ($sVarName[$iPosUnderscore] == '_' && $sVarName[$iPosLastChar] == $i) {
	$sFiledName = substr($sVarName, 0, strlen($sVarName) - 2);
	$aOxShopSettings[$sFiledName] = $mVarValue;
	}
	}
	$oShop->assign($aOxShopSettings);
	$oShop->save();
	}

[keywan-ghadami-oxid]

I think the loop should loop over all languages instead only going from 0-3, or does anyone see a issue with that?