Skip to content

Commit 160ed60

Browse files
committed
Allow long filenames for BFT
1 parent b7337b8 commit 160ed60

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

octoprint_firmwareupdater/static/js/firmwareupdater.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -643,7 +643,7 @@ $(function() {
643643
}
644644

645645
if (self.getProfileSetting("flash_method") == "marlinbft" && self.getProfileSetting("marlinbft_use_custom_filename") && !self.checkMarlinBftCustomFileName()) {
646-
alert = gettext("The target filename is invalid. Filename must be 8dot3 format.");
646+
alert = gettext("The target filename is invalid.");
647647
}
648648

649649
if (!self.flashPort() &! self.getProfileSetting("flash_method") == "dfuprogrammer") {
@@ -1326,7 +1326,7 @@ $(function() {
13261326

13271327
self.checkMarlinBftCustomFileName = function() {
13281328
var filename = self.getProfileSetting("marlinbft_custom_filename")
1329-
var filenamePattern = new RegExp("^[A-z0-9_-]{1,8}\\.[A-z0-9]{1,3}$");
1329+
var filenamePattern = new RegExp("^[A-z0-9_-]{1,}\\.[A-z0-9]{1,3}$");
13301330
return filenamePattern.test(filename);
13311331
}
13321332

octoprint_firmwareupdater/templates/firmwareupdater_settings.jinja2

+1-1
Original file line numberDiff line numberDiff line change
@@ -547,7 +547,7 @@
547547
<input type="text" class="input-block-level" data-bind='value: configMarlinBftCustomFilename, enable: configMarlinBftUseCustomFilename, valueUpdate: "afterkeydown"'>
548548
<button class="btn" type="button" data-bind="click: resetMarlinBftCustomFilename, enable: configMarlinBftUseCustomFilename">{{ _('Reset') }}</button>
549549
</div>
550-
<span class="help-block">{{ _('Firmware file will be saved on the printer using the specified name. Filename must be in <a href=https://en.wikipedia.org/wiki/8.3_filename>8dot3 format</a> (up 8 character name, up to 3 character extension).') }}</span>
550+
<span class="help-block">{{ _('Firmware file will be saved on the printer using the specified name.') }}</span>
551551
</div>
552552
</div>
553553
</div>

0 commit comments

Comments
 (0)