Read in submodule

caitlynstocker · caitlynstocker · commit f395321d484a · 2026-03-24T16:42:26.000+10:00
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -32,6 +32,7 @@ jobs:
       - uses: actions/checkout@v6
         with:
           fetch-depth: 0 # all
+          submodules: 'true'
 
       - name: Build, Test, Pack, and Deploy (CI)
         uses: ./.github/actions/build-test-pack-deploy
diff --git a/.gitmodules b/.gitmodules
@@ -0,0 +1,3 @@
+[submodule "specification"]
+	path = specification
+	url = https://github.com/OctopusDeploy/openfeature-provider-specification.git
diff --git a/specification b/specification
@@ -0,0 +1 @@
+Subproject commit 57495a9dc1155e4c079aba1b91663a4ee501dca7
diff --git a/src/Octopus.OpenFeature.Provider.SpecificationTests/Cases.cs b/src/Octopus.OpenFeature.Provider.SpecificationTests/Cases.cs
@@ -1,7 +1,7 @@
 using System.Collections;
 using System.Text.Json;
 
-namespace Octopus.OpenFeature.Provider.IntegrationTests;
+namespace Octopus.OpenFeature.Provider.SpecificationTests;
 
 public class Cases : IEnumerable<object[]>
 {
@@ -43,7 +43,7 @@ FixtureExpected Expected
 
 public record FixtureConfiguration(string Slug,
     bool DefaultValue,
-    Dictionary<string, string> Context
+    Dictionary<string, string>? Context
 );
 
 public record FixtureExpected(
diff --git a/src/Octopus.OpenFeature.Provider.SpecificationTests/FixtureEvaluationTests.cs b/src/Octopus.OpenFeature.Provider.SpecificationTests/FixtureEvaluationTests.cs
@@ -4,7 +4,7 @@
 using OpenFeature.Constant;
 using OpenFeature.Model;
 
-namespace Octopus.OpenFeature.Provider.IntegrationTests;
+namespace Octopus.OpenFeature.Provider.SpecificationTests;
 
 public class FixtureEvaluationTests(Server server) : IClassFixture<Server>
 {
@@ -32,9 +32,11 @@ public async Task Evaluate(string testResponse, FixtureCase testCase)
         result.ErrorType.Should().Be(MapErrorCode(testCase.Expected.ErrorCode));
     }
 
-    static EvaluationContext BuildContext(Dictionary<string, string> context)
+    static EvaluationContext BuildContext(Dictionary<string, string>? context)
     {
         var builder = EvaluationContext.Builder();
+
+        context ??= [];
         foreach (var (key, value) in context)
         {
             builder.Set(key, value);
diff --git a/src/Octopus.OpenFeature.Provider.SpecificationTests/Octopus.OpenFeature.Provider.SpecificationTests.csproj b/src/Octopus.OpenFeature.Provider.SpecificationTests/Octopus.OpenFeature.Provider.SpecificationTests.csproj
@@ -27,7 +27,7 @@
     </ItemGroup>
 
     <ItemGroup>
-        <None Include="..\..\fixtures\**\*.json" Link="Fixtures\%(RecursiveDir)%(Filename)%(Extension)">
+        <None Include="..\..\specification\Fixtures\*.json" Link="Fixtures\%(RecursiveDir)%(Filename)%(Extension)">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
     </ItemGroup>
diff --git a/src/Octopus.OpenFeature.Provider.SpecificationTests/Server.cs b/src/Octopus.OpenFeature.Provider.SpecificationTests/Server.cs
@@ -5,7 +5,7 @@
 using WireMock.Types;
 using WireMock.Util;
 
-namespace Octopus.OpenFeature.Provider.IntegrationTests;
+namespace Octopus.OpenFeature.Provider.SpecificationTests;
 
 public class Server : IDisposable
 {
diff --git a/src/Octopus.OpenFeature.sln b/src/Octopus.OpenFeature.sln
@@ -4,7 +4,7 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Octopus.OpenFeature.Provide
 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Octopus.OpenFeature.Provider.Tests", "Octopus.OpenFeature.Provider.Tests\Octopus.OpenFeature.Provider.Tests.csproj", "{15569FBD-A9B8-478C-880B-FAC8CAF1A2BD}"
 EndProject
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Octopus.OpenFeature.Provider.IntegrationTests", "Octopus.OpenFeature.Provider.IntegrationTests\Octopus.OpenFeature.Provider.IntegrationTests.csproj", "{E3F2C4A1-9B7D-4E6F-A2B5-8C3D1F0E5A9B}"
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Octopus.OpenFeature.Provider.SpecificationTests", "Octopus.OpenFeature.Provider.SpecificationTests\Octopus.OpenFeature.Provider.SpecificationTests.csproj", "{E3F2C4A1-9B7D-4E6F-A2B5-8C3D1F0E5A9B}"
 EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+[submodule "specification"]`
	`2`	`+ path = specification`
	`3`	`+ url = https://github.com/OctopusDeploy/openfeature-provider-specification.git`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`	`using OpenFeature.Constant;`
`5`	`5`	`using OpenFeature.Model;`
`6`	`6`
`7`		`-namespace Octopus.OpenFeature.Provider.IntegrationTests;`
	`7`	`+namespace Octopus.OpenFeature.Provider.SpecificationTests;`
`8`	`8`
`9`	`9`	`public class FixtureEvaluationTests(Server server) : IClassFixture<Server>`
`10`	`10`	`{`
`@@ -32,9 +32,11 @@ public async Task Evaluate(string testResponse, FixtureCase testCase)`
`32`	`32`	`result.ErrorType.Should().Be(MapErrorCode(testCase.Expected.ErrorCode));`
`33`	`33`	`}`
`34`	`34`
`35`		`- static EvaluationContext BuildContext(Dictionary<string, string> context)`
	`35`	`+ static EvaluationContext BuildContext(Dictionary<string, string>? context)`
`36`	`36`	`{`
`37`	`37`	`var builder = EvaluationContext.Builder();`
	`38`	`+`
	`39`	`+ context ??= [];`
`38`	`40`	`foreach (var (key, value) in context)`
`39`	`41`	`{`
`40`	`42`	`builder.Set(key, value);`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`using WireMock.Types;`
`6`	`6`	`using WireMock.Util;`
`7`	`7`
`8`		`-namespace Octopus.OpenFeature.Provider.IntegrationTests;`
	`8`	`+namespace Octopus.OpenFeature.Provider.SpecificationTests;`
`9`	`9`
`10`	`10`	`public class Server : IDisposable`
`11`	`11`	`{`