chore: clean up verbose comments in batch-aware changes

Author: douglance

packages/assertion-monitor/__test__/monitoring.test.ts

@@ -92,7 +92,6 @@ describe('Assertion Health Monitoring', () => {
       recentConfirmationEvent: null,
       isValidatorWhitelistDisabled: false,
       isBaseStakeBelowThreshold: false,
-      // By default, no batches posted (lastBlockIncludedInBatch <= childLatestCreatedBlock)
       lastBlockIncludedInBatch: 800n,
     }
   }
@@ -150,7 +149,6 @@ describe('Assertion Health Monitoring', () => {
         timestamp: NOW - BigInt(5 * 60 * 60), // 5 hours ago
         number: 900n,
       } as Block
-      // Set batches posted beyond the last asserted block
       chainState.lastBlockIncludedInBatch = 1000n
 
       const alerts = await analyzeAssertionEvents(
@@ -168,13 +166,11 @@ describe('Assertion Health Monitoring', () => {
 
     test('should NOT alert when no batches posted (low activity)', async () => {
       const chainState = createBaseChainState()
-      // Set creation event to be older than the recent activity threshold (4 hours)
       chainState.childLatestCreatedBlock = {
         ...chainState.childLatestCreatedBlock!,
         timestamp: NOW - BigInt(5 * 60 * 60), // 5 hours ago
         number: 900n,
       } as Block
-      // But no batches posted beyond the last asserted block
       chainState.lastBlockIncludedInBatch = 800n
 
       const alerts = await analyzeAssertionEvents(
@@ -183,7 +179,6 @@ describe('Assertion Health Monitoring', () => {
         true
       )
 
-      // Should NOT alert - no batches posted means no activity requiring assertions
       expect(alerts).not.toContain(CHAIN_ACTIVITY_WITHOUT_ASSERTIONS_ALERT)
     })
 
@@ -320,7 +315,6 @@ describe('Assertion Health Monitoring', () => {
         number: 1800n,
       } as Block
 
-      // Set batches posted beyond the last asserted block
       chainState.lastBlockIncludedInBatch = 1900n
 
       // Set values to trigger confirmation delay
@@ -567,7 +561,6 @@ describe('Assertion Health Monitoring', () => {
         timestamp: NOW - BigInt(5 * 60 * 60), // 5 hours ago
         number: 900n,
       } as Block
-      // Set batches posted beyond the last asserted block
       chainState.lastBlockIncludedInBatch = 1000n
 
       const alerts = await analyzeAssertionEvents(
@@ -643,7 +636,6 @@ describe('Assertion Health Monitoring', () => {
         timestamp: NOW - BigInt(7 * 24 * 60 * 60), // 7 days ago
         number: 900n,
       } as Block
-      // Set batches posted beyond the last asserted block to trigger batch alert
       chainState.lastBlockIncludedInBatch = 1000n
 
       const alerts = await analyzeAssertionEvents(
@@ -652,10 +644,7 @@ describe('Assertion Health Monitoring', () => {
         false
       )
 
-      // The implementation will generate other alerts, but not CREATION_EVENT_STUCK_ALERT
       expect(alerts).not.toContain(CREATION_EVENT_STUCK_ALERT)
-
-      // With batches posted, it should alert about batches without assertions
       expect(alerts).toContain(CHAIN_ACTIVITY_WITHOUT_ASSERTIONS_ALERT)
     })
 
@@ -668,7 +657,6 @@ describe('Assertion Health Monitoring', () => {
         number: 900n,
       } as Block
 
-      // Set batches posted beyond the last asserted block
       chainState.lastBlockIncludedInBatch = 1000n
 
       // Set parent chain blocks to indicate a delay

packages/assertion-monitor/blockchain.ts

@@ -387,8 +387,6 @@ export const fetchChainState = async ({
     isBold
   )
 
-  // Query last block included in batches from Bridge contract
-  // Fail safe: if query fails, return undefined (won't trigger batch-related alerts)
   let lastBlockIncludedInBatch: bigint | undefined
   try {
     lastBlockIncludedInBatch = await parentClient.readContract({

packages/assertion-monitor/types.ts

@@ -63,6 +63,6 @@ export interface ChainState {
   isBaseStakeBelowThreshold: boolean
   searchFromBlock?: bigint
   searchToBlock?: bigint
-  /** Last child chain block number included in a batch (from sequencerReportedSubMessageCount) */
+  /** Last child block included in a batch */
   lastBlockIncludedInBatch?: bigint
 }