test: verify CI output comparison diff#94
Open
douglance wants to merge 5 commits intofeat/output-comparison-cifrom
Open
test: verify CI output comparison diff#94douglance wants to merge 5 commits intofeat/output-comparison-cifrom
douglance wants to merge 5 commits intofeat/output-comparison-cifrom
Conversation
|
a3524fb to
5d3de1d
Compare
5d3de1d to
84eed38
Compare
The sed patterns were not matching anything because: - "Assertion Monitor Alert Summary" only outputs when alerts exist - "Monitoring complete" wasn't being captured properly Now captures ALL stdout, letting diff find the actual differences. Also increased timeout from 180s to 300s for reliability.
- Add [SLACK_MESSAGE_START/END] markers in createSlackPoster for CI mode - Extract Slack messages separately from full output - Show Slack message diff prominently, full output in collapsible details - Set NODE_ENV=CI when running monitors in CI workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test PR to verify the CI output comparison shows a real diff.
This branch has a test change in
alerts.ts:Expected Result
The CI output comparison comment should show this change in the assertion monitor section.