Skip to content

Commit 2c1d28c

Browse files
committed
fix(bridge): update paginated tx copy when settling pending transfers
A submitted transfer exists in both the new_tx_list SWR cache and the paginated txPages (seeded from the localStorage deposits cache). mergeTransactions displays the txPages copy, but updateCachedTransaction returned early after updating the new_tx_list copy, so the displayed row could stay pending forever once txPages captured it while still pending. Fall through and update the txPages copy too.
1 parent 092ae7a commit 2c1d28c

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

packages/arb-token-bridge-ui/src/hooks/useTransactionHistory.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -963,11 +963,11 @@ export const useTransactionHistory = (
963963
if (isLifiTransfer(newTx)) {
964964
updateLifiTransactionInCache(newTx);
965965
}
966-
return;
967966
}
968967

969-
// tx not found in the new user initiated transaction list
970-
// look in the paginated historical data
968+
// the same tx can also exist in the paginated history (txPages, seeded from the
969+
// localStorage deposits cache), and mergeTransactions displays that copy, so it
970+
// must be updated too
971971
mutateTxPages((prevTxPages) => {
972972
if (!prevTxPages) {
973973
return;

0 commit comments

Comments
 (0)