fix(bridge): clear stale LiFi pending transfers whose source tx never landed

Author: dewanshparashar

packages/arb-token-bridge-ui/src/components/TransactionHistory/helpers.ts

@@ -566,6 +566,13 @@ export async function getUpdatedCctpTransfer(tx: MergedTransaction): Promise<Mer
   return { ...tx, status: WithdrawalStatus.UNCONFIRMED };
 }
 
+// A LiFi entry is cached optimistically once the wallet returns a source tx hash. If that
+// transaction never actually lands on-chain (reverted, or dropped from the mempool and never
+// mined), the entry would otherwise sit "pending" forever — LiFi's status API keeps reporting
+// PENDING for a hash it never saw. We only treat a missing transaction as dropped after a grace
+// window, so a tx that is merely still propagating isn't reconciled away prematurely.
+const LIFI_SOURCE_TX_DROPPED_THRESHOLD_MS = 1000 * 60 * 30; // 30 minutes
+
 export async function getUpdatedLifiTransfer(
   tx: LifiMergedTransaction,
 ): Promise<MergedTransaction> {
@@ -578,6 +585,40 @@ export async function getUpdatedLifiTransfer(
     return tx;
   }
 
+  // Vet the cached source transaction against the chain before trusting LiFi's status.
+  try {
+    const sourceChainProvider = getProviderForChainId(tx.sourceChainId);
+    const sourceTxReceipt = await sourceChainProvider.getTransactionReceipt(tx.txId);
+
+    if (sourceTxReceipt) {
+      if (sourceTxReceipt.status === 0) {
+        // Source transaction reverted on-chain — terminal failure.
+        return {
+          ...tx,
+          status: WithdrawalStatus.FAILURE,
+          destinationStatus: WithdrawalStatus.FAILURE,
+        };
+      }
+    } else {
+      const pendingSourceTx = await sourceChainProvider.getTransaction(tx.txId);
+      const isOlderThanDropThreshold =
+        typeof tx.createdAt === 'number' &&
+        dayjs().valueOf() - tx.createdAt > LIFI_SOURCE_TX_DROPPED_THRESHOLD_MS;
+
+      // No receipt and the node no longer knows the tx: it was dropped and never mined, so the
+      // funds never moved. Mark terminal so it stops counting as a pending transfer.
+      if (!pendingSourceTx && isOlderThanDropThreshold) {
+        return {
+          ...tx,
+          status: WithdrawalStatus.FAILURE,
+          destinationStatus: WithdrawalStatus.FAILURE,
+        };
+      }
+    }
+  } catch {
+    // RPC hiccup — don't make a terminal decision; fall back to LiFi's status below.
+  }
+
   const statusResponse = await getStatus({
     txHash: tx.txId,
     bridge: tx.toolDetails.key,