From d734fc785423ec7bb71f77bf0b2a237e335a2c73 Mon Sep 17 00:00:00 2001 From: spsjvc Date: Fri, 13 Jun 2025 11:19:08 +0200 Subject: [PATCH 1/2] refactor: pass in ui driver context to executor --- .../src/components/TransferPanel/TransferPanel.tsx | 2 +- packages/arb-token-bridge-ui/src/ui-driver/UiDriver.ts | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/arb-token-bridge-ui/src/components/TransferPanel/TransferPanel.tsx b/packages/arb-token-bridge-ui/src/components/TransferPanel/TransferPanel.tsx index 4e07d5e7fb..3e1dd3f923 100644 --- a/packages/arb-token-bridge-ui/src/components/TransferPanel/TransferPanel.tsx +++ b/packages/arb-token-bridge-ui/src/components/TransferPanel/TransferPanel.tsx @@ -383,7 +383,7 @@ export function TransferPanel() { return true } - const stepExecutor: UiDriverStepExecutor = async step => { + const stepExecutor: UiDriverStepExecutor = async (context, step) => { if (process.env.NODE_ENV === 'development') { console.log(step) } diff --git a/packages/arb-token-bridge-ui/src/ui-driver/UiDriver.ts b/packages/arb-token-bridge-ui/src/ui-driver/UiDriver.ts index e8de84464a..6cc929cfd8 100644 --- a/packages/arb-token-bridge-ui/src/ui-driver/UiDriver.ts +++ b/packages/arb-token-bridge-ui/src/ui-driver/UiDriver.ts @@ -64,6 +64,7 @@ export type UiDriverStepGenerator = ( ) => AsyncGenerator> export type UiDriverStepExecutor = ( + context: UiDriverContext, step: TStep ) => Promise> @@ -100,7 +101,7 @@ export async function drive( } // execute current step and obtain the result - const result = await executor(step) + const result = await executor(context, step) // pass the result back into the generator nextStep = await flow.next(result) From 5b08d85be9e33b607afb745a04b2e920f88511a0 Mon Sep 17 00:00:00 2001 From: spsjvc Date: Fri, 13 Jun 2025 16:25:45 +0200 Subject: [PATCH 2/2] fix --- packages/arb-token-bridge-ui/src/ui-driver/UiDriver.test.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/arb-token-bridge-ui/src/ui-driver/UiDriver.test.ts b/packages/arb-token-bridge-ui/src/ui-driver/UiDriver.test.ts index c25d8cb676..6ced220125 100644 --- a/packages/arb-token-bridge-ui/src/ui-driver/UiDriver.test.ts +++ b/packages/arb-token-bridge-ui/src/ui-driver/UiDriver.test.ts @@ -16,7 +16,7 @@ it('successfully does step execution', async () => { yield { type: 'start' } } - const executor: UiDriverStepExecutor = async function (step) { + const executor: UiDriverStepExecutor = async function (_, step) { if (step.type === 'start') { counter += 1 } @@ -39,7 +39,7 @@ it('successfully does early return', async () => { yield { type: 'start' } } - const executor: UiDriverStepExecutor = async function (step) { + const executor: UiDriverStepExecutor = async function (_, step) { if (step.type === 'start') { counter += 1 }