Merge pull request #3520 from OffchainLabs/nit-3549-globalstate-not-in-chain-should-be-a-fatal-error-for

Return a fatal error instead of stopping the StopWaiter in case of Er…

Author: tsahee

staker/bold/bold_staker.go

@@ -210,6 +210,7 @@ type BOLDStaker struct {
 	confirmedNotifiers []legacystaker.LatestConfirmedNotifier
 	inboxTracker       staker.InboxTrackerInterface
 	inboxStreamer      staker.TransactionStreamerInterface
+	fatalErr           chan<- error
 }
 
 func NewBOLDStaker(
@@ -229,6 +230,7 @@ func NewBOLDStaker(
 	inboxTracker staker.InboxTrackerInterface,
 	inboxStreamer staker.TransactionStreamerInterface,
 	inboxReader staker.InboxReaderInterface,
+	fatalErr chan<- error,
 ) (*BOLDStaker, error) {
 	if err := config.Validate(); err != nil {
 		return nil, err
@@ -251,6 +253,7 @@ func NewBOLDStaker(
 		confirmedNotifiers: confirmedNotifiers,
 		inboxTracker:       inboxTracker,
 		inboxStreamer:      inboxStreamer,
+		fatalErr:           fatalErr,
 	}, nil
 }
 
@@ -311,8 +314,10 @@ func (b *BOLDStaker) Start(ctxIn context.Context) {
 		confirmedMsgCount, confirmedGlobalState, err := b.getLatestState(ctx, true)
 		if err != nil {
 			log.Error("staker: error checking latest confirmed", "err", err)
-			b.StopWaiter.StopAndWait()
-			return time.Duration(0)
+			if errors.Is(err, staker.ErrGlobalStateNotInChain) {
+				b.fatalErr <- err
+			}
+			return b.config.AssertionPostingInterval
 		}
 
 		agreedMsgCount, agreedGlobalState, err := b.getLatestState(ctx, false)

staker/multi_protocol/multi_protocol_staker.go

@@ -52,6 +52,7 @@ type MultiProtocolStaker struct {
 	inboxTracker            staker.InboxTrackerInterface
 	inboxStreamer           staker.TransactionStreamerInterface
 	inboxReader             staker.InboxReaderInterface
+	fatalErr                chan<- error
 }
 
 func NewMultiProtocolStaker(
@@ -121,6 +122,7 @@ func NewMultiProtocolStaker(
 		inboxTracker:            inboxTracker,
 		inboxStreamer:           inboxStreamer,
 		inboxReader:             inboxReader,
+		fatalErr:                fatalErr,
 	}, nil
 }
 
@@ -262,6 +264,7 @@ func (m *MultiProtocolStaker) setupBoldStaker(
 		m.inboxTracker,
 		m.inboxStreamer,
 		m.inboxReader,
+		m.fatalErr,
 	)
 	if err != nil {
 		return err