Merge remote-tracking branch 'origin/master' into fix-historical-feed-flood

Resolved transaction_streamer.go: kept both config options and adapted
to new broadcaster API (BroadcastFeedMessages).

Author: Tristan-Wilson

.github/actions/lint-go/action.yml

@@ -0,0 +1,16 @@
+---
+name: 'Lint Go Code'
+description: 'Runs both golangci-lint and custom linters on the Go codebase.'
+
+runs:
+  using: composite
+
+  steps:
+    - name: GolangCI Lint
+      uses: golangci/golangci-lint-action@v9
+      with:
+        version: v2.5
+
+    - name: Custom Lint
+      shell: bash
+      run: go run ./linters ./...

.github/workflows/_arbitrator.yml

@@ -13,7 +13,7 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v5
+        uses: actions/checkout@v6
         with:
           submodules: recursive
 
@@ -65,9 +65,9 @@ jobs:
 
       - name: Upload rust test results
         if: always()
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v5
         with:
-          name: rust-junit-reports
+          name: junit-reports-rust
           path: ./arbitrator/target/nextest/ci/junit.xml
 
       - name: Fail if rust tests failed

.github/workflows/_bold-legacy.yml

@@ -9,21 +9,24 @@ jobs:
     runs-on: arbitrator-ci
     steps:
       - name: Checkout
-        uses: actions/checkout@v5
+        uses: actions/checkout@v6
         with:
           submodules: recursive
 
 
       - name: Setup CI
         uses: ./.github/actions/ci-setup
 
+      - name: Build
+        run: make -j8 build test-go-deps
+
       - name: run challenge tests
         run: >-
           ${{ github.workspace }}/.github/workflows/gotestsum.sh --tags legacychallengetest
           --run TestChallenge --timeout 60m --cover
 
       - name: Archive detailed run log
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v5
         with:
           name: full.log
           path: full.log

.github/workflows/_codecov.yml

@@ -4,8 +4,8 @@ on:
   workflow_call:
     secrets:
       CODECOV_TOKEN:
-        required: true
-        description: Token to upload reports to Codecov.
+        required: false
+        description: Token to upload reports to Codecov. Required if `upload_report` is on.
     inputs:
       post_comment:
         description: 'Set to true to post a test summary comment on the PR.'
@@ -30,20 +30,13 @@ jobs:
 
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v5
-
-      - name: Download Go JUnit reports
-        uses: actions/download-artifact@v4
-        with:
-          name: go-junit-reports
-          path: downloaded-reports/go
+        uses: actions/checkout@v6
 
-      - name: Download Rust JUnit reports
-        uses: actions/download-artifact@v4
-        continue-on-error: true # Rust pipeline might have not been run
+      - name: Download JUnit reports
+        uses: actions/download-artifact@v6
         with:
-          name: rust-junit-reports
-          path: downloaded-reports/rust
+          pattern: junit-reports-*
+          path: downloaded-reports/
 
       - name: Post test summary comment
         if: ${{ inputs.post_comment }}

.github/workflows/_detect-changes.yml

@@ -0,0 +1,42 @@
+---
+name: detect-file-changes
+
+on:
+  workflow_call:
+    outputs:
+      arbitrator_changed:
+        description: 'True if Arbitrator or related files changed.'
+        value: ${{ jobs.changes.outputs.arbitrator_changed }}
+      bold_legacy_changed:
+        description: 'True if Bold Legacy or related files changed.'
+        value: ${{ jobs.changes.outputs.bold_legacy_changed }}
+
+jobs:
+  changes:
+    name: Detect file changes
+    runs-on: ubuntu-4
+    outputs:
+      arbitrator_changed: ${{ steps.changed.outputs.arbitrator_any_changed }}
+      bold_legacy_changed: ${{ steps.changed.outputs.bold_legacy_any_changed }}
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v6
+        with:
+          submodules: recursive
+          fetch-depth: 10            # Will cover most PRs
+          persist-credentials: true  # In case changed-files requires deeper depth
+
+      - name: Determine if Arbitrator or Bold Legacy changed
+        id: changed
+        uses: tj-actions/[email protected]
+        with:
+          files_yaml: |
+            arbitrator:
+              - 'arbitrator/**'
+              - 'contracts/**'
+              - 'Makefile'
+              - '.github/workflows/_arbitrator.yml'
+            bold_legacy:
+              - 'bold/legacy/**'
+              - '.github/workflows/_bold-legacy.yml'

.github/workflows/_fast.yml

@@ -9,7 +9,7 @@ jobs:
     runs-on: arbitrator-ci
     steps:
       - name: Checkout
-        uses: actions/checkout@v5
+        uses: actions/checkout@v6
         with:
           submodules: recursive
 
@@ -22,11 +22,5 @@ jobs:
       - name: Build all lint dependencies
         run: make -j8 build-node-deps
 
-      - name: GolangCI Lint
-        uses: golangci/golangci-lint-action@v8
-        with:
-          version: v2.5
-
-      - name: Custom Lint
-        run: |
-          go run ./linters ./...
+      - name: Setup CI
+        uses: ./.github/actions/lint-go