Merge branch 'master' into fix-workflows

Author: rauljordan

CONTRIBUTING.md

@@ -127,7 +127,7 @@ Save and close the file, then a commit command will appear in the terminal that
 **17. Update your pull request with the following command.**
 
 ```
-$ git push mynitrorepo feature-in-progress-branch -f
+$ git push mynitrorepo feature-in-progress-branch
 ```
 
 **18.  Finally, again leave a comment to the Core Contributors on the pull request to let them know that the pull request has been updated.**

arbos/arbosState/initialization_test.go

@@ -182,7 +182,43 @@ func checkRetryables(arbState *ArbosState, expected []statetransfer.Initializati
 		if found == nil {
 			Fail(t)
 		}
-		// TODO: detailed comparison
+
+		// Detailed comparison
+		from, err := found.From()
+		Require(t, err)
+		if from != exp.From {
+			t.Fatalf("Retryable %v: from mismatch. Expected %v, got %v", exp.Id, exp.From, from)
+		}
+
+		to, err := found.To()
+		Require(t, err)
+		if (to == nil && exp.To != common.Address{}) || (to != nil && exp.To == common.Address{}) || (to != nil && exp.To != common.Address{} && *to != exp.To) {
+			t.Fatalf("Retryable %v: to mismatch. Expected %v, got %v", exp.Id, exp.To, to)
+		}
+
+		callvalue, err := found.Callvalue()
+		Require(t, err)
+		if callvalue.Cmp(exp.Callvalue) != 0 {
+			t.Fatalf("Retryable %v: callvalue mismatch. Expected %v, got %v", exp.Id, exp.Callvalue, callvalue)
+		}
+
+		beneficiary, err := found.Beneficiary()
+		Require(t, err)
+		if beneficiary != exp.Beneficiary {
+			t.Fatalf("Retryable %v: beneficiary mismatch. Expected %v, got %v", exp.Id, exp.Beneficiary, beneficiary)
+		}
+
+		calldata, err := found.Calldata()
+		Require(t, err)
+		if !bytes.Equal(calldata, exp.Calldata) {
+			t.Fatalf("Retryable %v: calldata mismatch. Expected %v, got %v", exp.Id, exp.Calldata, calldata)
+		}
+
+		timeout, err := found.CalculateTimeout()
+		Require(t, err)
+		if timeout != exp.Timeout {
+			t.Fatalf("Retryable %v: timeout mismatch. Expected %v, got %v", exp.Id, exp.Timeout, timeout)
+		}
 	}
 }
 

arbos/internal_tx.go

@@ -9,6 +9,7 @@ import (
 	"math/big"
 
 	"github.com/ethereum/go-ethereum/common"
+	"github.com/ethereum/go-ethereum/core"
 	"github.com/ethereum/go-ethereum/core/types"
 	"github.com/ethereum/go-ethereum/core/vm"
 	"github.com/ethereum/go-ethereum/log"
@@ -55,6 +56,15 @@ func ApplyInternalTxUpdate(tx *types.ArbitrumInternalTx, state *arbosState.Arbos
 			return err
 		}
 
+		var prevHash common.Hash
+		if evm.Context.BlockNumber.Sign() > 0 {
+			prevHash = evm.Context.GetHash(evm.Context.BlockNumber.Uint64() - 1)
+		}
+		// For ArbOS versions >= 40 we need to call ProcessParentBlockHash to fill
+		// the historyStorage with the block hash to support EIP-2935.
+		if state.ArbOSVersion() >= params.ArbosVersion_40 {
+			core.ProcessParentBlockHash(prevHash, evm)
+		}
 		l1BlockNumber := util.SafeMapGet[uint64](inputs, "l1BlockNumber")
 		timePassed := util.SafeMapGet[uint64](inputs, "timePassed")
 		if state.ArbOSVersion() < params.ArbosVersion_3 {
@@ -73,10 +83,6 @@ func ApplyInternalTxUpdate(tx *types.ArbitrumInternalTx, state *arbosState.Arbos
 		state.Restrict(err)
 
 		if l1BlockNumber > oldL1BlockNumber {
-			var prevHash common.Hash
-			if evm.Context.BlockNumber.Sign() > 0 {
-				prevHash = evm.Context.GetHash(evm.Context.BlockNumber.Uint64() - 1)
-			}
 			state.Restrict(state.Blockhashes().RecordNewL1Block(l1BlockNumber-1, prevHash, state.ArbOSVersion()))
 		}
 

go-ethereum

@@ -156,7 +156,7 @@ func TestChallengeProtocolBOLD_Bisections(t *testing.T) {
 }
 
 func TestChallengeProtocolBOLD_StateProvider(t *testing.T) {
-	// t.Parallel()
+	t.Parallel()
 	ctx, cancelCtx := context.WithCancel(context.Background())
 	defer cancelCtx()
 	maxNumBlocks := uint64(1 << 14)
@@ -358,6 +358,7 @@ func setupBoldStateProvider(t *testing.T, ctx context.Context, blockChallengeHei
 	sconf := setup.RollupStackConfig{
 		UseMockBridge:          false,
 		UseMockOneStepProver:   false,
+		UseBlobs:               true,
 		MinimumAssertionPeriod: 0,
 	}
 

system_tests/bold_state_provider_test.go

@@ -0,0 +1,59 @@
+package arbtest
+
+import (
+	"bytes"
+	"context"
+	"encoding/binary"
+	"math/big"
+	"testing"
+
+	"github.com/ethereum/go-ethereum/common"
+	"github.com/ethereum/go-ethereum/params"
+
+	"github.com/offchainlabs/nitro/statetransfer"
+)
+
+func TestHistoricalBlockHash(t *testing.T) {
+	t.Parallel()
+	ctx, cancel := context.WithCancel(context.Background())
+	defer cancel()
+
+	builder := NewNodeBuilder(ctx).DefaultConfig(t, true)
+	contractInfo := &statetransfer.AccountInitContractInfo{
+		Code:            params.HistoryStorageCodeArbitrum,
+		ContractStorage: make(map[common.Hash]common.Hash),
+	}
+	accountInfo := statetransfer.AccountInitializationInfo{
+		Addr:         params.HistoryStorageAddress,
+		EthBalance:   big.NewInt(0),
+		Nonce:        1,
+		ContractInfo: contractInfo,
+	}
+	builder.L2Info.ArbInitData.Accounts = append(builder.L2Info.ArbInitData.Accounts, accountInfo)
+	cleanup := builder.Build(t)
+	defer cleanup()
+
+	for {
+		builder.L2.TransferBalance(t, "Faucet", "Faucet", common.Big1, builder.L2Info)
+		number, err := builder.L2.Client.BlockNumber(ctx)
+		Require(t, err)
+		if number > 300 {
+			break
+		}
+	}
+
+	block, err := builder.L2.Client.BlockByNumber(ctx, nil)
+	Require(t, err)
+
+	for i := uint64(0); i < block.Number().Uint64(); i++ {
+		var key common.Hash
+		binary.BigEndian.PutUint64(key[24:], i)
+		expectedBlock, err := builder.L2.Client.BlockByNumber(ctx, new(big.Int).SetUint64(i))
+		Require(t, err)
+		blockHash := sendContractCall(t, ctx, params.HistoryStorageAddress, builder.L2.Client, key.Bytes())
+		if !bytes.Equal(blockHash, expectedBlock.Hash().Bytes()) {
+			t.Fatalf("Expected block hash %s, got %s", expectedBlock.Hash(), blockHash)
+		}
+	}
+
+}

system_tests/historical_block_hash_test.go

@@ -69,6 +69,7 @@ func TestOverflowAssertions(t *testing.T) {
 		UseMockBridge:          false,
 		UseMockOneStepProver:   false,
 		MinimumAssertionPeriod: minAssertionBlocks,
+		UseBlobs:               true,
 	}
 
 	_, l2node, _, _, l1info, _, l1client, l1stack, assertionChain, _ := createTestNodeOnL1ForBoldProtocol(t, ctx, true, nil, l2chainConfig, nil, sconf, l2info)