Replace fixed sleep delays with active polling in prometheus service test #15828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
previously approved these changes
Oct 9, 2025
|
@prestonvanloon added a changelog fragment |
prestonvanloon
approved these changes
Oct 9, 2025
auto-merge was automatically disabled
October 9, 2025 15:29
Pull Request is not mergeable
|
@prestonvanloon any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
What type of PR is this?
What does this PR do? Why is it needed?
Replaces fixed
time.Sleep(time.Second)delays inTestLifecyclewith active polling to wait for service readiness/shutdown. This improves test reliability and reduces execution time by eliminating unnecessary waits when services start/stop faster than expected.Which issues(s) does this PR fix?
N/A - Minor test improvement
Other notes for review
Acknowledgements