changing ErrNotDescendantOfFinalized to ErrRootNotInForkChoice #15836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
changed the title
This can't be accurate, we do not reject attestations for blocks we do not know. |
potuz
requested changes
Oct 10, 2025
|
|
||
| // ErrRootNotInForkchoice is returned when a root cannot be found in forkchoice. | ||
| func ErrRootNotInForkchoice(root [fieldparams.RootLength]byte) invalidBlock { | ||
| return invalidBlock{error: fmt.Errorf("root %#x not in forkchoice", root), root: root} |
There was a problem hiding this comment.
Why this? this is a very dangerous change.
There was a problem hiding this comment.
nah, my bad, read this incorrectly, this is fine, reviewing.
potuz
reviewed
Oct 10, 2025
| // Shared validations for the entire bucket. | ||
| if !s.cfg.chain.InForkchoice(bytesutil.ToBytes32(data.BeaconBlockRoot)) { | ||
| log.WithError(blockchain.ErrNotDescendantOfFinalized).WithField("root", fmt.Sprintf("%#x", data.BeaconBlockRoot)).Debug("Failed forkchoice check for bucket") | ||
| log.WithError(blockchain.ErrRootNotInForkchoice(bytesutil.ToBytes32(data.BeaconBlockRoot))).Debug("Failed forkchoice check for bucket") |
There was a problem hiding this comment.
I'm not sure why we need to return an invalid block and a root here.
| if !s.cfg.chain.InForkchoice(bytesutil.ToBytes32(data.BeaconBlockRoot)) { | ||
| tracing.AnnotateError(span, blockchain.ErrNotDescendantOfFinalized) | ||
| return pubsub.ValidationIgnore, blockchain.ErrNotDescendantOfFinalized | ||
| tracing.AnnotateError(span, blockchain.ErrRootNotInForkchoice(bytesutil.ToBytes32(data.BeaconBlockRoot))) |
| if !s.cfg.chain.InForkchoice(blockRoot) { | ||
| tracing.AnnotateError(span, blockchain.ErrNotDescendantOfFinalized) | ||
| return pubsub.ValidationIgnore, blockchain.ErrNotDescendantOfFinalized | ||
| tracing.AnnotateError(span, blockchain.ErrRootNotInForkchoice(blockRoot)) |
| func (s *Service) validatePhase0Block(ctx context.Context, blk interfaces.ReadOnlySignedBeaconBlock, blockRoot [32]byte) (state.BeaconState, error) { | ||
| if !s.cfg.chain.InForkchoice(blk.Block().ParentRoot()) { | ||
| s.setBadBlock(ctx, blockRoot) | ||
| return nil, blockchain.ErrNotDescendantOfFinalized |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
The gossip ignored issue is likely caused by the below however the error didn't provide clarity on the underlying reason.
- Node A produces block at slot N
- Node A broadcasts block + attestations
- Node B receives attestations for block N before it finishes processing block N
- Node B's gossip validation ignores attestations because block N is not yet in forkchoice
- This is logged as "Gossip message was ignored"
Which issues(s) does this PR fix?
Fixes #5812
alternative to #15840
Other notes for review
Acknowledgements