Skip to content
This repository has been archived by the owner on Jun 18, 2024. It is now read-only.
This repository has been archived by the owner on Jun 18, 2024. It is now read-only.

Move font license warning into mixin #998

Open
@mikewheaton

Description

The purpose of References.scss is to provide a reference to all of the variables and mixins, without generating any output in the built CSS file. We're doing a good job of this with one exception: the warning about using the Fabric assets, such as icons and fonts. This comment is included in any built CSS file that imports our references.

Steps to fix:

  • Move the comment into the ms-font-face() mixin, so that it is only included in the CSS when that mixin is used. See this CodePen demo of how CSS comments can be included in SCSS mixins.
  • Identify other places that the CDN is referenced and make sure those have appropriate warnings as well. The warning should be included whenever we have a reference to the CDN, and at no other time.

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions