Merge branch 'main' into testGuestLoadMetrics

Author: OhadRevah

docs/QUARANTINE.md

@@ -0,0 +1,2 @@
+## TODO: Add full procedure for quarantine and de-quarantine
+## De-quarantine: add a section on pytest-repeat and how to use it

pyproject.toml

@@ -99,6 +99,7 @@ packages = ["*"]
 dev = [
     "ipdb>=0.13.13",
     "ipython>=8.12.3",
+    "pytest-repeat>=0.9.4",
 ]
 
 [tool.uv.sources]

tests/virt/cluster/common_templates/utils.py

@@ -531,7 +531,7 @@ def _check_hyperv_recommendations():
         ]
 
         if failed_vm_recommendations:
-            failed_recommendations.append(failed_vm_recommendations)
+            failed_recommendations.extend(failed_vm_recommendations)
 
         spinlocks = vm_recommendations_dict["SpinlockRetries"]
         if int(spinlocks) != 8191:
@@ -575,7 +575,7 @@ def _check_hyperv_features():
     failed_windows_hyperv_list.extend(_check_hyperv_features())
 
     if not hvinfo_dict["HyperVsupport"]:
-        failed_windows_hyperv_list.extend("HyperVsupport")
+        failed_windows_hyperv_list.append("HyperVsupport")
 
     assert not failed_windows_hyperv_list, (
         f"The following hyperV flags are not set correctly in the guest: {failed_windows_hyperv_list}\n"