Skip to content

Commit bcfb21d

Browse files
authored
Rectifying and enhancing incorrect comment WRT "Icon:" tag
No icon *path*, just a pure basename makes sense in the SOURCE directory, because dirname of the icon path is always stripped by `rpmbuild`.
1 parent 1477c5e commit bcfb21d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

rpm/mount-sdcard.spec

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ License: MIT
1717
URL: https://github.com/Olf0/%{name}
1818
Source: https://github.com/Olf0/%{name}/archive/%{version}/%{name}-%{version}.tar.gz
1919
# rpmbuild (as of v4.14.1) handles the Icon tag awkwardly and in contrast to the Source tag(s):
20-
# It only accepts a file path to a GIF or XPM file (successfully tested GIF89a and XPMv3) rooted
21-
# in the SOURCE directory (but not in the tarball)!
20+
# It only accepts a GIF or XPM file (successfully tested GIF89a and XPMv3, but an XPM icon results
21+
# in a bad visual quality and large file size) in the SOURCE directory (but not in the tarball)!
2222
# Hence only to be used, when the file is put there:
2323
# Icon: smartmedia_unmount.256x256.gif
2424
BuildArch: noarch

0 commit comments

Comments
 (0)